Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Tue, 17 Oct 2023 17:01:34 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     "Russell King (Oracle)" <linux@armlinux.org.uk>,
        netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Michael Walle <michael@walle.cc>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: mdio-mux: fix C45 access returning -EIO after
 API change
Message-ID: <20231017140134.ce3cjv3bhbq3k4m6@skbuf>
References: <20231017113222.3135895-1-vladimir.oltean@nxp.com>
 <ZS6Mskpb6gDpBD3z@shell.armlinux.org.uk>
 <4ccd7dc9-b611-48aa-865f-68d3a1327ce8@lunn.ch>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4ccd7dc9-b611-48aa-865f-68d3a1327ce8@lunn.ch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kq+Br5I2x1Ry5u2NNgLLeruRfYwPxmczsWD7Rw3fw5ZWK6gKI86U5IRDEC0k?=
 =?us-ascii?Q?YqwI16XSL9P6zNag984vFsJ1BrPAUuocD9OdGnpWrlQ6QW3Y3abL8BBLmSy7?=
 =?us-ascii?Q?ja6N6rsFygJEcNRmPvQ1Y8k4lLYskzAlofj4IBcNxYIfKgHS5WdPexJ+6GN0?=
 =?us-ascii?Q?H2GwfECsRstB0CVK3apm/pcYwYRdcJ66ua/i2HWGgfXtBAcr0Whx2/k4nUd1?=
 =?us-ascii?Q?Guy6c5/ZoKcc8wh8j4DLwYO7wOKX7COuDNf35b9xKWLTDCf+vAs1HkHRlnd3?=
 =?us-ascii?Q?yuNqtdbSH3HYEiPZxjmSTWcL6OBppOUTxOdCtqxQb/+hZboh53n0A01hRAWN?=
 =?us-ascii?Q?TA/VX6pvM74zcAbA5bKGFT63i9v2cVE/REicaTLqakE/lYK9s9w90NZ23yX/?=
 =?us-ascii?Q?PrNkj/yyIHRyteJQtKWRzqW4ugEJ+OABCTpOADFANBRyVNYY0wWzEiGM+OOF?=
 =?us-ascii?Q?elmHXe2RVL0cDzCFzBQLoEVl/jQslxZuvxh8pVSPSJXlNTMYs1ccrtwb/EKP?=
 =?us-ascii?Q?Ejuk0xK1d/IidUAqXh5Htt4ivj6wKAYV/hOki++RJjg59jalGj2wU5wVAKKH?=
 =?us-ascii?Q?C8acfTBGIUiRKL+HAuY4HC0+BGeUSYm+mzoMccqXaPTmiqCWLpbd/KBD8ts+?=
 =?us-ascii?Q?OCUVGm6uhbbyCaw9AExzn5Z0rGA0+LHSnur9PnlS4Uxggf8IxWYiWMYL7opv?=
 =?us-ascii?Q?661ox966OekwemYcuux9LAfDJbQpyNCURQ+oUhVOpgJlMBiQ6SF96kIOoqIE?=
 =?us-ascii?Q?ZmbCm+KeSSEIEJ5QTjOza60/zzwXynhz0q50RbehmwDbKpY2GJDlG0wpAmPg?=
 =?us-ascii?Q?INkPLR7vDV4+JcaFeUSzeZztW9wbB1fGjB55dUi9wcUcm85euxTfUIl0BsLl?=
 =?us-ascii?Q?MZsuo4elCX8o3RcQxswARlQ05AtZSl9ClewEBFxVgiUs2zLwx4dWNLA9QNab?=
 =?us-ascii?Q?pbNbZzFal2KT8i6CxuyAzdr6Q3xzQhZmWF/ILMUuZQ0E3e7zZ9E//pgx3MoJ?=
 =?us-ascii?Q?CWhPJn8e+l7eJWapPKT5GZgrZowsJ4fqbtV8z/ZxOylG3GlU4ruKq6XGDpZ/?=
 =?us-ascii?Q?R8R3j53P7FHxEYFKx9ZhfnkZ0oU399Nt9aViKDvJSk6+yE557l7+v7fjTU6L?=
 =?us-ascii?Q?nFK1zM8xP2yAXTKH/Bpvf8FFHkUMhDnMRdwSKNuxEm0fUVksvFznv8Wmr+bA?=
 =?us-ascii?Q?np01KwgjxLRqhetkAy4Ui80rI7pNWWsTSjgDv5ZZcfNGQIR2gNRMsLuVpvwA?=
 =?us-ascii?Q?wQgbBZzH7JX4FFXkiz34ziWMVGRASzvCsQnxwA/X4M0BQ56tS3C8IB2TAb5v?=
 =?us-ascii?Q?H11oWWTH4cTKnH31Z6LGcGbnK2aFdixDIsGsW50Zf0UWq2SPO/urbmOzKt4y?=
 =?us-ascii?Q?VfTxxUVa0AXtQmbU7YfC8XU2wb/FQj1m0vhdH1+hWOUczPdIPWqHfKxdIaLC?=
 =?us-ascii?Q?2jEyLxpaJGEisjqpIEzmqJa8y6yXUZPYaVMdPE08IpW0d/v1OS9JO6F+0L82?=
 =?us-ascii?Q?yNCGEEFOeOelQIciaKwwYPAzziNTFtgQT/vg2zQA5APNWRGsThHGAmOD0v6Z?=
 =?us-ascii?Q?n5+t0tT1YP/bPB0yN8DERO88txI4ZOn9gFZgfkc3kWKQibVMWdx+jNptOWpI?=
 =?us-ascii?Q?yw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b496c93-37a1-4707-3d31-08dbcf19948c
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 14:01:37.7588
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P57MEwidqyVaco2pUQK36yJxrdqrRbhtSRGye4Le7v+fSww3C2JxGAgCsCLol9QGxIIXluk/Uh+c31fVflXAPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8118
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 17 Oct 2023 07:02:01 -0700 (PDT)

On Tue, Oct 17, 2023 at 03:44:58PM +0200, Andrew Lunn wrote:
> > Maybe make these conditional on the parent bus implementing the c45
> > read/write ops?
> 
> And optionally, for net-next, make the c22 read/write ops conditional
> on the parent bus having C22 as well. Its a bit of a corner case, but
> there are a couple of MDIO bus masters which are C45 only.
> 
> Not having C45 is however very common, so we should make this
> conditional as part of the fix.
> 
>       Andrew

Ok. I don't know if net-next will remain open after this patch gets
accepted and "net" gets merged back into it, so in order to not
completely forget, I'll add a patch with your suggestion to our
Layerscape SDK and that will serve as a reminder for the next
upstreaming session.

In the meantime, for this patch:

pw-bot: cr