Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3190264rdg; Tue, 17 Oct 2023 07:17:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFmTQKM6c5ZoVhv8Kb9AxtJC75CFgRL60+aqmkw7fHOBuBJiw4ZDDuUqnDnvbSQ6N/he+I/ X-Received: by 2002:a05:6808:14cc:b0:3ab:8574:e8ab with SMTP id f12-20020a05680814cc00b003ab8574e8abmr2835894oiw.21.1697552242292; Tue, 17 Oct 2023 07:17:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697552242; cv=none; d=google.com; s=arc-20160816; b=S439mZoPqSmRjnSdQ9w85sCEWmQ+oCTPmyDvzV0U6Uq3zvrnnpXEyYxYkScXsQzPMA q0e6MHHz6lpsVNtVr40SUnXbX6A8TfefzBuTO7xxVIGM9LleoJ4EOmVsmz1aMDUKbkrc GBS60JiBcrtCM18cZ41zoGZkNPQT6diN1kMYXRKtGB/loXgXZvAHxyk/uhIrXOs46ntk rxPAh5ohrCtDFIiA3xqBtBcmfSNDoU50kIQz/Yul4Bos0mE6UfziColWHwcovbb++0Q1 DGWsA4LtPVCBMEp4aNlwy603nWpQJPWziFY40f/ezi7Ost20hJQlNYsRr/j2tR/1jyCu FEKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=rzWYE5zWxR4YaYmFe+0XGWID7PzfYYmmrvNow3aY3S8=; fh=wz1HUkJBYzxCieNudKPCr7aUo7wDfnjg9bAoAKYY9z0=; b=fmwbDb6610wVOlPGM3OYT2rknmjpw8Yb12aeP3gyxxjEJlWVA0UHqlb44jkcQgNhD9 Bq7by/nwM1iv1GSV/SPWENDNhEuk4Im+MS4mWy6Vj6oHqiP1xlGgwWWl+PumeTEwkpYh bbn5CMGayR4VKKihPvDBgSiDU6hmqe6cvKinGrYV4A1i3uyMFopcY/iljrLh1wWnPdTz +jjuMK2+6G1lHUOE5rUgGPWewdcZQnzeiGXHZHmHs1ECSVXt/cTCtPi0apYmEvyEN96e yoiUbBNyop8O5VjcNEOpdXixU47kvhahSE8ZhTEeTz0mBkPPeseSRA8CYl1Kb3o930ik PlrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=YRgT2TIE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id d13-20020a056a0024cd00b00690c6da95c4si1795368pfv.273.2023.10.17.07.17.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 07:17:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=YRgT2TIE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id E7FCC80C7130; Tue, 17 Oct 2023 07:17:19 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343900AbjJQORH (ORCPT + 99 others); Tue, 17 Oct 2023 10:17:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344053AbjJQORD (ORCPT ); Tue, 17 Oct 2023 10:17:03 -0400 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::228]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CD6EF5 for ; Tue, 17 Oct 2023 07:17:01 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 4569D1BF206; Tue, 17 Oct 2023 14:16:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1697552220; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rzWYE5zWxR4YaYmFe+0XGWID7PzfYYmmrvNow3aY3S8=; b=YRgT2TIESp421HGFWArNrytq/Jl2NLfZZUDtPgsnpvAXKMgNPOn644HqVy/S7h/WBrZpCl gP3ZJ9sR0xFF6u/yJ5tIsFdO3zTMxGsYXZCfap+NHZQcfuF9fcyBfmI4ucniHIRDIXmwr6 afJk1w1IXCYYvuA7PmHq5yHmdxQP3/++Lfgm4X7vgu0fCuAgNak27fJKgnWsfVgYc8zkM9 JSyq+NCIKjQnhbWjS1TuOeYQdyf9Fdt8SDeYsqhcPUiRclkZYDPFCxba7Can1G13X1cEQk 0466Xg/zkf7/AvLO3xRi+iiseuh9MPORjWcCohrv00/N1TUbMaDqGi3w3sqn7Q== Date: Tue, 17 Oct 2023 16:16:58 +0200 From: Miquel Raynal To: Frank Li Cc: conor.culhane@silvaco.com, alexandre.belloni@bootlin.com, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: Re: [PATCH 1/6] i3c: master: svc: fix race condition in ibi work thread Message-ID: <20231017161658.2de6d9f3@xps-13> In-Reply-To: <20231016153232.2851095-2-Frank.Li@nxp.com> References: <20231016153232.2851095-1-Frank.Li@nxp.com> <20231016153232.2851095-2-Frank.Li@nxp.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 17 Oct 2023 07:17:20 -0700 (PDT) Hi Frank, Frank.Li@nxp.com wrote on Mon, 16 Oct 2023 11:32:27 -0400: > The ibi work thread operates asynchronously with other transfers, such as > svc_i3c_master_priv_xfers(). Introduces mutex protection to ensure the Introduce > completion of the entire i3c/i2c transaction. Did you experience faulty conditions or was it reported thanks to static analysis? Reviewed-by: Miquel Raynal >=20 > Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") > Cc: stable@vger.kernel.org > Signed-off-by: Frank Li > --- Thanks, Miqu=C3=A8l