Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Tue, 17 Oct 2023 10:37:57 -0400
From:   Frank Li <Frank.li@nxp.com>
To:     Miquel Raynal <miquel.raynal@bootlin.com>
Cc:     conor.culhane@silvaco.com, alexandre.belloni@bootlin.com,
        joe@perches.com, linux-i3c@lists.infradead.org,
        linux-kernel@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH 1/6] i3c: master: svc: fix race condition in ibi work
 thread
Message-ID: <ZS6cRULPrwWjCL02@lizhi-Precision-Tower-5810>
References: <20231016153232.2851095-1-Frank.Li@nxp.com>
 <20231016153232.2851095-2-Frank.Li@nxp.com>
 <20231017161658.2de6d9f3@xps-13>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231017161658.2de6d9f3@xps-13>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?z1A51H2M/8I9l8aHTbVbW3ESf9+CmHeeeNVIUCF/DUq7AGtoCkMEk6eRef?=
 =?iso-8859-1?Q?ZIR1TRbasbKGiUCKr3HbrsKfZ1KQtPag9nhBYMKa+xs0DHSn1xwbfDNH+W?=
 =?iso-8859-1?Q?tXVmJvAGhZNeThbOnzraLrw028GceMpW9QgKa3l/ICpxuMXE8tlLPsiAML?=
 =?iso-8859-1?Q?94C0Q7L8bGDO2F40/YbrJqSmpOWQqTC9eODYiCJ/RSsf7cD8lenlvVyhNZ?=
 =?iso-8859-1?Q?ExAdBXyKSt+QU9sikF2SIs9ei+FE+w4tuMw8rCluoamBrIRIiRdGWBftLA?=
 =?iso-8859-1?Q?js96BGTyU/0qm/BFtQmkuS4zLMsRGM4qpU+d1YCdVyNaIXbL9VGsJxJmMU?=
 =?iso-8859-1?Q?I8nElJa198i/f8Y3E9+GVUbGs+gFyocN88ZVqz3exTQjNVs/Kf1WF/6/2O?=
 =?iso-8859-1?Q?5CyHaEnCUhC6Sn/3qSjJmN06WtAc228UWy/RQOsTXEDJFv6CqfUSw+ACT/?=
 =?iso-8859-1?Q?A/Hrogv26oqXbOH5f4kElUHOXcw5sIj0Z4aAUDnsLgdm8HyqJOMtgz4dyQ?=
 =?iso-8859-1?Q?Z8a7nph4dR9x7RLOeRuY+34gNEhpN4LCQxcpFzcJIP3HMz8Cyn/FSNynok?=
 =?iso-8859-1?Q?DXTQFr7nRYOv86gtoyWXuu+Xo7x+r2Ui8Qz9b+MRi6dZzz76ze2Fz/aHTl?=
 =?iso-8859-1?Q?vd7uTPn8EX75G8Pn5EgUVc3wTgb6YCZMK9ytDUoTgwhLV1IqdHmGs6395i?=
 =?iso-8859-1?Q?nlynBsoDarVzn3Q6aQxLh7e3BugldVbhYtXO6xrQ+lYTzYxdLhfp0pvwms?=
 =?iso-8859-1?Q?Gs7TAPR/L9JCmt4jXFJDcaWFX300zOiQVD6Yy7YEMuLKAAaVDXzcLp0lRK?=
 =?iso-8859-1?Q?3Z9G5L/CtFPawFdiKXv9Ic7UxzMp05+Qgxtr9c28ZpfMplBTV3URyjZNAK?=
 =?iso-8859-1?Q?27dtLtATcJxeOWU4WGnbMhN4mmPfI1HsZsj1qLBq8S1zAuvNO+9O36k6RJ?=
 =?iso-8859-1?Q?rI9hc1yJDqMpugekrioxkSjpNhDGoXjsexRub8YPKgBSA7dF0gv8BdUumU?=
 =?iso-8859-1?Q?f/0DFxjbmsItP3TiFpAk1xsbW5tyQio1Wc/J9knBfNLRr3Na0QvEIHlQqR?=
 =?iso-8859-1?Q?LsQiGt01YaTSEqXMjIqPD2yx/wWAM/aJTIso7v+MNuz7dO+q3+HnWQr9/x?=
 =?iso-8859-1?Q?Vz4bL8ZfHg2eO7K0jxhqxHIT2Y2wgb2cfQ+hWR85GSEvVq8GExNctqckxN?=
 =?iso-8859-1?Q?YsPKv0BCScUKluwPnFYTDavy23cCaHy0YG9y7mwn3K9atKSyfcpo6Y9BH1?=
 =?iso-8859-1?Q?OYHgqkn5fy5qFBek9/cHGwx+6iOeO7Y46xYVQ0ZN1caxQBTGneI3DTlCtw?=
 =?iso-8859-1?Q?wbKv8xdvRXHq5toB5SHWVaAtPUoLg27DJZTh+jGnBYMQIGcqDtala11PYz?=
 =?iso-8859-1?Q?RujHgovsX+xaVvCYY1iiylCObD5APH0+fhF/JVPJoTKAYoDa+0/F2jNuF7?=
 =?iso-8859-1?Q?ejg4zV+Fyn/fqv2DE2GK89dJ+bUU8/AiDCbola5WAFm1/Joag+kneS4PJv?=
 =?iso-8859-1?Q?U//1PazDUzM+n8bVPWZ/fadxa2kx2HPZe9eqQXzRPmOX9bUNwUshydWa18?=
 =?iso-8859-1?Q?oi0mNpO3xQd607BnC0dYasXeSVmHrgUpuQhZVaZDgmRiFdLNrHOMIEx0oq?=
 =?iso-8859-1?Q?sba2b/Xtx4qaI=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b18988c3-a3a4-4525-b1d6-08dbcf1eac66
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 14:38:05.3305
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uyN7YUgsDyA8mk/bDQxVaQ4J5eury57bhzAqoS/zo+uv7C2cijxdAU8LX0gDM2pQM2dUMF8IsIX4lvZBERSTiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9570
X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 17 Oct 2023 07:38:19 -0700 (PDT)

On Tue, Oct 17, 2023 at 04:16:58PM +0200, Miquel Raynal wrote:
> Hi Frank,
> 
> Frank.Li@nxp.com wrote on Mon, 16 Oct 2023 11:32:27 -0400:
> 
> > The ibi work thread operates asynchronously with other transfers, such as
> > svc_i3c_master_priv_xfers(). Introduces mutex protection to ensure the
> 
> Introduce
> 
> > completion of the entire i3c/i2c transaction.
> 
> Did you experience faulty conditions or was it reported thanks to
> static analysis?

Yes, I met. But it needs my slave part patches, which will be ready sent
out review soon.

Frank

> 
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> 
> > 
> > Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> 
> Thanks,
> Miqu?l