Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <5398da4c-5286-4e1b-924c-6df91f932427@intel.com>
Date:   Tue, 17 Oct 2023 23:00:01 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] x86/mce: Set PG_hwpoison page flag to avoid the
 capture kernel panic
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>, "Luck, Tony" <tony.luck@intel.com>
CC:     "x86@kernel.org" <x86@kernel.org>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>,
        "mingo@kernel.org" <mingo@kernel.org>,
        "naoya.horiguchi@nec.com" <naoya.horiguchi@nec.com>
References: <20231014051754.3759099-1-zhiquan1.li@intel.com>
 <SJ1PR11MB6083A23BB89F4EE0F44B2794FCD1A@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <233e17ac-0ae5-4392-a5e4-ab811a155805@intel.com>
 <20231016091143.GCZSz+T1xFf5tCFi2w@fat_crate.local>
 <759ccb97-cf5a-4787-b699-27551d5d2865@intel.com>
 <SJ1PR11MB60834039F485FEBC8031398AFCD6A@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <20231017111817.GAZS5teT4rFkXVD2KA@fat_crate.local>
From:   Zhiquan Li <zhiquan1.li@intel.com>
In-Reply-To: <20231017111817.GAZS5teT4rFkXVD2KA@fat_crate.local>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U2c2ZG44U1JNSWYyZkxPUW5TWXVwVkJMWm9BMWd5TmwxM3Y5c3R5b0pRVUdP?=
 =?utf-8?B?a3JKMTNrY2Nma2kxZk1WWXRWazVuQkNQQ0M0UDJnSUo5M3AwclhWcFJwRkcx?=
 =?utf-8?B?R1p0UjBtTlA5cHRUOEV2bTluUmNKYzRmZkhFdFRzaXY2a0kzWGpuN2liQmt0?=
 =?utf-8?B?OWc2eDBMRUhqUjFiL01qS0FOaUd6Mk01NG1RM01BcWdWTGw1OWlYVUllN3l0?=
 =?utf-8?B?SE11eXJwYSs5WGhBRWNpOUh2V0thVXdpUzhmditYbnI0c1hER1RmZEx6aDRo?=
 =?utf-8?B?dGdTYXlxak9mcjBFQUdZbmtHSHFTd3hJK0ZrdTRvdnFoZ0xsTlFlSjZ0YmVV?=
 =?utf-8?B?UkVweWRDeHRpdkZ5S2Q0SklNUUE2WjEvVXdZOFBaSy9YN2oyRVpkbWxFWjJI?=
 =?utf-8?B?YkJYUUtSNEZvS0ZTMkdTb3o3UGlicVBmK3AxRUJVK2ZwNTF6SXJiMGgzZzRE?=
 =?utf-8?B?d3IyWjN1ZDRlQkNPTFpFbXo2V0pUWG1Fby9NWUMwNTN3bWFVUlpkY2hxMlhV?=
 =?utf-8?B?LzJoTlpYY2lwZTM3dEJDemRDdVJSYUZvUUxScnlaekJqdDMxWXRqUGt3b1Nw?=
 =?utf-8?B?MWdPS0pEaktMZkxTV2E3bTR6bEVQZUU5WUs1eXlwc1JUcmNhU0gvNzlDSmhI?=
 =?utf-8?B?WC9SUTlhT09uMmtqcFI3UkpaRlRXMHFaRkNMbmNQUzN2SVh4RkcrU1BTRmpV?=
 =?utf-8?B?U256YUNUTVNuUnpoYjJxWHgrbjE3NHpKaUJOZlY5RVlYaHcvWHZHd3p5LzRY?=
 =?utf-8?B?Nzdja2JFQzdmWEJ1NTNwOGR0SUV6dmRsVkxrL1hkdWJycVBHbHZ4V01KL0ZD?=
 =?utf-8?B?UjFlQ0hha0VjWlFyZHRLVmdHRkVHWEZxbzZVNFhaaUJmYUsyak9mdmFqSWZs?=
 =?utf-8?B?QTZ2VHBLM01pVDZBcGwzbjdZSVgwUTB0MFE2Ulo4dGFEcFIxdHNvanlWTXJk?=
 =?utf-8?B?emNNQ2R3UGtXaFl4UWdPQ3RiSnh0S2lZUUV1N0o0SmxuNWw4TTBCRVZjbEJm?=
 =?utf-8?B?MEE5cGxXeTNESHJ3bWRLQjdkME1YUXpuYzlXVmtZREVDdk1GbURUeHBTRG8w?=
 =?utf-8?B?b0JlY3pScnVWNWIvMlRReXpqbkZuMzEzRkFYaTkrYjRrRlhKUjdtSmQyWWZm?=
 =?utf-8?B?WHpHano1cmZud1oxdS96TE52Z3pnUDVPNjlCYk1QbUFmYUo2ZXpITU8vYnpp?=
 =?utf-8?B?SzgyYmNZTStnZDBTVGtJWVUwbDlGK21PM0R4NEU0eVZPcHIzUmR0c1dMMDV4?=
 =?utf-8?B?L1NzOHJRcTAyVkpEakMxZUJEa1ZWVFV2aVZMRmlFOXJKa0toZU5WZkJHQWRE?=
 =?utf-8?B?N2lQQWYrenBRSWd0LzM2TzV0Z04wN0ZXVEU0M0lFTzc4UHVZNnJlSlZSTlZy?=
 =?utf-8?B?NXpzMndVWjFQT3M5UklSdW53L2JtZ0hINzk0VHMyVHpmN0FQOW82Y0xMNWIy?=
 =?utf-8?B?cy9zdUpDOXJubHRKbzZlV21YS2MrcGMyeW5VdXpWakR4dG9aL3Qrb0ZvR2xo?=
 =?utf-8?B?ODFrMFBVdkVOeVRUMGVOV0ZmM2xSeTNob1FDM3kvU2d0dnRyMFdDZklXZkg3?=
 =?utf-8?B?VHJHdFh5UEJSdzRuaEx2RU82S2JqZW5IeHBLSHNQLzJTaDlzWWFPakw4WHI4?=
 =?utf-8?B?UW5Zekt3R21zQnVoQWs0SXhEa0d2bStSSVZmTUdPeXRWWStOQ05QTjFCTE91?=
 =?utf-8?B?Y3ZKdmFUNHFKUEdRZVducUNIY3J2Z1A2djUxaFhnbE9PWmVORzZvTDVQT2Rq?=
 =?utf-8?B?KzBZcnYrellmaW5TbHNtektDcU8wK0tFUkhzRmJsVFRYamZFU29ucWYrVkFB?=
 =?utf-8?B?empXdG5lMXFCcUZ5Y1B5YWpxeEpCTW84YVBUWC9nUEU3RHdCck1NR1BKcHVI?=
 =?utf-8?B?NnpwU2kzZkw0WFNaWjQzRWUxbnlLU3pLOG1pWXU4L0Y3K2o0OUpEVTdGRDJv?=
 =?utf-8?B?ZmxiQWpVN2IvZU94Y2NubWppTnVGNWY4UEZTenFqU3hCaldhbFN1S0dXUlpk?=
 =?utf-8?B?T0IwalNqQ2k5c0NpSHV6OExibUpBYTN5QXREcjA1dVc2UlJnZFVKclQwVkdR?=
 =?utf-8?B?L0RZdkhTRXJYQXNiaVRXMCtGMFAxQWszVVNndnUzL2JNNW81LzNiVEp0Yjgr?=
 =?utf-8?Q?oZSHEmJHhuEh1zc25RhLl0qmb?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e247e908-f88e-4b13-6d05-08dbcf1f1d5e
X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3728.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 14:41:14.8247
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0tEu+Youy+bvklPDBY6BHLQ+Tc1J1yL0n114sJUAvjkBQX/tT9dZLWhmqNADxUFTBuGtCLVb7YPMOKRNClP98A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7836
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 17 Oct 2023 07:41:35 -0700 (PDT)

On 2023/10/17 19:18, Borislav Petkov wrote:
> ... for the simple reason that the kernel cannot allow itself to do any
> unnecessary work but panic immediately so that it can stop the
> propagation of bad data.
> 
> Now, it's a whole different story whether that's the right thing to do
> and whether the data has already propagated so that the panic is moot.
> 
> The whole point I'm trying to make is that the machine panics because
> the error severity dictates it to do so. And there's no opportunity to
> queue recovery work because it simply cannot in that case. So the commit
> message should simply state that we're marking the page as poison for
> the kexec'ed kernel's sake and not because of anything else.
> 

Wonderful!  Thanks for your detail explanation, Boris!

I think I got the point why you emphasized "can't make the kernel
survive" before.  In such scenario the consideration for recovery
doesn’t make sense at all, even thought there is opportunity it
shouldn’t do that, the only choice is panic ASAP.


>> If kexec is enabled, check for memory errors and mark the
>> page as poisoned so that the kexec'd kernel can avoid accessing
>> the page.
> Yap, yours makes sense.

Tony, your commit message made me realize how verbose my commit message
is. May I simplify the whole commit message as following for next version?

---start---
Memory errors don't happen very often, especially the severity is fatal.
 However, in large-scale scenarios, such as data centers, it might still
happen.  When there is a fatal machine check Linux calls mce_panic()
without checking to see if bad data at some memory address
was reported in the machine check banks.

If kexec is enabled, check for memory errors and mark the page as
poisoned so that the kexec'ed kernel can avoid accessing the page.
---end---

It already covers the scenario, root cause and solution, and focuses on
kernel.  No need to talk something else.

Thanks to both of you for great insights.

Best Regards,
Zhiquan