Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Tue, 17 Oct 2023 10:45:14 -0400
From:   Frank Li <Frank.li@nxp.com>
To:     Miquel Raynal <miquel.raynal@bootlin.com>
Cc:     conor.culhane@silvaco.com, alexandre.belloni@bootlin.com,
        joe@perches.com, linux-i3c@lists.infradead.org,
        linux-kernel@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH 6/6] i3c: master: svc: fix random hot join failure since
 timeout error
Message-ID: <ZS6d+mANtuhoAcuX@lizhi-Precision-Tower-5810>
References: <20231016153232.2851095-1-Frank.Li@nxp.com>
 <20231016153232.2851095-7-Frank.Li@nxp.com>
 <20231017163335.16770af2@xps-13>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231017163335.16770af2@xps-13>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?THRza0NnbU9LSUVFMDJLdSt2R29KRWRVOTlnTk80ODNpTEFsNXRNeXovRVVQ?=
 =?utf-8?B?RmRBWkxSUndxTms2UjUrUHdEWTF3QnNUa3hWaVJkOFdEQnFaeVZDWnEwblUy?=
 =?utf-8?B?a0JLQjBsK3F4OEN3UlZ5SlBhSml5VjNsWDQxSDhDVk0vK3RUOTlJc1JWL1BB?=
 =?utf-8?B?Z0dWM0NLZjFhSWRSajFzbmJVTkdQeGlUWmtGV0daU1VYQWdTVHNadi9VUzll?=
 =?utf-8?B?U2VwbVlYZ3oyQU8xbzBTbEs2ZmltdWdFOXY5MUE5aGlYUTkwNjdFQmJ1cTJx?=
 =?utf-8?B?WCtzSlRlQXgybmpxR2pMN2hLeXY0RkR4ZjhEeDRqMEdIMWUvVVpyU0x5ZDNJ?=
 =?utf-8?B?b0VzU3NNLzlBdUpBTThqN0ZRNTNjODk2N1JUaXAvS2pOVnJPREN5LzVnYjhV?=
 =?utf-8?B?RUlpUS8vK25GWTZVT2hLK2ZjTVJ4MWpNM29PUFNaSTdKQitCM2MwdXRLa05N?=
 =?utf-8?B?RE8zNGhmdXdVRzJYRURhZ1Rtb1hrTWpGbTM4Z013THlGaUR6R0lIS09qRHM1?=
 =?utf-8?B?Y3RnWThnSnpSYWo5WXNSWWJuV0dMQTZSN296V0dPUzA1RGlNUzJyeXV3bkZ5?=
 =?utf-8?B?bFVJL25IUVpRcElCWlFDTGRSMUI2UTd0ODM0WWxHdDNiRkY4RTBpT09pdkwy?=
 =?utf-8?B?RFhjdTJxVXZJblFlaFgrbHJhdXBndXpwWERKSDVBZjZ4cXI1NzRrUlV3VUtI?=
 =?utf-8?B?L2JROFhPZzEweGtaZE1JT0NaVUQxL0pkWmo2UDJ5SWJScE5WVm9PL0ZwbVR5?=
 =?utf-8?B?VlVMZXhCUk8zd2duUTlobkk4bzNpOEs1MzF3ZC83VjVsOXFEZDlrdW1jV0tt?=
 =?utf-8?B?bitZK1E3YmlYcjA5azkxVytpTUFoV0xDK3RCNGFXQVNvL2lHenE5UHZEemFp?=
 =?utf-8?B?cWxLUmdpRWNaSjVFTGJJdnRVL282dW4vRks2UlVPcFg2QU03RUt6WTdSK0VV?=
 =?utf-8?B?QzJRa3M2N3BKUlU0M2pGa3ByZVc1QUhDUmtVYjlzWkxuT2dpekU2Q0d3eUxJ?=
 =?utf-8?B?eS9tWVlsMnByN2pZZVJCTGcxRFBOcW5TNkFwdmVDdWxyakdiYVBaK1JmVHUw?=
 =?utf-8?B?VXZmclp5QWQrTnA0MkQwbVIxOGdDWnBxbnh2U3E4NzQ3ZXN2RDBCZjVNL0or?=
 =?utf-8?B?T3MzSmN1Ukp3R3JIZGtnOUdnVG81WHNEbmhSaWx6M0pxME9iaUlnUG16YXpk?=
 =?utf-8?B?YUNxZXBuRHZGY2NYNXUrNEU1MTU2YkowcVVCK0YvWjlMcTF1TmVVY3AxdHpV?=
 =?utf-8?B?ZmhUamZyeWJqdTR4UVh2ZHZWMUlwc3JWWTZUdHA5NlNFSUxlMSttaW85L09B?=
 =?utf-8?B?QVEwUzRlVWFaOFlybGZZR3VpL2RVREIwZ0taTlVVcUxmTjc0bnh0c2Q5UnJQ?=
 =?utf-8?B?Umh3LzVPQ0p2UnEvN2Nhblh5dVIvQ2xaSUQ4TmJhMUl2bWhoeVR1OWJDaFpk?=
 =?utf-8?B?RzNaVDh5bHAvZVFScUgweDZxZTRlNG1YcVRTaVRPUFBycGxPeXFtRjdCY2lv?=
 =?utf-8?B?TTk3UHQ2dmN3L29hQ1I0cE4wc1llZ1lMWElsQzNKWTg0UVV2dWE4ZW45VFZC?=
 =?utf-8?B?LzBHVDY2d3lhdGh5MVVZK01xLzhJSkozVmdUNnFjdFVUS1o1aGRnakZNL3o3?=
 =?utf-8?B?MjZpazA2VXFzK2hMYnlUWVBwak1qVjlGQXg2S1VLMEpoMzJUMXBHWlpwS1VC?=
 =?utf-8?B?OEUyYmxNM2I1NGtNNkVFWno0aThhTk8zd1JBdUwzSzdiWW42VHphcHJrdUtU?=
 =?utf-8?B?UzBPSW9TMTAyYkhyNUdvV3dxanVhYWdvbE02TmkxMm9wdFhZdm1kem01Y2Qy?=
 =?utf-8?B?MDNtaXFmSGtTUU15SG5lZDRTQmVDbEVxVm9qOC9iTkY1SEJBK2dySmxteTJU?=
 =?utf-8?B?YUE3eGxsMTRzOVpRL2MzdTlzQWFIYk9vallwbUMwc1UrVzNyV0RzNlllWlk3?=
 =?utf-8?B?ZjQ3UVBySlBTTVVCeC9lbnp5WTV0YlA4UWxIM01pd2wzZjZGZ1dDL1MzczNL?=
 =?utf-8?B?Mi83OWxocTVOdU8rOWRWOEVHYUZTUmYyMStjQ1dURFFWSFZKQUZoeFk4bDJD?=
 =?utf-8?B?RGRiNWxJM0NlcTEzRzVwbTBPUlllQWFzMEFlM0pzRHYyLzVVblZmay80UmpP?=
 =?utf-8?Q?QXihsfdRN+8i0txdVwqYbv5PQ?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 149b80cd-e53f-4c3d-5170-08dbcf1faf77
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 14:45:19.8730
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HvdDKIBJCwI4tGQmKCjsBDQUtD7qOma2BQn/8JjvszwwKF/cNCiHu89pymJlDkURS4yhTkr5mf0Zbwik32KJ4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9570
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 17 Oct 2023 07:45:33 -0700 (PDT)

On Tue, Oct 17, 2023 at 04:33:35PM +0200, Miquel Raynal wrote:
> Hi Frank,
> 
> Frank.Li@nxp.com wrote on Mon, 16 Oct 2023 11:32:32 -0400:
> 
> > master side report:
> >   silvaco-i3c-master 44330000.i3c-master: Error condition: MSTATUS 0x020090c7, MERRWARN 0x00100000
> > 
> > BIT 20: TIMEOUT error
> >   The module has stalled too long in a frame. This happens when:
> >   - The TX FIFO or RX FIFO is not handled and the bus is stuck in the
> > middle of a message,
> >   - No STOP was issued and between messages,
> >   - IBI manual is used and no decision was made.
> >   The maximum stall period is 10 KHz or 100 μs.
> > 
> > This is a just warning. System irq thread schedule latency is possible
> 
> 							can be bigger
> > bigger than 100us. Just omit this waring.
> 
> I'm not sure this is the correct approach. It's a real issue but there
> is not much we can do about it. Perhaps dev_err is too high, but I
> would not entirely drop this message. Maybe a comment and turning the
> message into a dbg printk would be more appropriate?

The key is not message. It return true, means IBI/HJ thread will not run.

Frank

> 
> > Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  drivers/i3c/master/svc-i3c-master.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> > index 5bca369d6912..18bc277edc8a 100644
> > --- a/drivers/i3c/master/svc-i3c-master.c
> > +++ b/drivers/i3c/master/svc-i3c-master.c
> > @@ -93,6 +93,7 @@
> >  #define SVC_I3C_MINTMASKED   0x098
> >  #define SVC_I3C_MERRWARN     0x09C
> >  #define   SVC_I3C_MERRWARN_NACK BIT(2)
> > +#define   SVC_I3C_MERRWARN_TIMEOUT BIT(20)
> >  #define SVC_I3C_MDMACTRL     0x0A0
> >  #define SVC_I3C_MDATACTRL    0x0AC
> >  #define   SVC_I3C_MDATACTRL_FLUSHTB BIT(0)
> > @@ -225,6 +226,11 @@ static bool svc_i3c_master_error(struct svc_i3c_master *master)
> >  	if (SVC_I3C_MSTATUS_ERRWARN(mstatus)) {
> >  		merrwarn = readl(master->regs + SVC_I3C_MERRWARN);
> >  		writel(merrwarn, master->regs + SVC_I3C_MERRWARN);
> > +
> > +		/* ignore timeout error */
> > +		if (merrwarn & SVC_I3C_MERRWARN_TIMEOUT)
> > +			return false;
> > +
> >  		dev_err(master->dev,
> >  			"Error condition: MSTATUS 0x%08x, MERRWARN 0x%08x\n",
> >  			mstatus, merrwarn);
> 
> 
> Thanks,
> Miquèl