Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3212237rdg; Tue, 17 Oct 2023 07:52:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHvasQofGR3kGLrocB9CJmISetdX4sEH/3BgIfZENqCVMh/+7Iw1qT5YtVL7S8A53v5/+Bc X-Received: by 2002:a17:902:f385:b0:1ca:731a:23e4 with SMTP id f5-20020a170902f38500b001ca731a23e4mr2175777ple.40.1697554339018; Tue, 17 Oct 2023 07:52:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697554339; cv=none; d=google.com; s=arc-20160816; b=PymjQWXHp2hczHV3oWc833epQwpJj2ypo6MiakrUXdaSHkDl7v8SY38+nWskebkRZV by9ORnu5OWf8LexSLl2IYkOwhj5rlCR+WBeG9fCBNlCcoqBiPXLliB5XCLjungmoHnsU nIkF8UBzQWF9F0oZlj2EXMs6Dq5FBuK6MkOGkzlDTEdMwwEclLWWboKSzfJvks+sVI+q zaL2HHmteFoOXcQNKweuXRhu+HbJ8rV3QJbE2uW0rHoz5+ODuqtfKtdTNmMiNWfHOUDI 3IAoXAZblixi7gZVQSXAHRLHKE6ZOEBYoqxpIuV5NaMytLPwIzv1FwizmNjoTUrSgx1B SsiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VM4NzMJMGv79npf1U7MuzJpl4mPtUAdgVx8a3O8ahTM=; fh=O6aRB12iLfQPcoaBoN6ND3UiYcgSMHP3FYKR6EKS/0Q=; b=B0YNAyh1jQKGSn4Sodp/iN/WveRabzpKSJoFIujM7LnUL49NF36ieUh0wsXSgNzPVR qVzzUAP1ct5WForVksBgrz57xpJOnB6TFXmOWuTFgUMh6UZhJgyIX6u3k+7PNzneeF52 NfUw/pIZRzNVoqRsytVqUu/a41iic2GF3xJc4ErLc5hfGKXY7eHRSEBov+/1Z52CbGyb /YHtzOqwQ2/bIQytwMOtyrjTZcvQVEijomYLDULExrH11hUyDU5+j3xWT1/n2ANfJFKp Sb2VOq1t0bRk3rEUQ7i2yIaSHfb/7JAnPVvziH8DPh3A6DUQgPjdei6cCadHUOdq2C6q S7wQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=HyKsJkFx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id kg14-20020a170903060e00b001b89551a392si1836607plb.113.2023.10.17.07.52.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 07:52:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=HyKsJkFx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 5F573809148E; Tue, 17 Oct 2023 07:51:26 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344517AbjJQOuh (ORCPT + 99 others); Tue, 17 Oct 2023 10:50:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344197AbjJQOsW (ORCPT ); Tue, 17 Oct 2023 10:48:22 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D441F1; Tue, 17 Oct 2023 07:48:13 -0700 (PDT) Received: from benjamin-XPS-13-9310.. (unknown [IPv6:2a01:e0a:120:3210:7205:da49:a7e8:59f8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id 835C66607328; Tue, 17 Oct 2023 15:48:11 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1697554091; bh=NE9Dr0xaEnB6dw9lflcnBD1PZMhluEk9SDENx9Slyak=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HyKsJkFxjCmLln0LihwZywYWeeBdL4A6629oPs0IftjCQd7yypAtELaXq4CFFlab9 jiHQZdbsA0f7sPdulSyoe2JWuGabAel8/0apYBdC9T/7a8PpqhYxajLJKc5J4aNNlV +2HVFOJT2IXIblTGcdNVSIbbAL6VLqa1nu1C8+teSCNmWOoJjc+YwFltca4YlPqJ9p vUKxJH1mnf7+/OEk694MCBFDDH1MUxpGDRVLnAhM8CXc9NpAs27wYMSpHDBUOh+Ph0 9BucDSPCJKcuQcjvJ9uMgdRqObV49HaGqNZCT4yNXPEAXi3SjGl084xhgWU97AvygT miiZ9wgA4ER3g== From: Benjamin Gaignard To: mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, ming.qian@nxp.com, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, hverkuil-cisco@xs4all.nl, nicolas.dufresne@collabora.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard , Hans de Goede , Sakari Ailus Subject: [PATCH v12 16/56] media: atomisp: Use vb2_get_buffer() instead of directly access to buffers array Date: Tue, 17 Oct 2023 16:47:16 +0200 Message-Id: <20231017144756.34719-17-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231017144756.34719-1-benjamin.gaignard@collabora.com> References: <20231017144756.34719-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 17 Oct 2023 07:51:26 -0700 (PDT) Use vb2_get_buffer() instead of direct access to the vb2_queue bufs array. This allows us to change the type of the bufs in the future. No need to check the result of vb2_get_buffer, vb2_ioctl_dqbuf() already checked that it is valid. Signed-off-by: Benjamin Gaignard Reviewed-by: Hans de Goede CC: Mauro Carvalho Chehab CC: Sakari Ailus --- drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c index a8e4779d007f..a8a964b2f1a8 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c +++ b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c @@ -1059,7 +1059,7 @@ static int atomisp_dqbuf_wrapper(struct file *file, void *fh, struct v4l2_buffer if (ret) return ret; - vb = pipe->vb_queue.bufs[buf->index]; + vb = vb2_get_buffer(&pipe->vb_queue, buf->index); frame = vb_to_frame(vb); buf->reserved = asd->frame_status[buf->index]; -- 2.39.2