Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753908AbXKRRUx (ORCPT ); Sun, 18 Nov 2007 12:20:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751291AbXKRRUq (ORCPT ); Sun, 18 Nov 2007 12:20:46 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:35908 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751042AbXKRRUp (ORCPT ); Sun, 18 Nov 2007 12:20:45 -0500 Date: Sun, 18 Nov 2007 09:18:28 -0800 From: Arjan van de Ven To: Andrew Morton Cc: Ingo Molnar , linux-kernel@vger.kernel.org, tglx@tglx.de Subject: Re: [patch] Printk kernel version in WARN_ON Message-ID: <20071118091828.4dc0dbbd@laptopd505.fenrus.org> In-Reply-To: <20071117165719.c8d7bb48.akpm@linux-foundation.org> References: <20071117101552.2a7f34cb@laptopd505.fenrus.org> <20071117102720.251107d7.akpm@linux-foundation.org> <20071117103947.5b2052f8@laptopd505.fenrus.org> <20071117104652.8240af62.akpm@linux-foundation.org> <20071117113501.5e3e0d43@laptopd505.fenrus.org> <20071118004218.GA26865@elte.hu> <20071117165719.c8d7bb48.akpm@linux-foundation.org> Organization: Intel X-Mailer: Claws Mail 3.0.2 (GTK+ 2.12.1; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1023 Lines: 29 On Sat, 17 Nov 2007 16:57:19 -0800 Andrew Morton wrote: > > Should be done for all architectures, methinks. > > If so, an appropriate way to do that would be to do > s/dump_stack/arch_dump_stack/ and do a single all-arch implementation > of dump_stack(). (Where we might add new goodies in the future). > > Problem is that this will add a new an pointless entry to all the > stack dumps, unless the arch_dump_stack() implementation is smart > enough to skip the innermost frame. it also adds a stackframe to the "oh my god I'm low on stack space lets get a dump out" codepath ;( > -- If you want to reach me at my work email, use arjan@linux.intel.com For development, discussion and tips for power savings, visit http://www.lesswatts.org - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/