Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <44477b0b-af38-569e-95d9-e78c118c9d18@amd.com>
Date:   Tue, 17 Oct 2023 22:36:06 +0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH] iommu/amd: Do not flush IRTE when only updating isRun and
 destination fields
Content-Language: en-US
To:     Maxim Levitsky <mlevitsk@redhat.com>, linux-kernel@vger.kernel.org,
        iommu@lists.linux.dev
Cc:     joro@8bytes.org, seanjc@google.com, vasant.hegde@amd.com,
        jon.grimm@amd.com, santosh.shukla@amd.com,
        joao.m.martins@oracle.com, alejandro.j.jimenez@oracle.com,
        boris.ostrovsky@oracle.com
References: <20231017144236.8287-1-suravee.suthikulpanit@amd.com>
 <97d106d28e4c3468912a478dba79ab2221109cbd.camel@redhat.com>
From:   "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>
In-Reply-To: <97d106d28e4c3468912a478dba79ab2221109cbd.camel@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amVhb1RKWklvU2pmRW5SdGxSSjhYNkpVRzZIdytNQTlJcVlpSUFTYnNOeW5X?=
 =?utf-8?B?RDBPeU92MUFhQlYrL0VUUy9LbExRU2tQYkdGd2k2QVEvMWxUdWd4SXVUVmhN?=
 =?utf-8?B?dlljdkF0dVZNcm5WVFFiRExQYnlqMXNUVE8zWWxZSVYzME5TdlFDY1hTV2pu?=
 =?utf-8?B?bWYzSW1mV0VrT25zVWluYkZ4bGpBQjIzcWJYalg1VXROdndZMkl5U1NHb1ZE?=
 =?utf-8?B?Vk9PUlIzcXlzMTlPWjlGZzEzRzR3c0xYaUF4Q2ZqM2cxcElmRTNEdng2dFZ3?=
 =?utf-8?B?UnBUN3EycGZIeG1FUXljODA2b3BadVFnNFZLeTFPeFloeTBGdHR1bDViR0R0?=
 =?utf-8?B?aHhSRVByeit2UUttaUJ4bkJ2SmtiOURlNkE2NDlyRnVGaldwUWZnOHVzZlpa?=
 =?utf-8?B?azM0QlBEYU9WVm11L3pDektJd05mRTNwLzhZYlNESzEyaVExNUFrZkFvSWNv?=
 =?utf-8?B?UWVtNzcvKzZjM00vNVlvb2lmbVhlb2FFN3JpSFZXTlBGMXJuNVF3MFB4emQ0?=
 =?utf-8?B?N2lVWU9iRjhZaVlxQmc3WVhnZE5scndLVzNmQTJyUzVYYkRGSmh0Z3J4UG85?=
 =?utf-8?B?ejl0TlRDS2JtQXE0SFJCZEtkOEdKM2oxeXZ5UllWWGI5d1VuT0dPTDNDd3Nt?=
 =?utf-8?B?QVVSd29OYVRnZXdwN05qTDVTd2htTDgvY0NucTFrdU5qZVVMMzYwclR0dVNx?=
 =?utf-8?B?YUpXNVJkM09GcmhBck9jMEZpZ05HdUZrNG1DYWlKU09jRG1kZ0U4VER4TjRS?=
 =?utf-8?B?bWQvUzlUS3Z6emUybFY1dWZtbU1xL0xIazhuTnpFVEM2S1VJRjBIQ3MyTTI2?=
 =?utf-8?B?WllvRnVhVTRLUWluU2JNUjVTOHFnelE5dHlmeVV6bXM2VkYwL0JFT2Q2eVdn?=
 =?utf-8?B?V3pOSXViU1E2SnZydmxHRnpqeVpsSlZkWmszblZhcDlPYUJoM2ZxbkYyVUNx?=
 =?utf-8?B?dUp5Kzgxb2pPR2NESFRwbW82bWgxczlpb3B4ZTdmZWJZWms2MXFBSjRHN2wz?=
 =?utf-8?B?TWJzZCtOVkc2TzdLVnJzYkc4YU9LQjRCamhRRnIzV21HdGkzTEhGMFNsN3I2?=
 =?utf-8?B?cW9IV1praGpDTmcra2I0UUJrRUtoZDhDK01LTHBvUDFoZUh4UGkwNzhtSGlI?=
 =?utf-8?B?WkpqbC9GYmo5eEFwa3h0ekFQdWQvUjJWTS9oS0RzeU5kb1cxUjVUZ1dGODZi?=
 =?utf-8?B?SFcyVklSTjJGUDk4cnRTbFFqRGJUNkxSRDNQZnRYalNIclU4NmY5RkpEUmcv?=
 =?utf-8?B?cXJTOWVNS1I5ZWxTSTBYay9IYlZDdUNRV01VbTFDa0Ivci9GcC80dlZnWkc4?=
 =?utf-8?B?K2RrVHNLYWJPVncxekpveHVZRC9rZUVoa3hGclNnUFlLYnhNTW9Pd20zUjdY?=
 =?utf-8?B?UFQ2Y2o2Sm1iM1YvUTNZeThtTUxoNkgyaTE3UHlaRDRnOXhrWVBZdmQwalRH?=
 =?utf-8?B?TXhtcXdyQ08xTHAvZ0pXbnFJbVB4TzRTOGJLN2ZxSVh5aktjZVZBeS9DOUtu?=
 =?utf-8?B?aVpGSERTRFlKaFBiVTFuYWJrN1J3Vld4VTE1cmlnd1I2RE5nei91SkpEWEY3?=
 =?utf-8?B?cEJ4c2ovZFZZRVlILzd2dmovK004djJTNk14em1lWFZqaU10bGVrbG5yRTZ0?=
 =?utf-8?B?eVkvaEpFbEJMcEY5ZEJRdGxQWU9uNjNIVExwSjJ5am05czl4SG9wbVBoOE1Q?=
 =?utf-8?B?L2tybStBb1NDaUtYbW1NY0hiSVkxQTQreW84YnQ2M1QzNFBvaUdmT0VISS9X?=
 =?utf-8?B?WGtXWFlyOFJ1NWk2cUg0b3NGS0VXZ1paamlMMVhnTkxjNWp4UHZORVNscGFS?=
 =?utf-8?B?NVNJeThHQ2U3cy9zREZVRlFnbXhPSDc3dHVlM2daTzF3aC9WYVMyaXFJeUNX?=
 =?utf-8?B?Qkh5bnAvUEhoRjJYRnZwajd5cEtXOHlPY2F6SE5WMFFrWWNadEJRZHFSQzFo?=
 =?utf-8?B?Qzc5dlJrV245M0gwZWtCRHNjczh1YVVYUFVDZXFmMTJXS3BWM2JFU2RJMEZp?=
 =?utf-8?B?cGY4ZG1WSjNyVjNzZ3ozQkZWU2RDMWdvUDJJMjJxa0NUakl2V1p5T2FSM2dF?=
 =?utf-8?B?M3M2eElnT1V3dnI5a1B4OHhSMHloYjJZQmk3MElrVEZvbFFYUDcyVFNMUVZ4?=
 =?utf-8?Q?Z/r+CDOgRx+Lfol050aB8oxvp?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d348a00-5dad-4946-09a4-08dbcf26ce03
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5445.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 15:36:17.8655
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IVyfSJk8dluW1vIM5xpDsv08AQDOLKnSVBufddsuTl4sccpaLeT7Gi/34nFT5a/RVDXLIokRMJ4909ks4b6V7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR12MB8490
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 17 Oct 2023 08:36:30 -0700 (PDT)


On 10/17/2023 9:51 PM, Maxim Levitsky wrote:
> У вт, 2023-10-17 у 09:42 -0500, Suravee Suthikulpanit пише:
>> According to the recent update in the AMD IOMMU spec [1], the IsRun and
>> Destination fields of the Interrupt Remapping Table Entry (IRTE) are not
>> cached by the IOMMU hardware.
> Is that true for all AMD hardware that supports AVIC? E.g Zen1/Zen2 hardware?

This is true for all AVIC/x2AVIC-capable IOMMU hardware in the past.

> Is there a chance that this will cause a similar errata to the is_running
> errata that Zen2 cpus have?

Please let me check on this and get back.

>> Therefore, do not issue the INVALIDATE_INTERRUPT_TABLE command when
>> updating IRTE[IsRun] and IRTE[Destination] when IRTE[GuestMode]=1, which
>> should help improve IOMMU AVIC/x2AVIC performance.
>>
>> References:
>> [1] AMD IOMMU Spec Revision (Rev 3.08-PUB)
>> (Link:https://www.amd.com/content/dam/amd/en/documents/processor-tech-docs/specifications/48882_IOMMU.pdf)
> Looks like the link is broken.

The link above is the default location for AMD IOMMU spec, (which is 
currently being fixed). In the mean time, here is the temporary link to 
the latest document.

(https://www.amd.com/content/dam/amd/en/documents/processor-tech-docs/specifications/48882_3_07_PUB.pdf)

Thanks,
Suravee