Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <39261212-54e0-4990-a72e-ec66457cbdbd@oracle.com>
Date:   Tue, 17 Oct 2023 10:49:53 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH -next] scsi: target: core: Fix one kernel-doc comment
To:     Yang Li <yang.lee@linux.alibaba.com>, martin.petersen@oracle.com
Cc:     linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
References: <20231017030913.89973-1-yang.lee@linux.alibaba.com>
Content-Language: en-US
From:   Mike Christie <michael.christie@oracle.com>
In-Reply-To: <20231017030913.89973-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WW81elAwcnl4VS9WU2l0dGJlcFUrZ2lrK3BBeEpUQWxEYjlhOWEzanV2Umtl?=
 =?utf-8?B?QlgxYWNVTEs4RW1XNUEyaE54WFNUWEI0V1lDdFEwVDdZL2tFTWdrRE1Vc2xD?=
 =?utf-8?B?Vm80aHVJTTNxM3J3WjNhdWNlS05lQ3pSb2tXem9OUjZxb3NKNVV1TmgyNndN?=
 =?utf-8?B?SkdzZDBOQmpySjUrZjFZT3oydndJemNaUFlKbWZLcjM2V0JiQ2xCVnFCcE5G?=
 =?utf-8?B?QThJZXFmQ2NnSUcvNXA4bXM4ckY3Tk1ZaUVQZ2wyZUp1azhxV3daZmx5NSsz?=
 =?utf-8?B?M3hxV1BYa3BWUFJoRFV4bWlrUEhhb3RyTjlPZEUrdjRrUGs2WnFiSFQ1b3JZ?=
 =?utf-8?B?OVZ1Y2M0blQrdEhpMEhFbHpBaHdiR1RsaG5GVzJDR0EvWE9sRE8xRjJqTXBn?=
 =?utf-8?B?K09DKzN5SDlSdWhzQVk0RURCQ0FPem9ISTIxdjlQUTNoREd1TitybllYWkgy?=
 =?utf-8?B?ZkFsSVNRVE8veXM0RysvOCtMakl0SUx5WVJTZ0FaNEVhVzIvck1ZK2JoV0U1?=
 =?utf-8?B?ZkV3TGpRYnpWc21PMlRnZXkrS3hIemlGM09ENEVPdEZsRXNqMXg2YUlkd3lH?=
 =?utf-8?B?M0ZGcUFIY1lGOGdXcDdnOTJsSXZXSUo1Z3Z0VnNaMmRXNnMxRnNNRTd4WnRz?=
 =?utf-8?B?NUVnRklDZHJCbDNIR3QzNVRtQ2pPQ3hSeWxDdHlYTFhzbi8xcWltVTZ0T29i?=
 =?utf-8?B?cjAwWXN2aFRNMzY1VW9MOGZGdURzU1dHVjd0Sys0S2tPNXBNSmZOeUVhcXZ5?=
 =?utf-8?B?bFh3TktlbW1QODE4dFdPQ3ZJck1rdmVzTFBsYjZvSUJ0ZGplSm9SczZGR2lt?=
 =?utf-8?B?Y2xTREJOMm9HSzh4d1VKVnZ3QWR5Zi9sQVdhbjZuc1YzODNUR3BQWFBEZzUv?=
 =?utf-8?B?cnJwNWY1bjQ3aVpRZVczdHA2UUYvZzhKVnIvdWtsQk1DTStkbnlQUlJKbVBM?=
 =?utf-8?B?ZVFGVkFrRHpPM2VaK2ZEd0pvU0xMMnREbmdJWmdBNGpKanlGc0ZkOUlRV1Ur?=
 =?utf-8?B?ZW1BUHlqeFcrRnl5QXBtMTQwSEtMbVRQU0pvTkF1blFOYTR6cngxd1hmdzZj?=
 =?utf-8?B?VThXYTlxU2dsemxmQUdJa0Joc2hBS0lBZDFmd0wvMDJjdm1WQU5xS2twenE4?=
 =?utf-8?B?blJkWWJ4Q2ttb3NYbHpOVnR2ZloweFVieU5JTlVtME1mUUhNdWpHUTlRbjMx?=
 =?utf-8?B?d0VJZEVTTkVYWkpTZWFMZlFId25vWWtNNyt2SWFHeWpyc1hqTTNoaVErVzlj?=
 =?utf-8?B?cGZXbTdra0xJVVgybHZ1UWNoYlRTNlJIUWxlYkVKRXg5RXVqY3RmUnNSWkNT?=
 =?utf-8?B?ZDZTejNKUGJacWduVmZvYlZBK0owTDJOYVI4cll2ZFlFUFdmM0x2SmsyS0o1?=
 =?utf-8?B?czlVajRZeFFyUnhwZlNsOXlEQ0Q2Wm9xUVFEVmlmYktSQlBzZ1JCdmVmaFcy?=
 =?utf-8?B?YW00NzdmY2pXT1BVRWMxZ2dJTmZOdXJXOW5VQ0ZvRG9RekdjQkxYUmxSRVlv?=
 =?utf-8?B?TDJYdFdEa3laNXhNc2kzRlQ5b25adDNtVEZaVHlXcXNHeExmOU9GYldjN2pp?=
 =?utf-8?B?TjF4M2xmblFlSGNTSmVUcEE0TStkMzcyeDFPUFRyamhZNHB0QlN5dzBZM24y?=
 =?utf-8?B?ZWQ1SU13aGxaWFdqeldjTndKSzgwNXY0VERGNU9VU1V6eEJaVCswVkhDRGVN?=
 =?utf-8?B?dklQVld4SktIYWRtRXNLRmIzTC80LzdtaGRBRWFqTEprS0tYZUN6eWo5UHBK?=
 =?utf-8?B?RkVCc0x1Z3pNTTZML3pwQXRycGNVTXNuZmhLYmtaaG9ldkJjQjI1QnBLTVIz?=
 =?utf-8?B?VVZxMnJuVEFKR1dPNTltYjVvamlQamM1YU9OR015MFc2MkdCSjNiT2VVczZ6?=
 =?utf-8?B?N3R4NUMvK2xWVDFhTm56V3ZvR1lZdWhiRHIzUDdYVXZPL3VLa0hiL1l0aFAy?=
 =?utf-8?B?SDA5Tjc0MFAzMnU3OHo0L2tnTHFoOXF3SmxBSnphd0R5L2xpWitXOFJUWFRI?=
 =?utf-8?B?NnFtUVFpczlQRGJkTHptMXpBVmxpMHVabmNsZHhROHA0WGZJcVF5YXN0dmZa?=
 =?utf-8?B?bjBCQTkxcUQzcmY0OS9yaUF6SWpHYUwvR2ZTbnlPQ1N0VU0wUGlkNWhvRHFh?=
 =?utf-8?B?RzhnWlNFeThCVWhVenBUZWU0UWJseVFMOERhcjVHc1g3YUNCditJZTZuTnRD?=
 =?utf-8?B?Ymc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: QSr5J1LAMhy4CUqa4c2K2U+HvmvmMwJFLFytS3yLdr/2QZPlZ18Qk7TZ1KXbzX4FlHx/ncO2KZF3PptW/EYC2UhZY9hWkSY4PXNtl/kbzQJv/C+/8qqSKWtpBPyfcBZ93Nq+hOPjciaDkvHqLY900V2BURUL1RJLtxR/0lbMrKfM+kKjh+CTKcRFSV1RJ5th6sOLRxudmUBvwr0+9djNOAOvc1zPuGh4Pwz8SIaxlfp/PCNiG+xg4H/qgoVR6mubFocH4DiellJBZN4ygQPRG12dxcnyah4zXCpPxaM5VhanvMyabvxZcHgf/jPKuQDbSmey9LZXM6ruTdwNgOLonT6Nv2S2HX65oHi+VNfeaMYfGCOQwy/7O7PoO5w82X+rUfAB257diw3n4cOnoiySxx09m1cJlgKl294FU9JUWFF6bT0qhvKB25h45juOnwLf7YkTyCIhptmBmAuT7FTmQBA+XF2OyZyQW9d0fA/damMQve9XV2HpH2Z/j3chMPk9vLyovCj6Ua8P2Uo/75OPk1rycMRbfsUQf+qQFFdAVZqves5GHk/csJo4KSBe0Le3H3UwBaZYELWiL9zXTdYqIdMkCF5LGq2nv/V69fWjD9bgEWv3wpcIMsAhFsyYPkGuNb3InxAwbR+t/BffYj61qi02RHnzV+uLctcWl4/DOrkZNbmCr7lf1RWxwvdBhQIFBLz6dTaUiEah5q8r1/P+s/6+07KSiUHKoiWQXEKkVQY0SI0t6Aha4qWtAunScLzXYxSrtRI6rQfeq7mQAJxbBWSP/SkssxT9gAFeasUbRgxq3qdlQEScJP15ziQ/QcUe
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d4f4e750-6ab7-47f2-a93f-08dbcf28b4fa
X-MS-Exchange-CrossTenant-AuthSource: CY8PR10MB7243.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 15:49:54.6373
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uNIdzCar3qJk8AOzkeL8N9uPpbOgtdH0BfUwN2QhNa1DbLwYqLy+ru6OqFZs4hZHjSuomd3yystr+UzFediwxis6GXQNZ+FZ6Pyij3p14JY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4376
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-17_03,2023-10-17_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 malwarescore=0
 adultscore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000
 definitions=main-2310170133
X-Proofpoint-GUID: ejlYa1gE5vMLQHLYupZoMSCp1OAbHle-
X-Proofpoint-ORIG-GUID: ejlYa1gE5vMLQHLYupZoMSCp1OAbHle-
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 17 Oct 2023 08:50:14 -0700 (PDT)

On 10/16/23 10:09 PM, Yang Li wrote:
> Fix one kernel-doc comment to silence the warnings:
> drivers/target/target_core_transport.c:1930: warning: Excess function parameter 'cmd' description in 'target_submit'
> drivers/target/target_core_transport.c:1930: warning: Function parameter or member 'se_cmd' not described in 'target_submit'
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6844
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/target/target_core_transport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> index c81def3c96df..670cfb7bd426 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c
> @@ -1921,7 +1921,7 @@ static void target_queue_submission(struct se_cmd *se_cmd)
>  
>  /**
>   * target_submit - perform final initialization and submit cmd to LIO core
> - * @cmd: command descriptor to submit
> + * @se_cmd: command descriptor to submit
>   *
>   * target_submit_prep or something similar must have been called on the cmd,
>   * and this must be called from process context.

Thanks.

Reviewed-by: Mike Christie <michael.christie@oracle.com>