Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3253437rdg; Tue, 17 Oct 2023 08:55:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGWhzln65Dgr6RzZUtmJEPF1ZsZWTn0jBHW/6chV5fUOcHt2Z3hALwcuYnxRSSiRW8OpF4l X-Received: by 2002:a05:6a21:18d:b0:159:e0b9:bd25 with SMTP id le13-20020a056a21018d00b00159e0b9bd25mr2814556pzb.57.1697558114464; Tue, 17 Oct 2023 08:55:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697558114; cv=none; d=google.com; s=arc-20160816; b=ZJ66bAdd5JkFaC5jpqvIyIr/4FFsiktCC/ZJZC4jGBuBOyJ+AZVw8ZM+vLg7ZRZui/ UIcrzAg4ZZKEYg3yy3SR45x+k7PLOEwco368pg3TYPY0RKyWKZX5CfZP6a0dhByQFXv6 SQF+plVWvOnUpNVrYBy4IKt7yCXUk7CFl8Wvwo1PDw1fNXGatIX5/Q91b0hDhE24D/UC xKme0YzdyJHOtq5IwXXunMWIx2gm7+2itnokcSBTCGSj8Osh/cgeBfqgQ8X10+t650ED 33UnQgfetnnDFxYvcIVuT/rkVv1iEED61JFEh2vLzmJIinW+JhD2jlHUpubjBUw1xLAB kgSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=VrFoNcC3S43mjlhiW+V1SrfZF7QU7fgttASsi6ItKq4=; fh=TLc5UBxGpR8rkjsNZ+7ZzbMqM/7g56DGBtmJ67+7/M0=; b=oCZNhhuGiG4J0zbbFj+Wv0g0WOt782YLU7ddOgSW+dzK5H/R9x2USbT6F0oqMDGtVw ymahWwaefJGFic1/FmngVobjfdLQ8CRHsf0tKc27u7pHS5NzX5jozAX9g1maQbu83LLD aISgJstuFNwqypCHZZrIquTeEN1S+o12o3BMoNYn23dQxXanyGy+e8oELlD0ysdbZNhD LbbrSGq6nP2BfF4pV9tTdbbeI1AmZBJ21u06A7iFRTOt2P29T0aQSlD02tWIvVoOvGw0 kzceff4DPV4t8HZt3HmqgZZcy3DgYPj3rwYsL0rgeG+fCxIIlG55EelBLPafRJIrS68X 07oQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=hjRhzilX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id x2-20020a656aa2000000b005b4600b5738si50317pgu.261.2023.10.17.08.55.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 08:55:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=hjRhzilX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id F2E1780B79D8; Tue, 17 Oct 2023 08:55:11 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344027AbjJQPzF (ORCPT + 99 others); Tue, 17 Oct 2023 11:55:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344161AbjJQPzE (ORCPT ); Tue, 17 Oct 2023 11:55:04 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E09EEF2 for ; Tue, 17 Oct 2023 08:55:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VrFoNcC3S43mjlhiW+V1SrfZF7QU7fgttASsi6ItKq4=; b=hjRhzilXs9do3FEcDzvCW+Imvp Kj8KQc8jeg60DnBVQtHAcMXdFlsIxZytVDaZQup2T2gNqsyHXgJC4I6+st48eu0Lz97hk/HJ15kZy Z5gl0f1zMdBTsVZGi8kXKfsVLNMq/+qZ3I6IBrF0biOmtfJ73gB7B6mf0cRx3+VUlpRA6vkxGOsvP PzPm/9L5VXiH3TGQ5+fN7fRtirYvRdiwiK3XzhRzmnvmU/+W+mo6VD9zuRwFDSXMjUUp+HAvQs4vl J68RL5N1pfk/odu0M4vv+KRz70MCWXuXk0LgCh8Yl+4gWVuswPlusELy5riGd3NOPULlVkLmBKWOx mvtPKSSA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qsmP0-00DCyk-L8; Tue, 17 Oct 2023 15:54:38 +0000 Date: Tue, 17 Oct 2023 16:54:38 +0100 From: Matthew Wilcox To: chengming.zhou@linux.dev Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chengming Zhou Subject: Re: [RFC PATCH 1/5] slub: Introduce on_partial() Message-ID: References: <20231017154439.3036608-1-chengming.zhou@linux.dev> <20231017154439.3036608-2-chengming.zhou@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231017154439.3036608-2-chengming.zhou@linux.dev> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 17 Oct 2023 08:55:12 -0700 (PDT) On Tue, Oct 17, 2023 at 03:44:35PM +0000, chengming.zhou@linux.dev wrote: > We change slab->__unused to slab->flags to use it as SLUB_FLAGS, which > now only include SF_NODE_PARTIAL flag. It indicates whether or not the > slab is on node partial list. This is an unnecessarily complex solution. As with the pfmemalloc bit, we can reuse the folio flags for a few flags. I would recommend the PG_workingset bit for this purpose.