Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <fc9266f3-ea4b-4df5-82ab-697ca6742176@intel.com>
Date:   Tue, 17 Oct 2023 09:17:55 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/1] selftests/resctrl: Don't fail MBM test when schemata
 doesn't support MB:x=x line
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>,
        Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
        <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20231017121750.15433-1-ilpo.jarvinen@linux.intel.com>
Content-Language: en-US
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231017121750.15433-1-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bVduQWtKMXExR1ptRlMyK0VLa1ZYV1l4c3Vyc3FEcjVqSXgrbTRnaVlkUTMr?=
 =?utf-8?B?Q2NGSlFQajlESURSbENpcS92ZGVGRnJjWGZ6bk9NYWFVNTI0TzZUZG5zTzJI?=
 =?utf-8?B?Z09GU3dmcG44RytkMDNjLzhuWm01SFJlZVk1NncxZFNPQXNhU2VOc04vcEMz?=
 =?utf-8?B?c01IYy9qU0g3RjB0emQ2eksyTkhBekxGazJKMnRaSDdWQnR5OXdzU1BZc0I5?=
 =?utf-8?B?ZWk3SHVFaG9wU0JBYW5SdVZhYjM0VE4ycU1ZNGxPMWtCeU9uTWRSMGZISlVX?=
 =?utf-8?B?bjJKa291VmxqWlVpRWFJbE4zR0d5U3ZiRDh3eE1UQ3NxRnBudGhRMUlTTVZP?=
 =?utf-8?B?T0FKaW9la2Q0bDZyNWJqdFdzdHZoUzIyaTZQd3p0cCs5OW8zQ2RVK3oxYW9Z?=
 =?utf-8?B?MlZpck9rc1hORUNFc2FOQzdQS0FDSDFEcitGQjlOK1cvWGZIUnMvQzFRWFRK?=
 =?utf-8?B?K3J2cFZ1OGVTRUZJcmplbFFCV1huc05EWDBhUVBEYlExVmtsS01WRnl4YWxL?=
 =?utf-8?B?VXNQR2VXYmFwVUFjN0MxZXJORDJVblV6ZCtaMjZPQzZIQ1FsUlB5Q29OOU82?=
 =?utf-8?B?NkYxcytOOXkyRS8xOFJFRUVkcHpJNlRGQkpiZFBOK0tzaWw2eFpHVnM3NXQ1?=
 =?utf-8?B?OE5NZXJ2Y2lJRFZtNjZLQ1dpOE13d0ZTQWNFYi9KMS9jVzBXZVBKbXRVN2Nl?=
 =?utf-8?B?dmJidnU2dzZ2MHp3cEdTQkI1TjgyMmh5WTdMTXQvbkZSZnU3bGxtVDhkZU9Y?=
 =?utf-8?B?dE5Da3A0UlBTa2dwRG41TUZHMzZ6ajBLL3NZcVV4ZHBPb3lUc0xyclVvd1JB?=
 =?utf-8?B?SFZkVGtnSHZFZWRWRHpIeGRGV0c4RDVka2VhSEZGbWtyZjA1M01aQ1h1NDNE?=
 =?utf-8?B?R2xieCt3MEVWY0xGczhBVlNNRXNCYmV0czhmZ3B1TUdNTk5DYi9TTlduR2c1?=
 =?utf-8?B?UnV5THJsQ1lmWXBRbVlRWWNCVWRoQXJhclJNc3owSExLWXp6SkxhZk83VDlZ?=
 =?utf-8?B?akhSaDA0cGhxOXBISTlIa0FBa0ZFNXVEUmFGZTRQdG9BS21CVHAzdVQ5WEJ5?=
 =?utf-8?B?VnV3dVVueXhOSlQ3SU1UOTBQK0FTaU4vRk9RVm5CbVpBMDRTalpXQ29TeExa?=
 =?utf-8?B?a0JVTnIwMktzQ2w2cVJ5VmpHODF0RlBsODFZOGMxcEtyckZmNFUwOTAxNmtL?=
 =?utf-8?B?NGZvL0hyMHJXVmJ1RjlqRGlNSXduaGhuZzQ1N3VOZ3hZdVV3SnVuT1M1c05i?=
 =?utf-8?B?WjlwZ1pQbFVhd21Uek9tS2VqVWtKM1hOUUpRRzFGbDZEelNSdCtDLzA5MW9w?=
 =?utf-8?B?Z0doZ0VhU2FOYmh0bGt1bkRFNFZnTi90cTJlZCtMRjdkYWdrbDhTSXB2ZHNM?=
 =?utf-8?B?K1RDZW1OS3RlRWpDTWJtcGRvVndSbEJFRmJUcmpqNTFib2x5bzRqVER6ZEpn?=
 =?utf-8?B?STVIelRNbTdMSXpJaUNxSjFwcWF0M3pFLy9oZlFhWnI3YmRvVDNIVEpGaHNW?=
 =?utf-8?B?cWYwTUJjeHNaTTJsOVV5Y0M4eVBQZXhKanBKMlVZOHpUSFFheC9LWDNKbjVy?=
 =?utf-8?B?WmxCdU55SlMyS3RkVHBPOFkxZTM5c0gvcDRJU1VNMzI4YitBMS9RU2FpRldJ?=
 =?utf-8?B?Q2NMUnRFSmFFN3pVdmNnUVgwTHFTZVdKRzNNTTR1dWkzSFhsT3V4L3pqeTgy?=
 =?utf-8?B?eEFQaHFubUNpUEVOWTJldlVOMy92dDh0ZmVaWTFDZVhDSjJ6dWZYOTZpUmxF?=
 =?utf-8?B?Y21BRmZLUnFkK2pkdTJvNzlzVmxwYjdteGJvN242ZmlsZE04YkQxWGh2ci9N?=
 =?utf-8?B?TmJyRHIrMFVLTUVKRlJCTFU2dldpSW5ORkRaK21wWjRkRVIxeE1SN2JqY0JV?=
 =?utf-8?B?cTFwT2tkZ2VVeGJxMzRIUm1qRWs0T3VtSmJ1MFhvS3krVi96ckluK2JYWW1W?=
 =?utf-8?B?SzRYemJFWnBWaGEzRFluOHhDZzhpTzZDNFViVEdIbUN2eXBhd2pUR0RPYzZF?=
 =?utf-8?B?dGZ3Z0xZeU1wRHZkemJLdFVhRmJoWDZGVCtQMTR5dEhHeGtZK2gyaXhzVk5v?=
 =?utf-8?B?a3JhcUZtTDVZWUZ0ZHhZaEJKQld4cWxnSVJRVHRBcG1kWkZnSmlSNDdLVTJp?=
 =?utf-8?B?eVgzUEhmZDFJSjNhbVQ4ek1oaDZVa0NiSHU2Zzd6dDRuaWpuQkJEMkxOYm83?=
 =?utf-8?B?SHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 90c98ed7-9e03-45bc-22be-08dbcf2ca04c
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 16:17:57.9192
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DS3yKfYQ7XbP2SfqrTSkp1gB+7K3Po36wKH0w56VHhwKU6WwBdblZyZrcxpey1D+ZeXxf/xSNysQu0RCuDXdZJ4pK2gGk+nCgW60DbzuZx0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7469
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 17 Oct 2023 09:18:13 -0700 (PDT)

Hi Ilpo,

The subject could be shortened to:
selftests/resctrl: Fix MBM test failure when MBA unavailable

On 10/17/2023 5:17 AM, Ilpo Järvinen wrote:
> Commit 20d96b25cc4c ("selftests/resctrl: Fix schemata write error
> check") exposed a problem in feature detection logic in MBM selftest.
> If schemata does not support MB:x=x entries, the schemata write to
> initialize 100% memory bandwidth allocation in mbm_setup() will now
> fail with -EINVAL due to the error handling corrected by 20d96b25cc4c.
> Commit 20d96b25cc4c just uncovers the failed write, it is not wrong
> itself.
> 
> If MB:x=x is not supported by schemata, it is safe to assume 100%
> memory bandwidth is always set. Therefore, the previously ignored error
> does not make the MBM test itself wrong.
> 
> Restore the previous behavior of MBM test by checking MB support before
> attempting to write it into schemata which results in behavior
> equivalent to ignoring the write error.
> 
> Fixes: 20d96b25cc4c ("selftests/resctrl: Fix schemata write error check")
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
>  tools/testing/selftests/resctrl/mbm_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/resctrl/mbm_test.c b/tools/testing/selftests/resctrl/mbm_test.c
> index d3c0d30c676a..85987957e7f5 100644
> --- a/tools/testing/selftests/resctrl/mbm_test.c
> +++ b/tools/testing/selftests/resctrl/mbm_test.c
> @@ -95,7 +95,7 @@ static int mbm_setup(struct resctrl_val_param *p)
>  		return END_OF_TESTS;
>  
>  	/* Set up shemata with 100% allocation on the first run. */
> -	if (p->num_of_runs == 0)
> +	if ((p->num_of_runs == 0) && validate_resctrl_feature_request("MB", NULL))
>  		ret = write_schemata(p->ctrlgrp, "100", p->cpu_no,
>  				     p->resctrl_val);
>  

Thank you for catching this.

Could you please ensure that this patch passes a "checkpatch.pl --strict" check?
With that addressed:
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com> 

Reinette