Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <ae0860d6-198c-4d82-a7a6-8d0656c9070c@intel.com>
Date:   Tue, 17 Oct 2023 09:21:32 -0700
User-Agent: Betterbird (Linux)
Subject: Re: [PATCH] cxl/pmu: Ensure put_device on pmu devices
To:     Ira Weiny <ira.weiny@intel.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Dan Williams" <dan.j.williams@intel.com>
CC:     <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20231016-pmu-unregister-fix-v1-1-1e2eb2fa3c69@intel.com>
 <b62ded44-4432-4aee-a086-1171b89fd2ae@intel.com>
 <652ea9afdf5b_2b0d2929417@iweiny-mobl.notmuch>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <652ea9afdf5b_2b0d2929417@iweiny-mobl.notmuch>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OTZJeTU3VVlKQ1RjSXVMQ3NoaWJxTlF2STBHWVNObWFiWC93dGgyZ1hFVytB?=
 =?utf-8?B?SFlIWkhnRmxRMFlxYjBwQjgxZnJPa21DbVNWYlZlbVpxcXJGTVhCT0hmblBG?=
 =?utf-8?B?L0EwOW5yZHZXeFlWVnlhL0ZwTGJCdWp5dU5vUGpiZkJQOFFVTENKWWRzd3Bi?=
 =?utf-8?B?Y2Y1V3RzSkFWc1JZMEVFVUR2KzBQYTZMcy9ZWTV0OW03QnV5aGh4Wm5nRVVx?=
 =?utf-8?B?NTNFc3k5VEpoUjZuN1kvTDZJZE0vWUZnL0pqdE96SFFIZzJJaW94NW1KR0Nh?=
 =?utf-8?B?cVdGUy8rZG04VzVrRHZkWjUyZzVvNTEreXA3bUtvamIyVVZrY2hJd1k1SHQv?=
 =?utf-8?B?SVBrRWJvR1creEZWZERIUEttaGRxRThPTERZQ3ZpQlNydENQSjNnSUpUVXpa?=
 =?utf-8?B?dVNlUG9lWVFqS0pyODhDR2tYZ0krTlIrVWJQQi84Y0djL3dxZHNraUR0eWdQ?=
 =?utf-8?B?bHdra2lOUGRrRHoxVVI0NklmeHNGa2U4TXB1eWxic2Y5SUV6MmhwUG4wSUVl?=
 =?utf-8?B?bEZDbXJVbFRGeTlUREQ2VnB4UEE3bkw3STZhUzRkeDZyN1FKaDlnVE82bmxK?=
 =?utf-8?B?eWNrMW81QmQ0S3QybHhKbnkzS3M2UEtNbVRLcWY0eFBvbWJhcHBxQ1p1UWVs?=
 =?utf-8?B?b1RGRENYZEdOYUNGWlNxd05TUVNBdmU2Vk1NZFBkQnd3WDVtRi9kazUrWk0v?=
 =?utf-8?B?QXh4UlR0YkVVQlBqVmRhblZDaVA5MEdDVFhCOTdyU243dUZvUmM0ODc4dnlv?=
 =?utf-8?B?YlJvYlllSjMzb3JXb2s2Y3NSSy9xTy9FbTgvUlJ1S29ldE1uRzRLZlZqVDdh?=
 =?utf-8?B?eG50MGdyUTNjS0l1em94SkdreVd6U0ZDbjBPM055eTNKVXRXY2t1em85QkNK?=
 =?utf-8?B?UDZWbXpqTGNqUGgxUFZ5OEtKYXVRVE56dkMwd3F6ZG5MTExsUVF1SGs1U1dG?=
 =?utf-8?B?eldpbVIwdTVMZXdwMThSWkZqdzRxRFRLaDlJOUdETDc5THpZdVJKeU94ZHVY?=
 =?utf-8?B?Q2tsbE8rTStIdXFuVnpIYnlQL1ZLeTROWUNUYTVWWFBUejkzM0tXSnFiQVFQ?=
 =?utf-8?B?VVJLZklZZVlBWjBSSTJmdGZZY09pNklXeGJYdWZCV2d6ckhWTTVaQVZocTFC?=
 =?utf-8?B?T3BJVVhYSjFlUmNzWHdZVFF0WjVIMUp5bWV2cnhDRHBuTWpFYWY4Wmh4Vll5?=
 =?utf-8?B?YUdOSm9RY2F3L1k3N1NKYjZCaFovbEhCWWpxaUFUenZRQkhqUU0vN0IrY3ds?=
 =?utf-8?B?VFloWCtwUGplZFhScktQcm9GbUZWYVVtb0lxWmdDYTJndi8zSUh1ZjY5ZVhK?=
 =?utf-8?B?VnpQbWxXUk1LUEczQ2d3NEExWmEvTzhxQk9jaG5ZT0VCWkdRVmgzTGhIUEFC?=
 =?utf-8?B?U2FjZFdlQVZTcG5DKzd1VnFXZnlXdkJOb0Qvb2l4blJkaEdKZTZTTndBUHFY?=
 =?utf-8?B?U3AvMVd6VGxuZmxVNlpGeXE5SkFqdjlKQ2Y4c1E0Q3ZEbXJ2YmlaQ2traXM0?=
 =?utf-8?B?YUZNM0dhUGRQVndUdGx5SkNIQm45THJqV0JONFoxMGN4SHpRYnhrQVRYZnA2?=
 =?utf-8?B?UlB1Qnh0bHpaZ1lxTVJmZElqTTNuQ1NYQ1B2TmNjVUV0a0hqRlgwMGQvZFA0?=
 =?utf-8?B?YlR1Y2dtYXFtckdraFI0bHIwWVVlRi94OWYzQUJINzRSY2ZNNm5CZlU5SnVp?=
 =?utf-8?B?dGxtRWwvNVJwaWZwZTU5clN6Qnk5RGxLVjB6RmZ2VnNGci9qSjNhc0M2Wmh3?=
 =?utf-8?B?Z2ZQSmg3azNqV2tnVHJLSzZUT29SelJNN1hGSWN1MjFJZzdLMUZOTHFqblJ6?=
 =?utf-8?B?OS9qa0xsTkVxUmdEZVU2YklNeWM2VklNVVNvcXlmdFg3SFZPSHV6Y0cvNlFY?=
 =?utf-8?B?RXQzSUs1Y2VyRDErVDBONkg3cTB5bEpGZE1HTVdmb3d4aUVLTDE0MXRLQkZs?=
 =?utf-8?B?aUNxVnNnN0E0aGV1VXlMR3hnamFIUllkdEtpR0R1U2FVd1hPWWlYUlZ2bGlm?=
 =?utf-8?B?Q3pCU2xseUpsZ3ZEOVNoOUs3cUxoV1hGRnJqWk1DbXZNVENxZ2FYK1FNdUhn?=
 =?utf-8?B?aXZrd2tJQkc4ZEVxU0x5c3Y5QnoyTERwaGFyWGxsdU1GYUNJS3NDNE9ObWpM?=
 =?utf-8?Q?+LSyjW4xtPX4DB45kIuqL2SUj?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 92310ba7-2139-4a36-952e-08dbcf2d20f9
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 16:21:33.8363
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KJVjgFDqsPjOUOWRLJzj6zgumXqMjWMmCaqRMalhdL7gEZMK4AoCUMiA9VS6kW/uW3cxVAxoqxIqtVP1FX3rkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5517
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 17 Oct 2023 09:22:31 -0700 (PDT)


On 10/17/23 08:35, Ira Weiny wrote:
> Dave Jiang wrote:
>>
>>
> 
> [snip]
> 
>>>
>>> Properly call device_unregister() to free up the memory associated with
>>> the device.
>>>
>>> Fixes: 1ad3f701c399 ("cxl/pci: Find and register CXL PMU devices")
>>> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>>> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
>>
>> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
>>
>> Although I wonder if we can just give device_unregister() to devm_add_action_or_reset() directly. 
>>
> 
> No because the action callback takes void * and device_unregister() takes
> a struct device *.

Ah right! I knew there was a reason for the wrapper....
> 
> Ira
> 
> [snip]