Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Sat, 14 Oct 2023 02:12:29 -0700
From:   Darren Hart <darren@os.amperecomputing.com>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     linux-kernel@vger.kernel.org,
        Vanshidhar Konda <vanshikonda@os.amperecomputing.com>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        linux-watchdog@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH] sbsa_gwdt: Calculate timeout with 64-bit math
Message-ID: <ZSpbfXzFeaoUJRZ3@Fedora>
References: <7d1713c5ffab19b0f3de796d82df19e8b1f340de.1695286124.git.darren@os.amperecomputing.com>
 <bcc41311-075c-44fe-b0f7-30564d7ac58c@roeck-us.net>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bcc41311-075c-44fe-b0f7-30564d7ac58c@roeck-us.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sc8KgtfuVhGSIk7A6e3+xkbZEnb6Qyyq2fo98yFGTH51XxVhXI5eIzTfYv8R?=
 =?us-ascii?Q?rakNhvkxl1kPdB2Gg/bVt/k4GPDosXhg9Olt4giqbe3jbTr6obizKrpWNrTi?=
 =?us-ascii?Q?Wzjyv7/QDQ/TyWzrp2VDWAOk25c7k/el7OdwJfymZ1hgUtliVWk9JlyllJJo?=
 =?us-ascii?Q?HttToX49DjdvyXwvajjv0lN5ziNJhJ+NMJs0XXNddGqUbPA3V+Oymp3uSM+Q?=
 =?us-ascii?Q?fR5jVrxjtnQjRiGjTOf7YHghHekgU+DsGVwzY4xvHwwCNY5Kpm12UfAVU2cW?=
 =?us-ascii?Q?KB79Hds5+7689VrLjky1ojO7thlA074uIUpe8bmBWfEyagZ8SS24ugY36gyh?=
 =?us-ascii?Q?pBHdmPRuoc2j8HlO3cCwCN1JpvuvH23KmlzShw6ZDocfvtjo4Ji0KE7TLxRs?=
 =?us-ascii?Q?y30QON7cJT2exBXADVUdjGu0TcWKt0sIkECeNiaxRaJdcWB3qt0dWZk04E59?=
 =?us-ascii?Q?OPH3ab/K80WmdW4Ze8EeWo+uayQfJp7o35vatvE4ShUss8bm/5Xm6DH4MuTo?=
 =?us-ascii?Q?WT/2fw2PkI/9X8HZldVBFVR+W5bVu+g2dzgVn/R/7BbwCPzU33EDDtJd1Mys?=
 =?us-ascii?Q?oTCyT6dZbN2d9vLMgP19IUtCUVpX/uoMyBCQj5RThmOneBKjg+uXCL96K5nF?=
 =?us-ascii?Q?vNR69KZa0QzepUQ9mTmspeyghW0IoD2aJYGXn78ZOfzswr5nVHT5hziFkRKg?=
 =?us-ascii?Q?GylN6r5En9fvZv8LkWIhOMNk8z6ozVdMncD0uRosHAgGPVQ9Ssi3FfD1QzBj?=
 =?us-ascii?Q?oE9iuA47UGfH2EMsXXVqSTbhdpi/7QvkMKGJXCRxnVbXCzJeFoVXTImrr8sa?=
 =?us-ascii?Q?MwwyMJDqUjdFMvcm0j4/mUP44lJDF+IrB8/8Slxy6xbXOD6muLoJ4nEbuAOp?=
 =?us-ascii?Q?BrLrBTWPs8BTFY4xQJqPxK5Zz/SgOQMJxFOV6cSrSbbZKoLIvuIKhHzxrWy5?=
 =?us-ascii?Q?LcduNrB/fm+1WuLFz7aldax8Rws6Tot8SR4cDyFCQ94PrIpRzRXSF7udvck9?=
 =?us-ascii?Q?eb3tAkUdtb61+nTNNubrGShux9fAU+tznoDFnifXP54SVaGTgTkD7KPYwsgi?=
 =?us-ascii?Q?qMFPGMLnREyKIUt+XQBEzfIfCCVKGiBWGRLLgMmeGm4T81vtNANQkNGl7GRQ?=
 =?us-ascii?Q?aX1fzwjFbja8F5ogWUAbwmIV3sTQ7CAkjobl87n/JD/aeK0nLZCoUSBPiqQ6?=
 =?us-ascii?Q?kh6Lj3NBB0UgdVhYFlAbS+2/qmdDYLGVq70WWm9JsEyK6ve5Z1JvmIz67x3R?=
 =?us-ascii?Q?67NQIzGMB2Mv8NGCbQIBex70j8IYhbMCDTo535kJV4ff0qnX6ez+4ob2BWsL?=
 =?us-ascii?Q?EZjJA2L96x7rszLXskV7xK+pCntU53pXcZiy3rglVSwhcMG/fi/vLAEM+Lhk?=
 =?us-ascii?Q?SWN+ST3L+1DNwCC3usjKvgfN19zE+664dcRdVEgYrMLj86tm4XPC7HhkHSmc?=
 =?us-ascii?Q?n/Me9+Rkr1IYvu9pnDvbU/jRLyf4lg5Ae47F4riWyua/P75bvOD9c6VSzi9q?=
 =?us-ascii?Q?+u5MN/htJoNNdD0gM1BZdc9AFFlrJbr/hYsZyortYM7GQ4SzAIRNyH7X5sJz?=
 =?us-ascii?Q?qPuIK+Tjs/sD2KIhOtYMBYuY61L4UXj8f2me78HOXERX5PjU7pqugUf/6o25?=
 =?us-ascii?Q?sWaNl8nyEK1m+20VMMCWGik=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d92c352-64d2-4029-758b-08dbcf2e3ebe
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR01MB8007.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 16:29:33.5743
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zuJ1bQ3CqjKICFEf4QVaaWWEUbIsKcR/T9dX0wVTXsvrMS5DsylVx+PHgrJQ4Tgil9i7WwrLlOr2QkiN4AKRhN5GcgJGZVOhU80Qu4wDQD5BOzfCcr7XUVq+Lvw3ovCc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR01MB7212
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 17 Oct 2023 09:30:00 -0700 (PDT)

On Tue, Sep 26, 2023 at 05:45:13AM -0700, Guenter Roeck wrote:
> On Thu, Sep 21, 2023 at 02:02:36AM -0700, Darren Hart wrote:
> > Commit abd3ac7902fb ("watchdog: sbsa: Support architecture version 1")
> > introduced new timer math for watchdog revision 1 with the 48 bit offset
> > register.
> > 
> > The gwdt->clk and timeout are u32, but the argument being calculated is
> > u64. Without a cast, the compiler performs u32 operations, truncating
> > intermediate steps, resulting in incorrect values.
> > 
> > A watchdog revision 1 implementation with a gwdt->clk of 1GHz and a
> > timeout of 600s writes 3647256576 to the one shot watchdog instead of
> > 300000000000, resulting in the watchdog firing in 3.6s instead of 600s.
> > 
> > Force u64 math by casting the first argument (gwdt->clk) as a u64. Make
> > the order of operations explicit with parenthesis.
> > 
> > Fixes: abd3ac7902fb ("watchdog: sbsa: Support architecture version 1")
> > Reported-by: Vanshidhar Konda <vanshikonda@os.amperecomputing.com>
> > Signed-off-by: Darren Hart <darren@os.amperecomputing.com>
> > Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> > Cc: Guenter Roeck <linux@roeck-us.net>
> > Cc: linux-watchdog@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > Cc: linux-arm-kernel@lists.infradead.org
> > Cc: <stable@vger.kernel.org> # 5.14.x
> 
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Guenter or Wim, I haven't seen this land in the RCs or in next yet. Have
you already picked it up? Anything more needed from me?

Thanks,

-- 
Darren Hart
Ampere Computing / OS and Kernel