Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <97473ad9-c9c8-450c-bb1a-ad72dea0a5ad@amd.com>
Date:   Tue, 17 Oct 2023 09:52:57 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v2 03/11] pds_core: devlink health: use retained
 error fmsg API
To:     Przemek Kitszel <przemyslaw.kitszel@intel.com>,
        Jiri Pirko <jiri@resnulli.us>, netdev@vger.kernel.org,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Michael Chan <michael.chan@broadcom.com>,
        Cai Huoqing <cai.huoqing@linux.dev>,
        George Cherian <george.cherian@marvell.com>,
        Danielle Ratson <danieller@nvidia.com>,
        Moshe Shemesh <moshe@nvidia.com>,
        Saeed Mahameed <saeedm@nvidia.com>,
        Ariel Elior <aelior@marvell.com>,
        Manish Chopra <manishc@marvell.com>,
        Igor Russkikh <irusskikh@marvell.com>,
        Coiby Xu <coiby.xu@gmail.com>
Cc:     Brett Creeley <brett.creeley@amd.com>,
        Sunil Goutham <sgoutham@marvell.com>,
        Linu Cherian <lcherian@marvell.com>,
        Geetha sowjanya <gakula@marvell.com>,
        Jerin Jacob <jerinj@marvell.com>,
        hariprasad <hkelam@marvell.com>,
        Subbaraya Sundeep <sbhatta@marvell.com>,
        Ido Schimmel <idosch@nvidia.com>,
        Petr Machata <petrm@nvidia.com>,
        Eran Ben Elisha <eranbe@nvidia.com>,
        Aya Levin <ayal@mellanox.com>,
        Leon Romanovsky <leon@kernel.org>,
        linux-kernel@vger.kernel.org,
        Jesse Brandeburg <jesse.brandeburg@intel.com>
References: <20231017105341.415466-1-przemyslaw.kitszel@intel.com>
 <20231017105341.415466-4-przemyslaw.kitszel@intel.com>
Content-Language: en-US
From:   "Nelson, Shannon" <shannon.nelson@amd.com>
In-Reply-To: <20231017105341.415466-4-przemyslaw.kitszel@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OW40QjN6dVkrWURscTV5ZUpKZ2owejZ4RThDbWtkOWlwTXVpSDBhSGVBT3Ey?=
 =?utf-8?B?VlNQZDZUdC9WR0o3RDUvTHZJdlhNZXY2QklCbmZqak1BRW1sNURKR0RuTXM5?=
 =?utf-8?B?K2JDQTcyTSt6VGJhT0pKTmU4TktZWkVqR2JOelVTOXBlb3c1NGk5czd6anEx?=
 =?utf-8?B?K0E2NWEzQ3R6WEVLRVFlSUgwS3kwK0JEWXUyNkM0QWszWVNaN3Z2QjFoUFJ3?=
 =?utf-8?B?SHVpVnBTMjNDWXV6VldwdkVMTU0wcHBVUHg5QlNXMjRRbnp3L0NtN0dyMWNX?=
 =?utf-8?B?aUkvWDc1WEFYSkwwK2czd2NROFBFN0cvVUl5blN0bDBHK1pnOEJUU3pFWVd6?=
 =?utf-8?B?RUFHTXNXZ2NQdEg3VXRpa0t0aE1McTZaZjhqWTgvRittLzFFWVB0UzR3b2Fh?=
 =?utf-8?B?ajQ3aU5kcEFzMm9penV1TmVwR0hPOHZRZlNaTm5mdUlSbWdzUmxqWkpoT3ZT?=
 =?utf-8?B?eEI5MTJPendKRU5NWWx5a0kycTRadW84SFp5L2JPdjVyK2V6cVJzSW0yaW0z?=
 =?utf-8?B?b3htUmtLNFJtTng1YVIxZm9lek8vd2k1WU13YmhhWG8yUTMyVmhCZzY3aXcx?=
 =?utf-8?B?M3dMaVZJMjdQVjVkYktnZkZtRnFKNzJlVUNnWVU1TTdHa0pNWkFlVFpkYnJF?=
 =?utf-8?B?TEMyQ3pwZjRIRDVKTElpblJXVHI2REU4aVZ0bTR5bjdtMUtVOXM4UTlnajZL?=
 =?utf-8?B?Rlhkb3gxTmRxZUdXcnJmeGQ2dzB2eVRPc0lra0o2SDFmc1oyNUtNVWVCakpZ?=
 =?utf-8?B?SWFSY1BNRjZLbENweHh2d05SUE1tMHI1ZDU1OGlubEt0L0xwNDdCbU12cnhE?=
 =?utf-8?B?Z2NIUjNuODNxOGtPSU9LSlBHRjRrbDhkMjJhSFk0UUlvWjNzMFlPOE1wdHlK?=
 =?utf-8?B?bHJRNSs1RmJ0LzdrZDdlNDhGaGJoOFJucHFVRk8xVlZHd1c1VXZpSHE5eEJP?=
 =?utf-8?B?QUc0K053UTFYNDdibjRRK3ZpdUJJVGQyZlo1bHRrbzV2RlhMREtKdDN6MjJM?=
 =?utf-8?B?RzA3Sms2citjMjAyU1hNSFRIQVNmK2NBZHVSWDJPRDRNVHRJVnhtRklpZmhZ?=
 =?utf-8?B?SlN6M0xic0MreVk1RnVGclgrdmRmc0xZaGpNVHVUY085WnBOYWpwaVpWYVJ6?=
 =?utf-8?B?MEVYZ214TEZUb25ma2tkWU94VmR0S0V0ZWllcllrcU9XTUo3TFcveSsrcmMv?=
 =?utf-8?B?dHgzM29rYkdQMVZrQ0ZLOUNTNU5FOUd2dThVcVpRa2VtYmJlZmY5ajZRK1Ur?=
 =?utf-8?B?MWZkVElIdTJNbWtVVTNRTTkvQWFUYlNtR3NQQzI3bW82eXJ3dlB0ZUJUSlBa?=
 =?utf-8?B?NC9ZZkRnVlRjeWV4TURlZXFhWUQ2S0pZSHVBQmliYk9CbUNvc3JqTjRQVWFJ?=
 =?utf-8?B?TzlaZ2o0RWZUUWxjVkVsVnZSNWlQbWhSdXg1R3ZOT05wNGZmRXROTnMvQW5C?=
 =?utf-8?B?SW9oNFVUbGFoS2F1OHcxK0JNQ2VobW1YbmZDdCtyT0ZZbEJnaGRLbUpwU0I0?=
 =?utf-8?B?bDBXU2p1Vm9PU2owVlVmMmlidmFnTDJmMy9mZDA3a1psbFEwaDBMekxOOTZ0?=
 =?utf-8?B?eUNxYVNMTUFlanJPK0g4dHROMGxETUFMdlRvOTNEbjdtaUFYY1ZSU0VXUUdi?=
 =?utf-8?B?bVV5eDVvaEdaRy84d2xGUTdkcGZMdXNGTFBieUZpNnJGS0tJZVUveFJUaVpi?=
 =?utf-8?B?eXdpR2lLUCsrVFVtOXBnbkMxY0EzVVA0WjkrcXNsV2k3dlB5djZrQ2hhZDJ4?=
 =?utf-8?B?S3doVFF4SlNab01YKy9uSmtuczVCdCsxQTJCNnpHSFUwQjR3VmZueGZZbldF?=
 =?utf-8?B?cmJ4L2pvV3dDdmVNY0xGUnVGTDl5TUE4QnhwT1ZjbXUzREJRYWRsWTgrbk9U?=
 =?utf-8?B?NEFNalJIQzhuWEUwaTJVV1J6SCtoS2gzdVBLcVA2UHFSZkRrdHZPZG9aOEV1?=
 =?utf-8?B?M29iRldaaUpZaDF2aGZMOXcyZnBMR256aitTbFd0ODlJMzc5VnAycTd5Qlpi?=
 =?utf-8?B?R2tUTjdnV2Q0VW5ZTzdpUUM4V282QlM0ZWlKRm9lZjFndUNFdzdjeDJONVRj?=
 =?utf-8?B?cmZCV0dOMmRHa3NtUG1reHp4TWp1alJBN1BnUUVFSHRLTEdpditWb1dXbllB?=
 =?utf-8?Q?MPQt9mk5+fhlnv2q8mQKFZSsE?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e52088fa-a18a-44df-c4ab-08dbcf318683
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6583.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 16:53:02.2742
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jmBHwB8AGJVWPtfDQ8g9nErDbq2EOJ+NgrwWtWAAbkRGnKGoRe2Yt5oSogrIvYqtJJhV97RezEpWwu7/c2MyrA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7861
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 17 Oct 2023 09:53:13 -0700 (PDT)

On 10/17/2023 3:53 AM, Przemek Kitszel wrote:
> 
> Drop unneeded error checking.
> 
> devlink_fmsg_*() family of functions is now retaining errors,
> so there is no need to check for them after each call.
> 
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>

Thanks,

Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>

> ---
> add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-57 (-57)
> ---
>   drivers/net/ethernet/amd/pds_core/devlink.c | 29 ++++++---------------
>   1 file changed, 8 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/net/ethernet/amd/pds_core/devlink.c b/drivers/net/ethernet/amd/pds_core/devlink.c
> index d9607033bbf2..8b2b9e0d59f3 100644
> --- a/drivers/net/ethernet/amd/pds_core/devlink.c
> +++ b/drivers/net/ethernet/amd/pds_core/devlink.c
> @@ -154,33 +154,20 @@ int pdsc_fw_reporter_diagnose(struct devlink_health_reporter *reporter,
>                                struct netlink_ext_ack *extack)
>   {
>          struct pdsc *pdsc = devlink_health_reporter_priv(reporter);
> -       int err;
> 
>          mutex_lock(&pdsc->config_lock);
> -
>          if (test_bit(PDSC_S_FW_DEAD, &pdsc->state))
> -               err = devlink_fmsg_string_pair_put(fmsg, "Status", "dead");
> +               devlink_fmsg_string_pair_put(fmsg, "Status", "dead");
>          else if (!pdsc_is_fw_good(pdsc))
> -               err = devlink_fmsg_string_pair_put(fmsg, "Status", "unhealthy");
> +               devlink_fmsg_string_pair_put(fmsg, "Status", "unhealthy");
>          else
> -               err = devlink_fmsg_string_pair_put(fmsg, "Status", "healthy");
> -
> +               devlink_fmsg_string_pair_put(fmsg, "Status", "healthy");
>          mutex_unlock(&pdsc->config_lock);
> 
> -       if (err)
> -               return err;
> -
> -       err = devlink_fmsg_u32_pair_put(fmsg, "State",
> -                                       pdsc->fw_status &
> -                                               ~PDS_CORE_FW_STS_F_GENERATION);
> -       if (err)
> -               return err;
> -
> -       err = devlink_fmsg_u32_pair_put(fmsg, "Generation",
> -                                       pdsc->fw_generation >> 4);
> -       if (err)
> -               return err;
> +       devlink_fmsg_u32_pair_put(fmsg, "State",
> +                                 pdsc->fw_status & ~PDS_CORE_FW_STS_F_GENERATION);
> +       devlink_fmsg_u32_pair_put(fmsg, "Generation", pdsc->fw_generation >> 4);
> +       devlink_fmsg_u32_pair_put(fmsg, "Recoveries", pdsc->fw_recoveries);
> 
> -       return devlink_fmsg_u32_pair_put(fmsg, "Recoveries",
> -                                        pdsc->fw_recoveries);
> +       return 0;
>   }
> --
> 2.40.1
>