Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3294057rdg; Tue, 17 Oct 2023 10:02:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFURJpDgL8VinlmLArzQAZlTaUMnXWjNwFZrchrfvWNpJfBpoh324lQ7iq2RL/cVVvjOJcc X-Received: by 2002:a17:90a:d40e:b0:27d:2e5b:55ca with SMTP id r14-20020a17090ad40e00b0027d2e5b55camr2764316pju.26.1697562138316; Tue, 17 Oct 2023 10:02:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697562138; cv=none; d=google.com; s=arc-20160816; b=qNK1YnzfEmzR7bc8iItuK2k5gLU+fqPOTmcG1+DyJj4Jv3pacj/dWf66fffpinfXGg mmO6Gt4aszGAEUg9aFJa6Z38cASeG580XEi1VPkio5LESLWalvKNhH7WhwUQitTIK92E R3FSmCuz8vVoJ8sAO7JcuARXagbI5PUoi5jR1vtnQpo92qM47NHHF+fuHONtuZZ+RrgH UKyys8lZLRlRRwrhufvdFXUxZqF1BYWCfT5s2N1uo5+oSMJoemAQqsCzs3wT7TqI++ui Dqw5KKX6SsP6dWx76T7oHEUHpxBMOw+Y4aMsoRCe6+8SMidLYZR9gtaO8CKiR1Ar7NSV c6bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=NxQU6s/qAHqn7VDyp1YjzniBNQhauBKrH8lBTjwf08k=; fh=XJzEqKBnuT/lIBK+65ucpL6HDEEjiQLudLyYNwmGTiw=; b=1GnlyF1UTetb5BrWTjX+ROeqUMNLxgSZkvIvZZ40qr2JVONyBNUWdr2SDievDWPTZb CP8ciCGY8IOY8q3X8EiKyQWFEyhlT/HXbJPXHLGivgzWEEZ52EiMUo/5usTzNmyTAD6F vfXkVxTLLCC0JGIQmMpBGbEyDnmbauZLOBWMPE02DhinqEIYxC5aqsxAqgEHntbA/Mgy e22FRxccgk9T6XEzMfKkyIz49sAiCi0nWM1IXPT3PqxSL9kjEneyNL2bAzAVpKM4vPWM gcB8B4SQFTJ2LLGKItF9j5Q9HIrH2xJ8smngmwL9hdTGwR3o5kX1uB7Ad465uT5WQax7 FhCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id a8-20020a63e408000000b005859cd26197si162623pgi.455.2023.10.17.10.02.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 10:02:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 05900802EAF8; Tue, 17 Oct 2023 10:02:13 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235027AbjJQRBw (ORCPT + 99 others); Tue, 17 Oct 2023 13:01:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233940AbjJQRBq (ORCPT ); Tue, 17 Oct 2023 13:01:46 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 76408113; Tue, 17 Oct 2023 10:01:41 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C42502F4; Tue, 17 Oct 2023 10:02:21 -0700 (PDT) Received: from ewhatever.cambridge.arm.com (ewhatever.cambridge.arm.com [10.1.197.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 978083F762; Tue, 17 Oct 2023 10:01:39 -0700 (PDT) From: Suzuki K Poulose To: linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org, Yicong Yang , jonathan.cameron@huawei.com Cc: Suzuki K Poulose , hejunhao3@huawei.com, yangyicong@hisilicon.com, helgaas@kernel.org, linuxarm@huawei.com, linux-pci@vger.kernel.org, alexander.shishkin@linux.intel.com, prime.zeng@hisilicon.com Subject: Re: [PATCH v3 0/5] Several updates for PTT driver Date: Tue, 17 Oct 2023 18:01:32 +0100 Message-Id: <169756192530.746517.2466420521869567832.b4-ty@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231010084731.30450-1-yangyicong@huawei.com> References: <20231010084731.30450-1-yangyicong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 17 Oct 2023 10:02:13 -0700 (PDT) On Tue, 10 Oct 2023 16:47:26 +0800, Yicong Yang wrote: > From: Yicong Yang > > This series contains several updates for PTT driver: > - Disable interrupt when trace stops, reverse to what we do in trace start > - Always handle the interrupt in hardirq context I wrapped the commit description to 75 chars for this patch to suppress the following checkpatch warning and queued it. WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #10: change of arm-ccn PMU commit 0811ef7e2f54 ("bus: arm-ccn: fix PMU interrupt flags"). total: 0 errors, 1 warnings, 12 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. "[PATCH] hwtracing: hisi_ptt: Handle the interrupt in hardirq context" has style problems, please review. > - Optimize the AUX buffer handling to make consumer have more time to process > the data > - Since we're a uncore PMU so block any task attach operation > - Add a dummy pmu::read() callback since the perf core may use > > [...] Applied, thanks! [1/5] hwtracing: hisi_ptt: Disable interrupt after trace end https://git.kernel.org/coresight/c/4669551e797a [2/5] hwtracing: hisi_ptt: Handle the interrupt in hardirq context https://git.kernel.org/coresight/c/e8b7d8718c51 [3/5] hwtracing: hisi_ptt: Optimize the trace data committing https://git.kernel.org/coresight/c/7a527d4d9273 [4/5] hwtracing: hisi_ptt: Don't try to attach a task https://git.kernel.org/coresight/c/7d52e2cfef91 [5/5] hwtracing: hisi_ptt: Add dummy callback pmu::read() https://git.kernel.org/coresight/c/4708eada8bd6 Best regards, -- Suzuki K Poulose