Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <54dfc01b-bd6b-4cf1-887a-749b45ede088@amd.com>
Date:   Tue, 17 Oct 2023 13:54:25 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/amdkfd: clean up some inconsistent indenting
Content-Language: en-US
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        alexander.deucher@amd.com
Cc:     Xinhui.Pan@amd.com, Abaci Robot <abaci@linux.alibaba.com>,
        linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, christian.koenig@amd.com
References: <20231013032129.55504-1-jiapeng.chong@linux.alibaba.com>
From:   Felix Kuehling <felix.kuehling@amd.com>
Organization: AMD Inc.
In-Reply-To: <20231013032129.55504-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDhSdXNhem93LzlCZXBxeE1BanNpaGs5eE93cFpxbC8xZ0Nrb2UrOXNQVHc3?=
 =?utf-8?B?dUU0MGg4ekxTZ1Jjblkrc2hnOWFQTnRUSHVteTJ4SDJQU1phYjJib2JYd2ha?=
 =?utf-8?B?WnEzRndxeW1lSHlVTHQ0UlAwQWg5d1QzQ2dMOW1oR0JtYUtabERNc2NhanN5?=
 =?utf-8?B?WXU4dDBzVlJnbmp0cEJRZmdpSFcybndmeXdiY3U1WCtYSWhIM1V2R0F5cHZK?=
 =?utf-8?B?QTNtLzlUY1VYU1l4a1VyVCs3enBnREVEUkNaQ2NodWM0aGJFZ0dNVzFHMXVz?=
 =?utf-8?B?UEE5ZG5ka1JIRnhvYk1EdWhxN3BZTGE0M2tLSjV5VFB4V0dscGNVOE45c3Vt?=
 =?utf-8?B?VG5jSUZWcG1mbTVjMHVtVndxclpDbVpBMldrZkVudzY1dG5Ca3NNM3MwMU0w?=
 =?utf-8?B?c2ZZakhqUDZHQXQxNEVaMUpPWVlhRmYyYWl0MWpsT3NCU0RmRlppWTV0ZVZT?=
 =?utf-8?B?OGUyZmVkYm9lVThidUpiMXlTa2ZGQldlZG55dVlYQ242YnNsbG9aY2J1RTJE?=
 =?utf-8?B?aUZkTVJqZlNtRHFQTnNmM0RSNit1ZzB2UkxGbWNzVEk4c2VXL3FiVC8xdzNI?=
 =?utf-8?B?Z3gvdWJNNVplK2ZzQThOeHZjdmo1ZjEwV0Mrb0g3UVBMMlpZWlYwVHRSa3Fu?=
 =?utf-8?B?dXkySEJKWkFVcUd1cWpzMDVXd3VZdGljNThNSyt4dTlEdXJKZFJlL0E0S1pR?=
 =?utf-8?B?TWV6L25mZENuRDJxWndwQjZnN3RNaUpHUURtQk9QZkszUzhhYkRnLy9TNC9R?=
 =?utf-8?B?ZXFuWVlPa2xjb2k1eWYvWGhqNTJMeWVCa1poS2QyczdTdFhES2NqTmtZczE3?=
 =?utf-8?B?T2YzMTQwVDNsY01HdW5rSngzdDBpTHFQN2xOaWkwS2crOVYyMzhjeXM3Q216?=
 =?utf-8?B?TGx5UHBUQXMvZjBDSjVUNHdPWnBFblZFdXNTZ0MxSzE0TjkrS3k3ZVY4dm0y?=
 =?utf-8?B?OGZ0L2tvaGJwTzJwT3Z3VjFCK2h0c2EzZUtsT01HbEpSN1FkY0FONEtEZUZX?=
 =?utf-8?B?VWd2Zkx6ZmtxaWVjYTEvRXo0a212SUJJOXBiemNndUQ3SnRxZDE1RGp2d0lq?=
 =?utf-8?B?SDE3ZGw1ckh5amh0bjQ2b2JuamI5RytNWHRIc2Nsc09UZmorK3ZMVXNieUlU?=
 =?utf-8?B?WHFsS0VmVlRTMmJKSVhMNXNPWjVua0xUWXd4KzNRYS9nUUxId1gramwvTDlC?=
 =?utf-8?B?UVZyUUo5b3VNL09PVzlnakFORlBBZkJuWWk4Y3JDQVJVVW53eXBCckg2aWxs?=
 =?utf-8?B?NGVJQWRZOFpnRVNXNTJOSFlMRlh6KzJnQ1dJMm5oZFA1M2lXKzJDcjdyVHcv?=
 =?utf-8?B?Ly85T2ZLL0ZGYjk1bWh1NWFONGF0MDJ2bmkrTHlmQ3VOckZyNjgvRmZMQ0Vj?=
 =?utf-8?B?RFFCazFyYnlWbkY1UFZyNjVtM0RuVjlGekhnNkpkVWxPcE0yd1hEdkcwMm8x?=
 =?utf-8?B?Y2wwbzl1Ti9JNHBQNUJxQjYyVUlYRmZQYnNoVjhGNFliRy9COUhReGgxSUt6?=
 =?utf-8?B?RXBDYzdDL1J0S3pqZDRVKzRnYzI1YkRjQnI4am9BZ3NGWTJ0NDB2dlFRREps?=
 =?utf-8?B?ZWU0R0I4aDN1L3RGSGpaZFhaTzRiRU1sQUQ0VTRBTExteU9OYW5CYVN1ZUZM?=
 =?utf-8?B?SUF4UmpoczVDaDRCZG1DTy8vbmp5ZG8xWlNvT05SSkU1UzlMcVRiSE9kNk1r?=
 =?utf-8?B?VVhtWDFqYldtdm9va1BtOUtsK2NNNnNZSnNqeU51OHpML3NNNXZpRWxPS056?=
 =?utf-8?B?dVFldHAwTGRzRDhycTJtbDgxdG5FZGV5eDU0azZQcFVHOEdyTSt2UTJySk9Z?=
 =?utf-8?B?UXdyZGdFZDFqcjRQck1leXpyUVAwL2VtQnZ2WC95b0ZUZys5YmREc2xxYmk1?=
 =?utf-8?B?YTM5ZmRLeWF6Z3JHUkh3MFloTlA3OWZMaWxwZUtGSkVhZlJsZ04xOGpvU0ph?=
 =?utf-8?B?R3RuNDRsWUVESGlkcG1aTTFLNU5LeDU5VGo1RkZBa1BsZ1VTVDBJSVU5dE5p?=
 =?utf-8?B?eDdVN0ZwV0UvUkw5ZytieUdUa0VVZXJmdDNtZ3VYeVRibldzTklsNXArQVRn?=
 =?utf-8?B?QXF5Y3RrUER5VWNYdFBuWmdjQ3JaMy9OUVdCR0U5aDVzeU8xSm9GSGJjUHVV?=
 =?utf-8?Q?0KePIYfG7KnOI241j8pBvR7ZM?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25ba13f6-093a-49ac-8ca1-08dbcf3a1bc5
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5115.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 17:54:28.5426
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 28sAib4cUdduX6/kD6tu4K0UmAFiHNqMTe3My+sd2RlbtzWReiNLBlAGiI8pAT3URAxbVaXCbuPshU8GGSiYgA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8466
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 17 Oct 2023 10:54:50 -0700 (PDT)


On 2023-10-12 23:21, Jiapeng Chong wrote:
> No functional modification involved.
>
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:305 svm_range_free() warn: inconsistent indenting.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6804
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

The patch is

Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>

Applied to amd-staging-drm-next.

Thanks,
   Felix


> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> index f4038b33c404..eef76190800c 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> @@ -302,7 +302,7 @@ static void svm_range_free(struct svm_range *prange, bool do_unmap)
>   	for (gpuidx = 0; gpuidx < MAX_GPU_INSTANCE; gpuidx++) {
>   		if (prange->dma_addr[gpuidx]) {
>   			kvfree(prange->dma_addr[gpuidx]);
> -				prange->dma_addr[gpuidx] = NULL;
> +			prange->dma_addr[gpuidx] = NULL;
>   		}
>   	}
>