Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Tue, 17 Oct 2023 13:17:29 -0500
From:   John Allen <john.allen@amd.com>
To:     "Nikunj A. Dadhania" <nikunj@amd.com>
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        pbonzini@redhat.com, weijiang.yang@intel.com,
        rick.p.edgecombe@intel.com, seanjc@google.com, x86@kernel.org,
        thomas.lendacky@amd.com, bp@alien8.de
Subject: Re: [PATCH 3/9] KVM: x86: SVM: Pass through shadow stack MSRs
Message-ID: <ZS7PubpX4k/LXGNq@johallen-workstation>
References: <20231010200220.897953-1-john.allen@amd.com>
 <20231010200220.897953-4-john.allen@amd.com>
 <8484053f-2777-eb55-a30c-64125fbfc3ec@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8484053f-2777-eb55-a30c-64125fbfc3ec@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6XUWiT8jRU4cFjUrdzzBYZXKaBQ+zYsQVWvAol1oAen18oEkXImu9LijsTKQ?=
 =?us-ascii?Q?LtFo7BqxfQPJWioR2k3VgmwDr0ilWT4ysVZpAak/q76IFWphCk0AY2xyiZJ8?=
 =?us-ascii?Q?zhEIWpoTGz3XOHVX2syH4giVcARjxR2IVDU9JL4CEGHBq98BdXB1yNK3CSXW?=
 =?us-ascii?Q?VSBSdDK8HB5qJHY7ksVvFJJDLTI9MF18vaXwfJNpe+AfJLTsEGNGcacTUD+x?=
 =?us-ascii?Q?UpzdtsPvLf+nyJlgkuGLd5s6Wsp0RBc4BpPia9O+g2IyR7zCtOJx45c4ZhHf?=
 =?us-ascii?Q?RIw5/xTOcSWUUR5NB+4P2HUthzA3eC2H4wF/S6Y9QI5Iuz04X1gxNHWy7/i6?=
 =?us-ascii?Q?vHZBMEnAgzmF+Ij893pF3hGLhtc7xm3NmgkcyFJZCDCx+Q8T4OYReive2CAU?=
 =?us-ascii?Q?VfCnFEMJPYvCKK9fVkRO6meZUu/p77gA47fzVm34UH+S0AzML1szQapXErzd?=
 =?us-ascii?Q?GkmeAmk2AaygOjboprFaxkg45xxDDThaD9PZXdr3mnNLhG/aoWtrFEwlI8ri?=
 =?us-ascii?Q?zcfd/yglMUKHOxqVw2fEpaqpKEVOruJqEJoWGP896d9/MbfeDJfSn0zJ+Whn?=
 =?us-ascii?Q?2zR4GreuVO6NeRNbCBorzPR9cPGhSwsJJJODsnhHT3lSUkokjAMHxyTlSi++?=
 =?us-ascii?Q?tbZUCwsy4dRih4P4WoaeQZ5olm3HSQ1PuXqn2VWX0/d8b36hOXo9l9gUisJE?=
 =?us-ascii?Q?LKDbuhwn5zq3qa6O7J5Pu48nEyLFZYpYleAQBfbJC/nl2G7NAmvRkrsfVQ/b?=
 =?us-ascii?Q?IM1sQHgTDp7o1POH+u24ACOWOQ19pqXpm7rS/VJvWvm2leqMRPU+BAb15d2l?=
 =?us-ascii?Q?moQiCwV0nDsKE3Pnmnq+rdymiO87vb5pMf80L/ypIZbcv7W2G5UEm9yWA6yM?=
 =?us-ascii?Q?YBWWVPhaQkOPMHm7vpe5VUo3w+gwuRN7ZEns/lHiOs1Bc2cLAmcpKTmJwLBS?=
 =?us-ascii?Q?+1uekt86796104G+Bh8Qfjt8IwhIazayQTd2QV8MbTJAmKZbpoDoYw/4ofes?=
 =?us-ascii?Q?7VeSv3ZnE6Uixty6SrOHPIphtg1IQau9oF8tC6d8ZLMK3L5bQ+MZX5xOpW8W?=
 =?us-ascii?Q?NONEd8YH2zTQeiJx+RyI8qSsrQsXdr+d6AzMzOtaspp39Eue+f44L+mpgmHE?=
 =?us-ascii?Q?g4eRj0GahQFQZ9Va/Yj+shXK+cziY0akjWcLJY1dYj20LF6GfumqNdf4XaJb?=
 =?us-ascii?Q?3etEaKJfj+cJQvAb4Jnr4MbwPpbkYetiTz5zwVMRRv1EAwx3tQmsQpYPwSSC?=
 =?us-ascii?Q?FIuliVrPCOw5szhy+W1bEmgK+fjcQe2CfRLdHmYyCrOyjO4RLk2rN4HJPfHD?=
 =?us-ascii?Q?a6kjKybQnZWezrGSJQ/mLsu9EqFXBPBFgITsQCutGVr2nINfPYSDRdWCM+7o?=
 =?us-ascii?Q?pC3BivKa1XAWKSik1lMh0XgXzMknNNYOBI8obh8qkyL52PAn7D1hHD0/E9dI?=
 =?us-ascii?Q?qFMo4d4Bpsvdat5Az3oJAaTGswfVwBw+OQ4+/tRU4HyYEsMa5+SmEWxo7Lgi?=
 =?us-ascii?Q?DxtgGmKNBGWaPvNym55Vy52KgQiz09mUXJOLoEvqXO/uXoz4n6g9g1SpUIvM?=
 =?us-ascii?Q?Hnxn71bHVymlKw0JgV4LNgd7jpOkw2oTzephGQDM?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 019cc9de-665b-4c1a-0cad-08dbcf3d56d9
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5995.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 18:17:36.1972
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0OEyi6/i6O+LRXAX+dp+WtPanpI/24pdLlIabsMjVhWR7WN2urXlBuAUsgqEU76LnxhLpkjPL0DFj9IIPKi2hw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5987
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 17 Oct 2023 11:17:48 -0700 (PDT)

On Thu, Oct 12, 2023 at 02:31:19PM +0530, Nikunj A. Dadhania wrote:
> On 10/11/2023 1:32 AM, John Allen wrote:
> > If kvm supports shadow stack, pass through shadow stack MSRs to improve
> > guest performance.
> > 
> > Signed-off-by: John Allen <john.allen@amd.com>
> > ---
> >  arch/x86/kvm/svm/svm.c | 26 ++++++++++++++++++++++++++
> >  arch/x86/kvm/svm/svm.h |  2 +-
> >  2 files changed, 27 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
> > index e435e4fbadda..984e89d7a734 100644
> > --- a/arch/x86/kvm/svm/svm.c
> > +++ b/arch/x86/kvm/svm/svm.c
> > @@ -139,6 +139,13 @@ static const struct svm_direct_access_msrs {
> >  	{ .index = X2APIC_MSR(APIC_TMICT),		.always = false },
> >  	{ .index = X2APIC_MSR(APIC_TMCCT),		.always = false },
> >  	{ .index = X2APIC_MSR(APIC_TDCR),		.always = false },
> > +	{ .index = MSR_IA32_U_CET,                      .always = false },
> > +	{ .index = MSR_IA32_S_CET,                      .always = false },
> > +	{ .index = MSR_IA32_INT_SSP_TAB,                .always = false },
> > +	{ .index = MSR_IA32_PL0_SSP,                    .always = false },
> > +	{ .index = MSR_IA32_PL1_SSP,                    .always = false },
> > +	{ .index = MSR_IA32_PL2_SSP,                    .always = false },
> > +	{ .index = MSR_IA32_PL3_SSP,                    .always = false },
> 
> First three MSRs are emulated in the patch 1, any specific reason for skipping MSR_IA32_PL[0-3]_SSP ?

I'm not sure what you mean. The PLx_SSP MSRS should be getting passed
through here unless I'm misunderstanding something.

Thanks,
John