Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Tue, 17 Oct 2023 23:42:33 +0200
From:   Alejandro Colomar <alx@kernel.org>
To:     Guillem Jover <guillem@hadrons.org>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Peter Xu <peterx@redhat.com>, linux-man@vger.kernel.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Mike Rapoport <rppt@kernel.org>
Subject: Re: [PATCH v2 4/5] ioctl_userfaultfd.2: fix / update UFFDIO_REGISTER
 error code list
Message-ID: <ZS7_yTIlIknvr7WS@debian>
References: <20231003194547.2237424-1-axelrasmussen@google.com>
 <20231003194547.2237424-5-axelrasmussen@google.com>
 <ZSMn-H_BUmJMi9La@debian>
 <ZS77PhZA9q6zQw7_@thunder.hadrons.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="qDHSbjq1ltIB8fn+"
Content-Disposition: inline
In-Reply-To: <ZS77PhZA9q6zQw7_@thunder.hadrons.org>
Precedence: bulk


--qDHSbjq1ltIB8fn+
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Tue, 17 Oct 2023 23:42:33 +0200
From: Alejandro Colomar <alx@kernel.org>
To: Guillem Jover <guillem@hadrons.org>,
	Axel Rasmussen <axelrasmussen@google.com>,
	Peter Xu <peterx@redhat.com>, linux-man@vger.kernel.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Mike Rapoport <rppt@kernel.org>
Subject: Re: [PATCH v2 4/5] ioctl_userfaultfd.2: fix / update UFFDIO_REGISTER
 error code list

Hi Guillem!

On Tue, Oct 17, 2023 at 11:23:10PM +0200, Guillem Jover wrote:
> Hi!
>=20
> On Mon, 2023-10-09 at 00:06:48 +0200, Alejandro Colomar wrote:
> > This produces some unwanted space.  Please apply the following fix to
> > your patch.
> >=20
> > diff --git a/man2/ioctl_userfaultfd.2 b/man2/ioctl_userfaultfd.2
> > index 6e954e98c..795014794 100644
> > --- a/man2/ioctl_userfaultfd.2
> > +++ b/man2/ioctl_userfaultfd.2
> > @@ -432,11 +432,11 @@ .SS UFFDIO_REGISTER
> >  no mapping exists in the given range,
> >  or the mapping that exists there is invalid
> >  (e.g. unsupported type of memory),
> > -or the range values (
> > -.I range.start
> > +or the range values
> > +.IR ( range.start
>=20
> I think you meant =C2=AB.RI=C2=BB here?

Yup!  Good catch.

Cheers,
Alex

>=20
> >  or
> > -.I range.len
> > -) are not multiples of the relevant page size,
> > +.IR range.len )
> > +are not multiples of the relevant page size,
> >  or
> >  .I range.len
> >  is zero.
> >=20
>=20
> Regards,
> Guillem

--=20
<https://www.alejandro-colomar.es/>

--qDHSbjq1ltIB8fn+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE6jqH8KTroDDkXfJAnowa+77/2zIFAmUu/8kACgkQnowa+77/
2zIIsQ//dTvOtN/wns4bqPazY5U/kGVNLe9Skp5b8vVRVSvVQyevS80tzbOQsAJ/
pMyqAyg+SV/ou1VyPrnhKoUkCm6fJUPA1PCG164hbkgND64PKSSkU6fpZW58ZmTi
XQyq+DasxjEwlqbSCTRPUqslpugmNuaOVwtmDT3ggFoFHnwEmGNKmjvYBqWrM+S9
6MpJdh5JaIJGF+MY3rcgwCfwYuO8Jr5UFXV8YWCZqK8gdJT/70l0p6orptFmcMt5
dpqU6oBslTq3Ho01yTMyn4pVsEnHzPMg6nM4cXzOFI+gJPn/4SGe1PCq1YlCppOJ
sZlEo7+GEzSUBq+wXF99mhI17qWgdq1IxFRy/Srb8/egwhBhVFjsiFBK9AgKD+O7
/MvOHXwafDDxvtz4xA6mBCSCjb9a6OeuxWAWRTi693nDQxe6zHuIqABz13VPYWKW
X01HIgzMN5FRHmKJ/1IRy9cNCh0mRHJaTO6ICbVH6/HXUX+SOTxtKA47dv73kSf3
8NftmUXKYO8h4zbaDBx7sU5ZXa0G8rSKPJTQ6sZbdwdeejX95r5D9YJ1n8CSxu5t
YQzktCzPQu4yLKxzFjni5lJ4r0bxOcQzC6EKOclISGkymAv5hAWE4DozQvX+AkXl
q8/lvUylvTTn49undQUQP4MgzRvEtEGfE6RV0YD+9Dk6TVkGMOo=
=C6aY
-----END PGP SIGNATURE-----

--qDHSbjq1ltIB8fn+--