Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755540AbXKSDFB (ORCPT ); Sun, 18 Nov 2007 22:05:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753443AbXKSDEy (ORCPT ); Sun, 18 Nov 2007 22:04:54 -0500 Received: from netrider.rowland.org ([192.131.102.5]:3145 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753439AbXKSDEy (ORCPT ); Sun, 18 Nov 2007 22:04:54 -0500 Date: Sun, 18 Nov 2007 22:04:52 -0500 (EST) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Jiri Slaby cc: "Rafael J. Wysocki" , Andrew Morton , Greg KH , Kernel development list , Linux-pm mailing list , , Subject: Re: broken suspend [Was: 2.6.24-rc2-mm1] In-Reply-To: <4740BC36.2070200@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1155 Lines: 27 On Sun, 18 Nov 2007, Jiri Slaby wrote: > > gives coretemp_cpu_callback -> coretemp_device_remove -> > > platform_device_unregister, so coretemp seems to be what I have and you don't. Yes. For the coretemp developers: coretemp_cpu_callback() needs to be more careful about what it does. During a system sleep transition (suspend, hibernate, resume) it isn't possible to register or unregister a device. Attempts to register will fail and attempts to unregister will block until the system sleep is over -- and for this callback that means hanging. It's not clear what the best way is to fix this. Perhaps the CPU notification should be sent along with a special flag indicating that the CPU transition is part of a system sleep (although this seems racy). Perhaps the driver should notice when a system sleep begins, and defer all CPU-change handling until after the sleep is over. Alan Stern - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/