Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3508452rdg; Tue, 17 Oct 2023 18:20:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE8p+PYUGGxRw16KnX8GwCpeGozPGz1MPn5TP1cHvzZU2OjL5+7LyszGLHy+W9cLJdhMv5W X-Received: by 2002:a05:6870:b18:b0:1e9:b2e2:8754 with SMTP id lh24-20020a0568700b1800b001e9b2e28754mr4021331oab.2.1697592030111; Tue, 17 Oct 2023 18:20:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697592030; cv=none; d=google.com; s=arc-20160816; b=n+6Xr58Z1+N0TQldb6UfiTZpQNu3aa1tkLMFgLU5lYot9cFnJrpRZtsP+15Fd6TS7f 0b6PCAVK6wxRUQxPnSAQZJYx35mBdz/63+NwpnSVoMIrfeoOATIlbJ5dBrkb5Cg7vPBI 8IuDlLzyZAa+ETilVht58VUDRdVa2Z9eUKflMZ3dEP+FXbxzsVQnTVYm6mwDEqoQOJas LUzlOSv4PqCM5KPr7pSPPcf8iFOHzwgGf4ap/I3jtxCMoNSZLAB0XYdFDkwEH8REQvqq nyl8JPiFGoZOhMvNt210T8iC3G4YbqslQD/Tfi9beZzzCi7bpJM8gEPCBHRDGMK3vVMX mn8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=QVNQwJqZ7a/tcPAE7NxG1cYm6HKx2wXt+3e2ayU7Mps=; fh=sruJzlstcBKq6fn6EPcWVsZ5cu26c7abofQCrf1hHUQ=; b=kQBL+JUgyhemK+JBG0jeNMbrGT8amVbJdDHpi3yCroWL0HfIlOX/z3ukRyBs6jy4R6 F/nUk7G3MRepWCSxtUw5q8PlBwPl/edxyaW2yzPLgEMjWig0f25y9p5TrZjaFItd8WUp xlJS+ayVXNchH+7JeH7m0Z17XOo5ApYAGb+awQE08/4pMSjpzgK1swc3Eo9SfFLWANoJ 3ziy0qn6DiWmFEbLaZ9rt1Dzqld7uozfiDqAQGn7Q8cOKLDapCRPaPWuUkVjBd4WnfgT ohSJzwTkYZyfOKlA8UlXsPMXnEOIBrD0X7A0FNk+2hJ+Cb0hXJ5xO9WQ3NVAQSzTVGdT OesQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QcqGpRx3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id cb15-20020a056a02070f00b005aa45782ef5si1274194pgb.337.2023.10.17.18.20.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 18:20:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QcqGpRx3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 08928802CFA6; Tue, 17 Oct 2023 18:20:28 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344329AbjJRBUH (ORCPT + 99 others); Tue, 17 Oct 2023 21:20:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229451AbjJRBUG (ORCPT ); Tue, 17 Oct 2023 21:20:06 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEA8EF7 for ; Tue, 17 Oct 2023 18:20:04 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 480CEC433CA; Wed, 18 Oct 2023 01:20:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697592004; bh=4EUpHRPi3sFqaSYjaI49krLGltGU968DKkzms82feiw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QcqGpRx3+kcTLTVNI7lD/dxyFo/BXM4Av6Z1cTZ3c9AIu9ZRpvxOVmmPVbxbndYNa n/BB4SRL5Ks4vF6dnAAZv3OLPJCWfEW+2DDp4LGH1eUUP7v7I0mmGlAYNoq5aCeVnD vK7FBgGVwnYqPLQOKccPTZcUWiLm1LS/j0GPZPugJ/73KUNIF9K6Rnd8pUi5tTqDXZ fUGWDbA7MIHCvT7spPIgT3AP0J9rIE4Z4CxdCdD1R4DPRET0HasrVnmE27LEgMac6b Lwy+++ghCKIRq+7DdAS0hy7YYswGeenzZ+/Dxcyx0wJOLO07PZEjNz2sDYDH2oIu5o ZmBk9FoRZfrgg== Date: Tue, 17 Oct 2023 18:20:02 -0700 From: Jakub Kicinski To: Przemek Kitszel Cc: Jiri Pirko , netdev@vger.kernel.org, "David S . Miller" , Eric Dumazet , Paolo Abeni , Shannon Nelson , Michael Chan , Cai Huoqing , George Cherian , Danielle Ratson , Moshe Shemesh , Saeed Mahameed , Ariel Elior , Manish Chopra , Igor Russkikh , Coiby Xu , Brett Creeley , Sunil Goutham , Linu Cherian , Geetha sowjanya , Jerin Jacob , hariprasad , Subbaraya Sundeep , Ido Schimmel , Petr Machata , Eran Ben Elisha , Aya Levin , Leon Romanovsky , linux-kernel@vger.kernel.org, Jesse Brandeburg Subject: Re: [PATCH net-next v2 02/11] netdevsim: devlink health: use retained error fmsg API Message-ID: <20231017182002.716ae87b@kernel.org> In-Reply-To: <20231017105341.415466-3-przemyslaw.kitszel@intel.com> References: <20231017105341.415466-1-przemyslaw.kitszel@intel.com> <20231017105341.415466-3-przemyslaw.kitszel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 17 Oct 2023 18:20:28 -0700 (PDT) On Tue, 17 Oct 2023 12:53:32 +0200 Przemek Kitszel wrote: > Drop unneeded error checking. > > devlink_fmsg_*() family of functions is now retaining errors, > so there is no need to check for them after each call. > > Reviewed-by: Jesse Brandeburg > Signed-off-by: Przemek Kitszel Reviewed-by: Jakub Kicinski