Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   zhujun2 <zhujun2@cmss.chinamobile.com>
To:     skhan@linuxfoundation.org
Cc:     linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        shuah@kernel.org, zhujun2@cmss.chinamobile.com
Subject: [PATCH] selftests/efivarfs: create-read: fix a resource leak
Date:   Tue, 17 Oct 2023 18:59:21 -0700
Message-Id: <20231018015921.16890-1-zhujun2@cmss.chinamobile.com>
In-Reply-To: <2a96e3a8-48a5-46ae-9a0c-b5f2def0a257@linuxfoundation.org>
References: <2a96e3a8-48a5-46ae-9a0c-b5f2def0a257@linuxfoundation.org>
Precedence: bulk

The opened file should be closed in main(), otherwise resource
leak will occur that this problem was discovered by code reading

Signed-off-by: zhujun2 <zhujun2@cmss.chinamobile.com>
---
 tools/testing/selftests/efivarfs/create-read.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/efivarfs/create-read.c b/tools/testing/selftests/efivarfs/create-read.c
index 9674a1939..7bc7af4eb 100644
--- a/tools/testing/selftests/efivarfs/create-read.c
+++ b/tools/testing/selftests/efivarfs/create-read.c
@@ -32,8 +32,10 @@ int main(int argc, char **argv)
 	rc = read(fd, buf, sizeof(buf));
 	if (rc != 0) {
 		fprintf(stderr, "Reading a new var should return EOF\n");
+		close(fd);
 		return EXIT_FAILURE;
 	}
 
+	close(fd);
 	return EXIT_SUCCESS;
 }
-- 
2.17.1