Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3531721rdg; Tue, 17 Oct 2023 19:36:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHyat9ApeUMtQIKhM3m3d2GKTYIUMa2dBZeLLh717wwqxGgvjd0cmmkMzDzUasaG2KQxWvF X-Received: by 2002:a17:903:1c1:b0:1b8:a19e:a3d3 with SMTP id e1-20020a17090301c100b001b8a19ea3d3mr4462372plh.52.1697596598833; Tue, 17 Oct 2023 19:36:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697596598; cv=none; d=google.com; s=arc-20160816; b=jDCcBmI2A9/ti+S4gq5FKpijWScSpsMAwN5MRFs3Q/mwW5u9ZXpt74BJTapWIUXU9g iVrgOmynqctfgmtEp0IWgZQcnEhl5H5cNP0kwoh4MpP34Itdb/YAZNifueoDVu5OIrEL V/UG3QOYZlSRo4g9bz0PC8+FUJNcvlC5a5YATXuK9NrbkyiJY9zYFzUQF3epXTqd1dTO 7i37ACuuFIW93D+Bk301t9PvE12Z58PDcBECU3dPJ2btHihvFM18z7sVchiPfIvp/XFE BMXKnehuYLTt+iQ6Jne0g6mK/bOWk93rL9se8wDSfgfaixmXLmFN03EBWDXqc7ixFq6B +wmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:cc:user-agent:mime-version :date:message-id:dkim-signature; bh=qAsqCySP1xPuDyaG6+jAnZQYD37eye7rcWsdeW4wC0k=; fh=W9BjRe2lrUZ6vqOTspQELs4Dft+ojYxN3vlPIcaYUg8=; b=mGnECpZAxu+h7vxYa4qB/7o8VXckhWHVwrhzzPjnED/CJZEN1UBs1aDffPyAIAFhf3 BHFwP+idKdGrPFGbU0BkorKAkKnXyLzJJPkoJ7flA6Qapc8R0U/CkJSf2gmBVgWeHsdM F18kfG0iQDHwEN/zjW5AxhU1aMVULARHfsDpVu6igMLf0ToCr/7G8F6mqV+AKuqPRXBc AwapIP0CoZs1HoVbRpAzL6+K3djs46G41cB7YYVGNJVXkKGN4hysufkixOBR409KWHKt pP0n31nvreDY76sqwlg2c+sZtR8mrrmNHpk8b7dVw42ulR7VyF+8x4gN552z+qRQ2Drz iKeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=MqFVRTH6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id b11-20020a170902bd4b00b001b8ba81d04dsi2974646plx.395.2023.10.17.19.36.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 19:36:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=MqFVRTH6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 1CDB280557D3; Tue, 17 Oct 2023 19:36:32 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229480AbjJRCgP (ORCPT + 99 others); Tue, 17 Oct 2023 22:36:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229458AbjJRCgN (ORCPT ); Tue, 17 Oct 2023 22:36:13 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95093F7; Tue, 17 Oct 2023 19:36:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697596571; x=1729132571; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=qAsqCySP1xPuDyaG6+jAnZQYD37eye7rcWsdeW4wC0k=; b=MqFVRTH6uIDnL/q4bSRcHmYShdra4vsaYW3pocM4Dpp7OginhyF3K3+C UuYXSY+/OASIL0a9Po+5Wu6Y0YktBE52VJ/OWe6b4T3OMOuE8wfek0lOO 4RM1mgVzHjwZedDHlfPErGwGlw5dnT6kc8iYr3EoiC6U0GPqnqidXeqT3 w6vZjGKUVk8wTqv65Vs9TQi5ujYwA1Qw3FrL+s8M6rkhECYEkrI3dOVkR h/AdD9iPYj+PO87ufNqTlV59YO6DH6ldpVwuuutYfyPS8gHjMyxULcG65 1WhO/S8kJPZxKc3VCmZwJXOqOXjmwbj8goP73oKhwJuyDuEUa48vg5xtO w==; X-IronPort-AV: E=McAfee;i="6600,9927,10866"; a="450144277" X-IronPort-AV: E=Sophos;i="6.03,233,1694761200"; d="scan'208";a="450144277" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2023 19:36:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,233,1694761200"; d="scan'208";a="4163967" Received: from allen-box.sh.intel.com (HELO [10.239.159.127]) ([10.239.159.127]) by orviesa001.jf.intel.com with ESMTP; 17 Oct 2023 19:34:59 -0700 Message-ID: <350f8544-8967-4f9e-bdcc-a464cdeadeea@linux.intel.com> Date: Wed, 18 Oct 2023 10:32:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: baolu.lu@linux.intel.com, Nicolin Chen , "Liu, Yi L" , "joro@8bytes.org" , "alex.williamson@redhat.com" , "robin.murphy@arm.com" , "cohuck@redhat.com" , "eric.auger@redhat.com" , "kvm@vger.kernel.org" , "mjrosato@linux.ibm.com" , "chao.p.peng@linux.intel.com" , "yi.y.sun@linux.intel.com" , "peterx@redhat.com" , "jasowang@redhat.com" , "shameerali.kolothum.thodi@huawei.com" , "lulu@redhat.com" , "suravee.suthikulpanit@amd.com" , "iommu@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "Duan, Zhenzhong" , "Martins, Joao" Subject: Re: [PATCH v4 08/17] iommufd: Always setup MSI and anforce cc on kernel-managed domains Content-Language: en-US To: "Tian, Kevin" , Jason Gunthorpe References: <20230921075138.124099-1-yi.l.liu@intel.com> <20230921075138.124099-9-yi.l.liu@intel.com> <20231016115736.GP3952@nvidia.com> From: Baolu Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 17 Oct 2023 19:36:32 -0700 (PDT) On 10/17/23 4:52 PM, Tian, Kevin wrote: >>> another problem is that intel_iommu_enforce_cache_coherency() >>> doesn't update existing entries. It only sets a domain flag to affect >>> future mappings. so it means the 2nd idev is also broken. >> This is such a gap, intel driver should not permit that. > yes. @Baolu, can you add a fix? Sure thing! Best regards, baolu