Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Tue, 17 Oct 2023 19:43:32 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Ira Weiny <ira.weiny@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
CC:     Yazen Ghannam <yazen.ghannam@amd.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Dave Jiang <dave.jiang@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ard Biesheuvel" <ardb@kernel.org>, <linux-efi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        Ira Weiny <ira.weiny@intel.com>
Subject: Re: [PATCH RFC 1/2] firmware/efi: Process CXL Component Events
Message-ID: <652f465489b2b_2bb5d829431@iweiny-mobl.notmuch>
References: <20230601-cxl-cper-v1-0-99ba43f8f770@intel.com>
 <20230601-cxl-cper-v1-1-99ba43f8f770@intel.com>
 <652f4505231c7_2bb07d29483@iweiny-mobl.notmuch>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <652f4505231c7_2bb07d29483@iweiny-mobl.notmuch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PpiAdr1kHNumXpvNMxvf6ltoYKZd9LtTXfZuaM6VjWNjqYoR2nlPQCpy/17c?=
 =?us-ascii?Q?Ysttt8sxePG8YXgixeIHZVavuY3cf1NJqb/gkLCOqOyJwohhUm8kGDUEHWi8?=
 =?us-ascii?Q?o9r1tQA4tsjPo7maSg8GiEIqIHgVC37Y+jTzBkLhpUnQCWxUfN4cjFfcfP7R?=
 =?us-ascii?Q?Z+9hPzS14bU3j147N4GOPd0oRJ3yB7kQ2VzK9zrI9/bKrxgvG6Z+QYr7w1zl?=
 =?us-ascii?Q?OTajPJIs0hE2Gg4MSx9tMR1f4xkq56h3MpOqeUVcLCS3L0Fhuqokrkf0zjIF?=
 =?us-ascii?Q?jEZ2jEo0Zr+KtMC+W90VVRg/2801vnNBT3jM1ziWiETv70oDOsbaAUJ/bj84?=
 =?us-ascii?Q?IPJCNuriXJMWL/ox0DbjkbTT0KsGnINxmS1MJAJeYTDrrK2Fwnx8trf9SZKt?=
 =?us-ascii?Q?QoOKOM2R7cIk9mR4BMjelyhZzhmA/NjrKFrm1ui3wl9W4fXEXbdZZ8WgBUd+?=
 =?us-ascii?Q?Rn5HUYQbH37gkboOspimiATtl8WCv7evlBaIz5a3WRzclKpQvMTHDkTfOsCG?=
 =?us-ascii?Q?X6nU0fmxdsNUIyY5H60daf62P7AfGGNA/Y/1kqosRESZI0coRRzi02UBmv5u?=
 =?us-ascii?Q?pltzqFPxof/N734fyWeoqPWBS8qkEjlb2qSXT83yJ9hAeNjnVU2JJ1HX7QYM?=
 =?us-ascii?Q?1dsCEgTvXGWC3ZHKfDogH5wFmMBbZMUhy+N+EL+nZlPy+4UHvniTz/0cJC24?=
 =?us-ascii?Q?POawL/r0fZcaBg2Dv7++65l3567hbO/gx+uPEWDtjpUzFpeTwi/EFSOzgC/C?=
 =?us-ascii?Q?yn8oLOTO8/gtUfP2HLPm+pB9UaAeohAy0Xs/mfzS/JiqKMVG6mYmFUHfTkl8?=
 =?us-ascii?Q?8iWIXChCEQhYmVDTw1v0ZTcWjmicNR/YzZ1yOQpgCwVDxN8mYZXyHRd+HIPv?=
 =?us-ascii?Q?KbtJ96VyKOgvWCG8J0Wldebo87j/Mfjzx/FgeH2ODyu3gsFiJNFbBup2Z/Mw?=
 =?us-ascii?Q?njhbOqWmxjFoZ8SzjWn0GAH2QNQhT1tYaPwU+9i9W5+dgkoL2484c+KrDcc8?=
 =?us-ascii?Q?iQ7rS92eOe3O145RrX90vtL2hkkb25MELpM3LNusAOQ2l0jZOnXE7eK6xEnf?=
 =?us-ascii?Q?km0PJKR0FU6MkYX5f9utp3cGVNBzOIefl8IKd/ae1C6/77ZmjL2kma6twG6o?=
 =?us-ascii?Q?2KJZ67dodebnrLyp7K8hdJzaeE5Rs7aZ/Cd0MJdpTzSlKsc/Cr1QDeJDs68g?=
 =?us-ascii?Q?XaQvg8WjB95GQbMq7whDRHyWhDb3U4/QxwizzYhOt8jBfxVPsPMV98KKrN0o?=
 =?us-ascii?Q?GfLrj51Txcrq51jnmEcU1MBewxmZdlhiKFGikQjqlmI9jMRI+vf6I6xxXbCN?=
 =?us-ascii?Q?g3bddtDV0aIL0JfU3Q2I7ax1SwWazUpGCJ2lIjFt1VsIqIqNQZ4IlsklyzXt?=
 =?us-ascii?Q?wTUT1qAD23w7JDvNOnKpgvyZyW9oyJ7ycbIZ9agm3D4Y4vBv9yGUKFPqg+Bm?=
 =?us-ascii?Q?1ee/GCUSQosHIB5oYjX5HCgHoydCLbz09uuTSIHc2h/ef4+MC3r8xYk1EGJF?=
 =?us-ascii?Q?JUGWpD1XlBmriJ5+34Hqme93j25c9h7w8l7OpG0vn/eoaF/mS8Oy58yAHoVb?=
 =?us-ascii?Q?dMS5yZfrqP7oauIyZQJK93WdxtSwXJw+mbgjO/2q?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bf781bf1-7273-4736-db0c-08dbcf84060f
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 02:43:34.8728
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DMpObOHReu7Nxh5f3PJKpDZ87Jk81XHW7d+ajbOpVFkcLAbpitzHI69V9mQDEUndVpVeL/oEO3poenlfiYezyA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4843
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 17 Oct 2023 19:43:53 -0700 (PDT)

Ira Weiny wrote:
> Ira Weiny wrote:

[snip]

> > 
> > diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c
> > index 35c37f667781..af2c59f5e21d 100644
> > --- a/drivers/firmware/efi/cper.c
> > +++ b/drivers/firmware/efi/cper.c
> > @@ -607,6 +607,22 @@ cper_estatus_print_section(const char *pfx, struct acpi_hest_generic_data *gdata
> >  			cper_print_prot_err(newpfx, prot_err);
> >  		else
> >  			goto err_section_too_small;
> > +	} else if (guid_equal(sec_type, &gen_media_event_guid) ||
> > +		   guid_equal(sec_type, &dram_event_guid) ||
> > +		   guid_equal(sec_type, &mem_mod_event_guid)) {
> > +		struct cper_cxl_event_rec *rec = acpi_hest_get_payload(gdata);
> > +
> 
> Smita,
> 
> Dan and I were discussing the processing of these GUIDs vs the UUIDs in the
> trace prints offline.
> 
> Here we could separate out the comparisons and use a token for the events
> rather than passing the guid through to be converted into a uuid...
> 

Sorry I hit send too soon...  Please see my other post.

Ira

[snip]