Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3552306rdg; Tue, 17 Oct 2023 20:47:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEJP38Yzl9Mp1jk9g9D/mA1VvIIFQkzaG4C567QLHgXeNkpIehBwHYCveAgamO21XK6qC8y X-Received: by 2002:a05:6a00:710:b0:6b3:81ee:9bc with SMTP id 16-20020a056a00071000b006b381ee09bcmr3236347pfl.27.1697600860602; Tue, 17 Oct 2023 20:47:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697600860; cv=none; d=google.com; s=arc-20160816; b=BJJJoEs8AQkGn/UfoqWQpXrTSydGLmKnOGeNeQj1k/J0PvTEMoXuehVkTuRrMAsbMk GbOns2/vOdre9vboZqIeYv/n4DRiAQEeCkzCp3RFQNfFk8FrSJS4b/4S9m/rJg+IEZ/3 Gug/Y+zbiDstS5LG4JHcI/rd7rSp1fsYrgDn6uhHNHQ3OJPRS3IZnzxtIAl2Bwl8HvSJ DcgcO3U5wN/rA9jItySOgpd0b4UVfmUCk73DYR7yBWb9eEjvuVYbtG/kvt2J+L9JtC6+ 7iSTbE2ggQfuU9AXTBKjlCU2mUkL9PQvabajfuqbILU3tkE/PTHE125Z8e3jgUwl+SYs 4KlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=cY/ifqdFG0hWG2dbPRr7D9754cPp8qthMmIIOFKubbs=; fh=mddH5f0Zj6IsQLj3PtfDtrTpQjMKpQTqB5mDKyU5h1U=; b=zXKlD8gJHkibHxupZ8yf/4NxKEiUu0Q3B0M5NvziLme/MuDxnHHVosMX8GFjGvNX+z TTQ48WAXJWvyQ4bZTRaoyw7iAVGms7Ns0058m1JnthjRXoO2Z0sLoA6CQawzdrBBbTPB N/UemuuME/M71jDafl58nxYmqtclInB+wgigUk2ibD0CptXq0OJs/3l+kEbOy9FDx/6y NeKuj5VBhvnqT+b99Jpqf0PZIcXMkbGOhJVDXKCo/SjEDxfj3M52cmLT0L8oc056Fd/X cZ5osXz42hWurI5hHA0uzDkA+ci4yh9b6YD6b9iGaZ+g2Kb5hmhGwANlpn75rSsDYxC/ T0hw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Ig+Y9OVx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id z16-20020a656650000000b005aba83e3975si1113815pgv.661.2023.10.17.20.47.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 20:47:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Ig+Y9OVx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 86872810673D; Tue, 17 Oct 2023 20:47:39 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229499AbjJRDri (ORCPT + 99 others); Tue, 17 Oct 2023 23:47:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbjJRDrh (ORCPT ); Tue, 17 Oct 2023 23:47:37 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13ADFBA; Tue, 17 Oct 2023 20:47:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697600856; x=1729136856; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=F7Gn0MmSHeTiOqqQ9clV0dh8Uz4Z4+ngsz52tZ/iPzE=; b=Ig+Y9OVx8Ps8+lE/6vZLEY73nr8qiAd5GWgBxW7pe+KHtHZ3H/ZkdEvz G3qo8F937nHHVPJ6IRolFY9BT7HJm2OA5SbSHWX/QZAYcHY5fMprAq0R0 vN8Pfuod+F62nCy94z6FBOkxosYUO9e6y9Yyjp00FEiAYXhyJ2l0g5h9D nzNo/88NWip9IDTY8encCOWyQxGNbZmeJhB2P7usNc1OQhG/OGa8eTKEX 6L8LdPAVWbpEJ0avYkfhe7WNYsVTfq0b8Ws6RPD5wNNXCHzgdlK7+bkx+ N29wQPjPyI4zmsXuXWlQMwL0KNRsz2Y5401WRx3KXsGhN4A8BJsP/a9it w==; X-IronPort-AV: E=McAfee;i="6600,9927,10866"; a="370992465" X-IronPort-AV: E=Sophos;i="6.03,234,1694761200"; d="scan'208";a="370992465" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2023 20:47:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10866"; a="900157327" X-IronPort-AV: E=Sophos;i="6.03,234,1694761200"; d="scan'208";a="900157327" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 17 Oct 2023 20:45:24 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 6CE4A130; Wed, 18 Oct 2023 06:47:26 +0300 (EEST) From: Andy Shevchenko To: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Helge Deller , Andy Shevchenko Subject: [PATCH v1 1/1] fbdev: omapfb: Replace custom memparse() implementation Date: Wed, 18 Oct 2023 06:47:25 +0300 Message-Id: <20231018034725.1124006-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 17 Oct 2023 20:47:39 -0700 (PDT) Our library has memparse() for parsing numbers with respective suffixes suitable for memory sizes. Use it instead of custom implementation. Signed-off-by: Andy Shevchenko --- drivers/video/fbdev/omap/omapfb_main.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c index 631076bf71f9..694cf6318782 100644 --- a/drivers/video/fbdev/omap/omapfb_main.c +++ b/drivers/video/fbdev/omap/omapfb_main.c @@ -1856,20 +1856,13 @@ static int __init omapfb_setup(char *options) if (!strncmp(this_opt, "accel", 5)) def_accel = 1; else if (!strncmp(this_opt, "vram:", 5)) { + unsigned long long vram; char *suffix; - unsigned long vram; - vram = (simple_strtoul(this_opt + 5, &suffix, 0)); + + vram = memparse(this_opt + 5, &suffix); switch (suffix[0]) { case '\0': break; - case 'm': - case 'M': - vram *= 1024; - fallthrough; - case 'k': - case 'K': - vram *= 1024; - break; default: pr_debug("omapfb: invalid vram suffix %c\n", suffix[0]); -- 2.40.0.1.gaa8946217a0b