Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Tue, 17 Oct 2023 21:28:13 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Michal Wilczynski <michal.wilczynski@intel.com>,
        <nvdimm@lists.linux.dev>, <linux-acpi@vger.kernel.org>,
        <dan.j.williams@intel.com>
CC:     <rafael@kernel.org>, <vishal.l.verma@intel.com>, <lenb@kernel.org>,
        <dave.jiang@intel.com>, <ira.weiny@intel.com>,
        <linux-kernel@vger.kernel.org>,
        Michal Wilczynski <michal.wilczynski@intel.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v3] ACPI: NFIT: Use cleanup.h helpers instead of devm_*()
Message-ID: <652f5eddba760_5c0d29449@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20231017082905.1673316-1-michal.wilczynski@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231017082905.1673316-1-michal.wilczynski@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/X935VZsIRSnz9GtsB1pHKm528WAxyBGGThTVZ94W4a4eXfn2oQaJA1hOaDQ?=
 =?us-ascii?Q?OUIpNIdNNd42tthSr0ZgZzlXEr0RSjHPcnmhrixb2erxaIZps/Gq6dqW65Il?=
 =?us-ascii?Q?JLyuAmL2nSInr8GSA9tpby3FFUUuuBWFYysjyA68hYliF0YPYElarCv3Q4zo?=
 =?us-ascii?Q?IgdyHyBBcTZd0hlcd9ZYXmfH9KSQwiOhd/2uf1pnHGtYO+At8AJB76qWEtVV?=
 =?us-ascii?Q?o7+NNwcWHGhwhlBJaf1aXjAn+B29i/3zlOp0dAGQSE4ovpB0Zm4Tv8HHw7HV?=
 =?us-ascii?Q?omQzR7aKG7tmETfDzw/l1uspj7GvuFv3Q+tpd64/VCrp0zZrZss+cgIv1UAU?=
 =?us-ascii?Q?TxFrn9C35jjDJKHT4fH9840nie55I1/xZKTF3oEc28Y7wbnUQIck7aGAEYyu?=
 =?us-ascii?Q?/tnrWrODEI6GCurSaQZjPpUyMA1M+HOBd/7GczYQ0WeVmdXBNesoKbWgb6+t?=
 =?us-ascii?Q?GbpBfSrhMEUkzQ6IT435pDs7y6n7CnDqdhxSMq76nsN7653n534WJULaHOh7?=
 =?us-ascii?Q?zeKmxmOzhGEWIzXAIlQXswmi/pbyHaUmlATwrW9KSKF+ekmuWV3gLenLy7OW?=
 =?us-ascii?Q?OoxsGcWO+P6qTXGtaCKpEktMRZv+5+QiEqPUSJ8IoH8YRhDt+JTFZgrZKuba?=
 =?us-ascii?Q?5zlEzIP6QMHKY/UwjhRDP5JO9FAs1vIbhzcDWdrm7kG5LASr7EcJNgS+qsoZ?=
 =?us-ascii?Q?3yrDPltMig6+W7qW56lqkVSI+cRaK/RcrOQdoQcNy440S/23bqaVkiRU30V2?=
 =?us-ascii?Q?lZnFDlw0ndw0V/z/K9/Ejl/fmm3f2/mP2E8vW94ISVAju6q0BzQYtbZQOMN7?=
 =?us-ascii?Q?Mn6jBt15Gj3ZsK5j9CzwpHfsZV/9sc9xMWu/5yg2F4y1irfovjsZJFH+soLp?=
 =?us-ascii?Q?G8INtkaDYc3viXX5MHFtOshflvj53q4wc02m9KNChqmLDGsgWbcjANe94zir?=
 =?us-ascii?Q?1vCl6CDD4wgH7e3i3YcqCtWVW52laK+1yG5ERyp0YvtWtDeFeSVBEfzVRtlC?=
 =?us-ascii?Q?RNa5K2yA0EOaA+jYYq1VVVWuV8WRBKdI7pVQuyVEYe7PIspVFTBr9YGNfmBu?=
 =?us-ascii?Q?k3W/q7+5Y+yjuPGQvqbZNjm3Wc/PK/pKCjM+BSI/oJvW0e+cd6lYApDibeDS?=
 =?us-ascii?Q?xR/gI/BiEUJng+K0ZJQsKCk1TIQU/+UJRDrUKg7a7GMCrsAKn9MkiQ4xMeEC?=
 =?us-ascii?Q?eRfpKlkxDlpEGX3Tv6cXkZ5BSr0VM737e6yGcKXHOrrTFHxDdgxSP+2N6UMV?=
 =?us-ascii?Q?Cj08BLUFTkR2bneNcLe6ZqisR6a//cJy0e2OqS4DlXC/FkMO2UuPtnHvgnXY?=
 =?us-ascii?Q?uDLwfr2m8RDtt3nG1+xaRGbRvVisrhbXUnoRVxM2/UphRz1NPQ+5IpEgyoSs?=
 =?us-ascii?Q?Qli81y8hQueFpqvRsXMoukUVZjVNOkQs+PdvDs7rCh8FyAZMseFoX1wzoSfo?=
 =?us-ascii?Q?EeXAlm9BuDhzznezq7WV73UySCaoFBj/VD9XfApG7+ozBlmTJ4DebBuYwCFa?=
 =?us-ascii?Q?l7D7mbnd3AZecuJpQ6s7EmqRLNE7BII5zY2CqNyCnEVwNMkxBH+E778neDeJ?=
 =?us-ascii?Q?AGPbWPHA6BSkC7WEKElkNKx8Apu82yK979sMWdJDFgQpxbAhS4g+rpTX6nJq?=
 =?us-ascii?Q?GA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dd9e7395-d6ac-4eb2-b32d-08dbcf92a62a
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 04:28:16.4249
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4PwPIFAk2AKCyGKJfhYVL7n+QMj8VFzag+nNz7zWmvraJcUMyN6g4Ch9wIOP5nA9e53ypXqudsNL7mXUYt4MZSIfi7UqI7Nry7PJF+rzosQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4679
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 17 Oct 2023 21:28:45 -0700 (PDT)

Michal Wilczynski wrote:
> The new cleanup.h facilities that arrived in v6.5-rc1 can replace the
> the usage of devm semantics in acpi_nfit_init_interleave_set(). That
> routine appears to only be using devm to avoid goto statements. The
> new __free() annotation at variable declaration time can achieve the same
> effect more efficiently.
> 
> There is no end user visible side effects of this patch, I was
> motivated to send this cleanup to practice using the new helpers.
> 
> Suggested-by: Dave Jiang <dave.jiang@intel.com>
> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>
> ---
> 
> Dan, would you like me to give you credit for the changelog changes
> with Co-developed-by tag ?

Nope, this looks good to me, thanks for fixing it up.

Reviewed-by: Dan Williams <dan.j.williams@intel.com>