Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3567203rdg; Tue, 17 Oct 2023 21:38:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGy2bTsfSoHsfv7pgOKZRidznVu/iDL8s6wHg6QG12U6Fizu2+Kb4AoEBxVjLh5F9TUT2kM X-Received: by 2002:a05:6808:16a6:b0:3ae:554b:6c57 with SMTP id bb38-20020a05680816a600b003ae554b6c57mr5058374oib.11.1697603893183; Tue, 17 Oct 2023 21:38:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697603893; cv=none; d=google.com; s=arc-20160816; b=jEZ+3/MFF/ylonOrLYUgDMHKfNrZ9vzA5jFyDLs6b1eBkcqr7hLPirWPscS+GcMtrt np1cd1m35Q4/3QQu+Y2bqiJ1hDm6RtoCZNJ27/KrrGPKR7CKOIbcEAfqq74ReZ5WeAgw dnY1arAEBNE4o5ULOmtbIyEJ0vHL0160PeZSLZiCk5mF6YutPlpUQlspfUSkL+bj8dsD TntEcWldSxAALUWkFlhZTwn/ohlSTrtten2t1BYdPMELLPB317N8rwWkHdhO09yNc1HT EwsSh4pPsj+IRjSQdsrkkZPgGaegdAMQAoJO1+PlvT6VbfXrynMjMo4xt801VU5W6wLw ocNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=czJuvzpZ9+G+JcIdKCv4XoL9kYRQrLLnwV3w5sOQ/X0=; fh=Jr/ZUGwuqk8r3C0qciQ38igCbjoZjzbRVHKdCQpyGnA=; b=Dq6tfrtXuFuO+ZuuQ8Vs/pW1aByWlBQso9jGTuFRutbyaf92RYSG4VtfuPF3BfA3kP TujaVeXZf4MTaIRzunL7f2z0qQGdT4+7aTG4vh1VE/x24BZ/2vB1QvOLuwYKGDbq+Sxi GqdbHeDsAzXwzmLt9tS2A2EiZHepS8MhASmTuq4dP/IsoJMc3G/Q3ipmA8+8Kf33fVCF rdcnDztWdvoAXTqbL3uj3GX2SUdh9AjYGKHr1agDEtXEIYcG5t6YkBByorrok5pvGvlZ 6wBIL3wKvHkaHkvFlwZVmrpwTiRwvd6aZHLEhQG6R0Jr3U51NZrlX+9oKinax8N6xdyh wK0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Brn4P3bX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id h64-20020a638343000000b0057c2f614756si1328737pge.212.2023.10.17.21.38.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 21:38:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Brn4P3bX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 81BB9806CC15; Tue, 17 Oct 2023 21:36:47 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229517AbjJREgk (ORCPT + 99 others); Wed, 18 Oct 2023 00:36:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbjJREgj (ORCPT ); Wed, 18 Oct 2023 00:36:39 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57453FD for ; Tue, 17 Oct 2023 21:36:37 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-6b20577ef7bso3891526b3a.3 for ; Tue, 17 Oct 2023 21:36:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697603797; x=1698208597; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=czJuvzpZ9+G+JcIdKCv4XoL9kYRQrLLnwV3w5sOQ/X0=; b=Brn4P3bX9OsSgIm6+g74fGbKFdnv088NwjjGpTIDh8Vv+hxQIike95y1F8DFbcrGEz CScgCEQHrYfkxThlhyxBsPecoeQ+lQmG/2N1Dafxsf09c8BTo3WAATlp9eUzsLQiMAxj jx9FJBRcmC17mBjqqPc7pvDUcwSWK22pjLOVdT3oCA9cxHWuGGNChtZhG/sZmYqC8Rmf D8FfGRX3ewHyB2rW0uG1WfbPegzh/tWRoWoItEOiUTJQnspfJkEz2tt3B42ryqlygDc7 N19sCe9CtfEvdFqAZhlqIFoa9BWhpcRSkE0D2zXBn8BBc5aU9zHwa1lpegue4fWmEU3R ChBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697603797; x=1698208597; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=czJuvzpZ9+G+JcIdKCv4XoL9kYRQrLLnwV3w5sOQ/X0=; b=UvlZglLWGDvk60zKqwsRbHs45n6Mg/okCZYt9nmDp+ZzeWF8a/H88i7TRq2w0o6mHX Ees+8V9K247xWitqJctmdQst1EjH43wnD6NZ4BR2/XqJ8temF/T6pl+2cnK0AuUAW80W WR897aeBhosYJbbts+BAhQItKTmXXvlWm/LS9zZDBTflRQSxWnvSmPOIQ1Rj/sQwGVev RcepOpyqAN+082m2WV3ftRywR0glaUTcmikpelhicDakly0m8iLR+Fge1HPWYApsbton QHyYYCm8NMeXO4lJOpfdQRfB2AXDQJz57NVhtQe0Lq0etOYUMBXQFeHogu4mkDS7ccwv GauQ== X-Gm-Message-State: AOJu0Yz+HNY73ttoXVxHFUL65gLDCb+VaUecD9KdFA3dd8NQdkmROBBx XCOyFutsVdYf2pvASfZgBraBBHsQHcm2ZQ== X-Received: by 2002:a05:6a20:8628:b0:14c:4dfc:9766 with SMTP id l40-20020a056a20862800b0014c4dfc9766mr3194642pze.46.1697603796723; Tue, 17 Oct 2023 21:36:36 -0700 (PDT) Received: from Negi ([68.181.16.134]) by smtp.gmail.com with ESMTPSA id ja9-20020a170902efc900b001c3267ae317sm2450863plb.165.2023.10.17.21.36.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 21:36:36 -0700 (PDT) From: Soumya Negi To: Martyn Welch , Manohar Vanga , Greg Kroah-Hartman Cc: outreachy@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Soumya Negi Subject: [PATCH 0/2] staging: vme_user: Replace printk's & cleanup log messages Date: Tue, 17 Oct 2023 21:36:31 -0700 Message-ID: X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 17 Oct 2023 21:36:47 -0700 (PDT) Staging driver vme_user has a bunch of printk() calls in vme.c which triggers checkpatch warnings. Remove all printk's and change them to the appropriate logging mechanism i.e pr_err()/pr_warn(), or dev_err()/dev_warn(). Also, cleanup the messages further by using __func__ in the string instead of function names. This patchset fixes all checkpatch warnings like: WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... & WARNING: Prefer using '"%s...", __func__' to using 'vme_lm_get', this function's name, in a string Patches must be applied in order. Soumya Negi (2): staging: vme_user: Replace printk() with pr_*(),dev_*() staging: vme_user: Use __func__ instead of function name drivers/staging/vme_user/vme.c | 175 ++++++++++++++++++--------------- 1 file changed, 94 insertions(+), 81 deletions(-) -- 2.42.0