Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <02114b35-5e71-4f97-ba2c-9277103347d5@quicinc.com>
Date:   Wed, 18 Oct 2023 10:42:02 +0530
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 4/5] misc: fastrpc: Add support to save and restore
 interrupted
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     <srinivas.kandagatla@linaro.org>, <linux-arm-msm@vger.kernel.org>,
        <ekangupt@qti.qualcomm.com>, <linux-kernel@vger.kernel.org>,
        <fastrpc.upstream@qti.qualcomm.com>
References: <1697534799-5124-1-git-send-email-quic_ekangupt@quicinc.com>
 <1697534799-5124-5-git-send-email-quic_ekangupt@quicinc.com>
 <2023101739-heftiness-reproach-ef96@gregkh>
 <d800dcbf-83dc-4b0f-bdd3-fc0efb5dd771@quicinc.com>
 <2023101743-discern-plunging-83e4@gregkh>
From:   Ekansh Gupta <quic_ekangupt@quicinc.com>
In-Reply-To: <2023101743-discern-plunging-83e4@gregkh>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/17/2023 9:40 PM, Greg KH wrote:
> On Tue, Oct 17, 2023 at 08:36:28PM +0530, Ekansh Gupta wrote:
>> On 10/17/2023 6:50 PM, Greg KH wrote:
>>> On Tue, Oct 17, 2023 at 02:56:38PM +0530, Ekansh Gupta wrote:
>>>> For any remote call, driver sends a message to DSP using RPMSG
>>>> framework. After message is sent, there is a wait on a completion
>>>> object at driver which is completed when DSP response is received.
>>>>
>>>> There is a possibility that a signal is received while waiting
>>>> causing the wait function to return -ERESTARTSYS. In this case
>>>> the context should be saved and it should get restored for the
>>>> next invocation for the thread.
>>>>
>>>> Adding changes to support saving and restoring of interrupted
>>>> fastrpc contexts.
>>>>
>>>> Signed-off-by: Ekansh Gupta <quic_ekangupt@quicinc.com>
>>>> Change-Id: Ia101acf7c1bf6018635536082bf7ea009093c948
>>>> ---
>>>> Changes in v2:
>>>>     - Fixed missing definition
>>>>     - Fixes compile time issue
>>> You forgot to run checkpatch.pl :(
>> I did run checkpatch.pl and also tried compilation test. checkpatch.pl is
>> suggesting 0 errors, 0 warning and compilation also worked without any
>> errors. I might have checked on last week's base as there were no changes in
>> these files. I'll check the patches with latest version and update again if
>> any errors/warnings are observed. Thanks for reviewing the patch. -ekansh
> The "Change-Id:" should not be there, and I thought checkpatch would
> catch that.  If not, no big deal, you should have :)

Thanks for pointing this out, Greg. I'll update this with a new patch.

>