Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3604021rdg; Tue, 17 Oct 2023 23:31:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGdeqJmLF2e3hTw5hVCfsWxZlq4DUSjTbuhE0g9ZtcZxE5luDVHcLr371mwnYJbtw2EAfNy X-Received: by 2002:a05:6a20:6a27:b0:15a:6733:24e2 with SMTP id p39-20020a056a206a2700b0015a673324e2mr6390524pzk.25.1697610675649; Tue, 17 Oct 2023 23:31:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697610675; cv=none; d=google.com; s=arc-20160816; b=gHnjz1pES17xqq8PnduKVzNqNV/5KV8ROS9EcKwFPUoLPMdNc6wF2H5kCAQlSAVB0E nRLqv3DHng/Da6m2BvAjZca9QRogBe2cIjaNMl+d5LU2OC2WTMTsviTF3e4U275S4Vwh Dvew9FpLYNN5dJEJ12ndS35CAucBRI5ccCmnVaKc5y6Fpzrz+CY51C0mZn+Yho7BdM8g pn1Q+i8y/zMg3BggcpTjcckIRXww1V8XfGPKpDlPqcTvwe7AFfwyezZNEdZGnY3iTGcv fLxf4xq4BFCVIR+zhK4moTKwn5dNdJWrtxuEd3ToHTHxqql3srsA9EpkZNrUJUjb574W NOxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Wq1vx6XteRAMCSoaO5L1p02QjavlUXvUySk+7KT64Zw=; fh=LreWToPtQw6TmByfJgiNjL4/Du+E1T9W7niaoVfZlDo=; b=r8MEPjrAPQsj4xN50JRqAQfyduTrKsNEpjoitwHr4Kg1x+0RN2Pi1sOvzNhoHEgsER gmVYZ8lNjBJWfNsr1cuGL9vRdkznOOXcB7cRJxKfNRwROEvkCvFUyG0r77/Wmw2yXKH2 zbHb6fsFGHKmugNYs6YpieqIPND3CvgMtpGXJI5gK+w3PdlfVCgYomta0EchEE1ymmn7 DBLdvsKMmUJDXmjjRaiFnBrIrr9r8ec4dJkjXM8z6MQ/YJiqQ1bqnILDfaB/RcqhGRZ7 ql5i+QwER6NZ++mvq7jqwS4XsX9/dCUrtEqpupGWzPRTZeM5GBJa9xZTsgHMJs45Xl5v 1B2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FAPf938x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id t4-20020a63f344000000b005789c7e9bf2si1439897pgj.627.2023.10.17.23.31.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 23:31:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FAPf938x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 58D8C802407E; Tue, 17 Oct 2023 23:30:34 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229716AbjJRGa2 (ORCPT + 99 others); Wed, 18 Oct 2023 02:30:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229690AbjJRGa1 (ORCPT ); Wed, 18 Oct 2023 02:30:27 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D8B9C6 for ; Tue, 17 Oct 2023 23:30:25 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2418DC433C7; Wed, 18 Oct 2023 06:30:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697610625; bh=FPTTiiZq8GxaKyzpXJmy3oyhKpmAOd1lTbVWtb7o1s0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FAPf938xwnoVZc+dHRefOzJKEVyW6XfDQkghGROfppztei7tPdv2EuzgaTMa77GHm KXc93YGZzlkV6E+dN/Dqt+vcIoVVQzj2G0v5EXKDI2mUZtlBtuVrwR5YIv+WUxzpa4 UE+wRIpNGs8JhEYi0AD+dVei+J5jOWqb2mAfBFzrysFArBlo3S2g66eevbiBKo7hUm 1EE5jguXSdVpqmjBOVLHCJkVNoAjEokJj2+Fa3oFX3IOSr2z71eDyH1ry0G/KoyNXp cpoH11dJ765ccASJ3P4MtG04P/VQ7AKRmnsnDoeucKFtciPkZ1Leb4RyBygDEJWtdJ 0oC/h7kenVl5Q== Date: Wed, 18 Oct 2023 15:30:20 +0900 From: Masami Hiramatsu (Google) To: Francis Laniel Cc: Steven Rostedt , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/1] tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols Message-Id: <20231018153020.fac28cf4381b57e179104b02@kernel.org> In-Reply-To: <2696412.mvXUDI8C0e@pwmachine> References: <20230824160859.66113-1-flaniel@linux.microsoft.com> <20230825221321.faaa33e03afc48abc345c24f@kernel.org> <20230829195719.0eaf9035@rorschach.local.home> <2696412.mvXUDI8C0e@pwmachine> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 17 Oct 2023 23:30:34 -0700 (PDT) Hi Francis, On Thu, 31 Aug 2023 09:14:55 +0200 Francis Laniel wrote: > Hi. > > Le mercredi 30 août 2023, 01:57:19 CEST Steven Rostedt a écrit : > > On Fri, 25 Aug 2023 22:13:21 +0900 > > > > Masami Hiramatsu (Google) wrote: > > > > Excellent catch! Thank you, I will apply this patch and send v4 right > > > > after. Regarding test, do you think I can add a test for the > > > > EADDRNOTAVAIL case?> > > > Hmm, in that case, you need to change something in tracefs/README so that > > > we can identify the kernel has different behavior. Or we have to change > > > this is a "Fix" for backporting. > > > > I prefer this to be a Fix and backported. > > This makes sense, I will send v5 to stable mailing list too! I missed this a while. did you send v5 ? I could not find in my mbox. Thank you, > > > Thanks, > > > > -- Steve > > Best regards. > > -- Masami Hiramatsu (Google)