Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756457AbXKSHP7 (ORCPT ); Mon, 19 Nov 2007 02:15:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752206AbXKSHPv (ORCPT ); Mon, 19 Nov 2007 02:15:51 -0500 Received: from py-out-1112.google.com ([64.233.166.183]:45940 "EHLO py-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752114AbXKSHPu (ORCPT ); Mon, 19 Nov 2007 02:15:50 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=JVIYM7dkhhtu7nPrFq8jnpQe/yjcWazTnJ+TjhTmtBeUMhuHZzVdtoscrE5bAkudtBs6sS/x0hxAqRl0kDhQYu7Ieu6OUP82ck0nDOtAPt3r5TQXJln4D8PjB/UFjQ1/vQUNRi5xuypV1HI+UH9KWCymzPpVdcUiQkWl4w5UsYc= Message-ID: <64bb37e0711182315s1d159c80h11811acb07566f03@mail.gmail.com> Date: Mon, 19 Nov 2007 08:15:48 +0100 From: "Torsten Kaiser" To: "Trond Myklebust" Subject: Re: [BUG] 2.6.24-rc2-mm1 - kernel bug on nfs v4 Cc: "Peter Zijlstra" , "Andrew Morton" , "Ingo Molnar" , "Kamalesh Babulal" , LKML , linuxppc-dev@ozlabs.org, nfs@lists.sourceforge.net, "Andy Whitcroft" , "Balbir Singh" , "Jan Blunck" , steved@redhat.com In-Reply-To: <1195413486.7893.16.camel@heimdal.trondhjem.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <473DA608.1020804@linux.vnet.ibm.com> <64bb37e0711170953p67d1be49lf4eaa190d662e2b4@mail.gmail.com> <20071117180946.GA14055@elte.hu> <20071117101957.7562639d.akpm@linux-foundation.org> <64bb37e0711171140w5f1451e0qea081a4fbc7a45f7@mail.gmail.com> <20071117230508.GB25905@dyad> <64bb37e0711181044s75fd1081sdf44dac2e060d49a@mail.gmail.com> <1195413486.7893.16.camel@heimdal.trondhjem.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1206 Lines: 29 On Nov 18, 2007 8:18 PM, Trond Myklebust wrote: > On Sun, 2007-11-18 at 19:44 +0100, Torsten Kaiser wrote: > > NFSv2/3 and NFSv4 share the same dentry_iput and so share the same > > unlink and sillyrename logic. > > But they do not share nfs_init_server()! > > > > I wonder why this doesn't blow up more violently, but only hangs... > > > > But as I don't know if it is correct to add the workqueue > > initialization to nfs4_init_server() or remove the nfs_sb_active / > > nfs_sb_deactive for the NFSv4 case, I can't offer a patch to fix this. > > > > Torsten > > I had already fixed that one in my own stack. Attached are the 3 patches > that I've got. 1 from SteveD, 2 fixes. > Moving the init_waitqueue_head() like patch linux-2.6.24-006-fix_to_fix_sillyrename_bug_on_umount.dif and applying linux-2.6.24-007-fix_nfs_free_unlinkdata.dif lets my testcase work. Also lockdep no longer complains about the non-static key. Torsten - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/