Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <1118ec6d-e1e7-79f3-08e4-9a79c996eed1@intel.com>
Date:   Wed, 18 Oct 2023 09:32:46 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] staging: rts5208: Replace delay function.
Content-Language: en-US
To:     Julia Lawall <julia.lawall@inria.fr>
CC:     kenechukwu maduechesi <maduechesik@gmail.com>,
        <outreachy@lists.linux.dev>, <shreeya.patel23498@gmail.com>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
References: <20231018004300.GA3189@ubuntu>
 <7bc719c4-459f-3d8-7ed-b1e1adf158@inria.fr>
From:   Karolina Stolarek <karolina.stolarek@intel.com>
Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298
 Gdansk - KRS 101882 - NIP 957-07-52-316
In-Reply-To: <7bc719c4-459f-3d8-7ed-b1e1adf158@inria.fr>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEZyS3NJVHYrK0hRSGFES1RFejE0M0pQMURqVzBxOXZLb0h1UjRDY3lRbTFl?=
 =?utf-8?B?Ni9uZGdyRWRlZDMxaHpKLzV2QnZkYzZUSVJuTlZpZHNJT0h2Q2IvZEhKR0JG?=
 =?utf-8?B?OCt5S1JxUUZoVG5BdFVJSVNtWGVTNVIzbDgzb2hJT1lrUno2aTBheUpFaXRn?=
 =?utf-8?B?eTEvcFIwQ0NpWUxoVzYrR0Z2TFVjdFh1VGNZTnFuV3E1VmdXbkRtdjNrN0FE?=
 =?utf-8?B?TlNwaUZ6RmJ0MXk3VTdmdi8ya1hSNFZyc200TVFjZWMvSTQyYmVEamRhQUs1?=
 =?utf-8?B?RzZnQW9sS1JCQndXOXlsYjRwNW1lS0FUSUNBeW8raklYeDhtTFZ3aUQ4dFI0?=
 =?utf-8?B?cVVvSDYzMllTNllPYjE4V1lPQ051dWgzTUdKVmM1SkRoRTFkSjRvY2JMWXJ5?=
 =?utf-8?B?RHBMdmI1YlQwbi9BQ29OUE10bkhseFJTS2JjV1NmQUJjekNCZGJiT1R2MHlw?=
 =?utf-8?B?VjhBTEI1STZmUXVrenJ4U1NVdlpIS20xdnl4SFFaZ04rV3ZDa0R1Tll3bzhR?=
 =?utf-8?B?K1NXdGpEQ2dOZkZGQVdoSVYvVWthVEk3bm9aaEFLMGcveEg5VDNzYWl6YXVv?=
 =?utf-8?B?MGRySFhjbkFoY0x3RjlNNUlzUjh4YWRGSkM0SWwvRzl0RTl2TnNwdEtsZnFP?=
 =?utf-8?B?SUJDNWMzM04yZGFGa2M3S1UrYVVtYVZqMEdtUnVaR3hPS1BtcWNPS3RGTXQ2?=
 =?utf-8?B?TktMVVJ0OWNuY2lUdm8xSkFSMHNLMk42R21Scm1hQ1N3V25ERWhGeVdqOWNZ?=
 =?utf-8?B?RjJ0aElIM0hxTUhxVGRQY0VyZytqU1NHY0JrZU1rbVlmRnpFUzdCd0NqNGhV?=
 =?utf-8?B?Z0w2a1Q4b0dOZEFRTnlsNFpNMDAwU1gzc0xNVzdHa2ZFQnpFZEo3SEl4TmdJ?=
 =?utf-8?B?MFhlZWVQZkxRNUJzMTBTNjFUNEVGQjZDblRrL2FaczlEblNVNzE3YU5JVldX?=
 =?utf-8?B?V0hoOTMrS0pZS1VTU1ZmNlIwSU91eDJrVm1WQlVyRkZKUElBRi9aRlV5aE9T?=
 =?utf-8?B?Mnk1aWVVTWVMQ2NKL3pxd240NjVNK2hmQWNrVlJqbmh4T2h5U3hJeHI0aUVa?=
 =?utf-8?B?cmIxd1N0VUIydk9BZE5pVGJ0MXdaRUNmK2UxNWd3T2ZwdlpyUzBnQUV3UU15?=
 =?utf-8?B?Q0FOb1BKcmJzWHZ0MmRqaEdHSDQ5U2w5bVZ1ZWZ5emlGRXd0RDZQTWw0VEtF?=
 =?utf-8?B?a090OVhSQmNHRUlWaTVOVTZVNkVncFF4bTRvYWN2cmFoc0tDZU1JV1YxcEta?=
 =?utf-8?B?Vko5QkY5dTZJUHhOV1picmpGNkhoUGoycXdGMWNEWjE0MVRwNnVlM3MvQTU3?=
 =?utf-8?B?emxVSlBmVHY4YXZmSXk2c0l1dDErS0tkSXl0RzFxSWxrcEZ5YW9vV1g0YVI0?=
 =?utf-8?B?MGtzT3lzRlQ1K1hEalduU1E0V2Q1TXN2cUdMV1Z3Nmpyd2J2T0lOU2t0bVpV?=
 =?utf-8?B?cG5hT0pDSWJQTmZMSE1mSFBUQkdNbEJuaWlSNW1CblhuOFpHNDJaNThFQWhh?=
 =?utf-8?B?QVBRUHBqcjZBUjZpbWl6K2ljQ2Q2OVFWWm1pVXR0MGdVcEh1YS96YWFJbFBN?=
 =?utf-8?B?SGUxbzBFZUd4dlVYSDB1bGZ6bUJ3QVpmQmdLcVRrUG5lZG52dnQrM081dy9y?=
 =?utf-8?B?YS9PTWx0ZnA2d1MyYlpUK2hqMmdzQTk1bzFKbnp2a2REMGd5cUROSXUxeEJ5?=
 =?utf-8?B?RE1wWjlrOHNhN245V21mRzB3VEJYYjJlNm10YmVMdjh0ditKemtGYm02SVAr?=
 =?utf-8?B?QWRpa3ZaYjd3QlR3WlNaVHkyd0hzWWRDbzByNUZDU1UwTmJvUm5jZVpabHRw?=
 =?utf-8?B?N1BxbE1kaDBLSjQ3SzBvdTJ1YUtEM3ZYUzFqcGsvT2Q1NWJaandKQnlXQzdr?=
 =?utf-8?B?QWZoVEpMWGRsRnNSdEx2aHdMcEdEdlVydGF0bEUxNXRmYlNvRzVPZ0dxOVpo?=
 =?utf-8?B?dWhNYnduWHNwMURReVRZUGtoTStteVBIRXR4YzVmSHFGUW5wdkVqOWh1WmhM?=
 =?utf-8?B?WUxieFh4dUxYU1VQQkZJQ3cvOHBXbzJWeGk5ejgzMmpVTS9Nam9RTEZnaDU3?=
 =?utf-8?B?UFhFTWF1MTh2blRHQkRCdm1EOFVyUjZRS3pDZnVjQzVxbUVFZ0EvRDVPbk9I?=
 =?utf-8?B?OXFIaEJHc0lETURpU3ZrVzRybVZWVkFwSXpYejZmbk1MTjNYTkZDOXdwamdy?=
 =?utf-8?B?QXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e035b6b-6e23-40af-3865-08dbcfac698e
X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4243.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 07:32:41.9713
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F+ARoHBBmAJ9eryE8Mqef/nq66P/K4LCBkxjgW0no198+DzosDpNBNYLjpTiuUDJxaRumToy4hGeTrrijRsykLHV8hEIucYuh+HM+ImxabQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5016
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 18 Oct 2023 00:33:08 -0700 (PDT)

On 18.10.2023 09:03, Julia Lawall wrote:
> 
> 
> On Tue, 17 Oct 2023, kenechukwu maduechesi wrote:
> 
>> Replace udelay() with usleep_range() for more precise delay handling.
>>
>> Reported by checkpatch:
>>
>> CHECK: usleep_range is preferred over udelay
> 
> This message is typically not a good candidate for outreachy patches,
> because you need access to the device to be sure that any change is
> correct.

Could we add a paragraph on how to pick good checkpatch.pl error to fix 
to the Outreachyfirstpatch docs? This could go to "Find a driver to 
clean up" section, for example.

All the best,
Karolina

> 
> julia
> 
>>
>> Signed-off-by: kenechukwu maduechesi <maduechesik@gmail.com>
>> ---
>>   drivers/staging/rts5208/sd.c | 10 +++++-----
>>   1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c
>> index 74c4f476b3a4..059f99b0a727 100644
>> --- a/drivers/staging/rts5208/sd.c
>> +++ b/drivers/staging/rts5208/sd.c
>> @@ -865,7 +865,7 @@ static int sd_change_phase(struct rtsx_chip *chip, u8 sample_point, u8 tune_dir)
>>   						     PHASE_CHANGE);
>>   			if (retval)
>>   				return retval;
>> -			udelay(50);
>> +			usleep_range(50);
>>   			retval = rtsx_write_register(chip, SD_VP_CTL, 0xFF,
>>   						     PHASE_CHANGE |
>>   						     PHASE_NOT_RESET |
>> @@ -877,14 +877,14 @@ static int sd_change_phase(struct rtsx_chip *chip, u8 sample_point, u8 tune_dir)
>>   						     CHANGE_CLK, CHANGE_CLK);
>>   			if (retval)
>>   				return retval;
>> -			udelay(50);
>> +			usleep_range(50);
>>   			retval = rtsx_write_register(chip, SD_VP_CTL, 0xFF,
>>   						     PHASE_NOT_RESET |
>>   						     sample_point);
>>   			if (retval)
>>   				return retval;
>>   		}
>> -		udelay(100);
>> +		usleep_range(100);
>>
>>   		rtsx_init_cmd(chip);
>>   		rtsx_add_cmd(chip, WRITE_REG_CMD, SD_DCMPS_CTL, DCMPS_CHANGE,
>> @@ -918,7 +918,7 @@ static int sd_change_phase(struct rtsx_chip *chip, u8 sample_point, u8 tune_dir)
>>   				return retval;
>>   		}
>>
>> -		udelay(50);
>> +		usleep_range(50);
>>   	}
>>
>>   	retval = rtsx_write_register(chip, SD_CFG1, SD_ASYNC_FIFO_NOT_RST, 0);
>> @@ -1416,7 +1416,7 @@ static int sd_wait_data_idle(struct rtsx_chip *chip)
>>   			retval = STATUS_SUCCESS;
>>   			break;
>>   		}
>> -		udelay(100);
>> +		usleep_range(100);
>>   	}
>>   	dev_dbg(rtsx_dev(chip), "SD_DATA_STATE: 0x%02x\n", val);
>>
>> --
>> 2.25.1
>>
>>
>>
>