Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3627932rdg; Wed, 18 Oct 2023 00:37:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFDELDN9tytbzGLZj3tE73XfthVwEEVWYHaGjQ4sGAKzb6OS+VHZSees2vAB8O2Z0tDgymA X-Received: by 2002:a05:6a21:7985:b0:15c:cb69:8e64 with SMTP id bh5-20020a056a21798500b0015ccb698e64mr4263866pzc.25.1697614672139; Wed, 18 Oct 2023 00:37:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697614672; cv=none; d=google.com; s=arc-20160816; b=bw4AwNotc9azXOnFGiChkPVurqT0TWJq4FRp/COfhyKHtiOT1CG0URz8FHjBk+zR8L i6/W/UTd0MYUWY/Br7lFoOaz+xC//JPernTfCbLdhHsFu7uoC8VJe/kENjqPfmpFr0Bp 6K7D501n5x34gxDTwmphSAordBHYmmVEISsQirFkXRre2eTKq4s/B+oJpoHyKvqyDLmu 4fH3Ia9zwJWIuYXyYkvso8IHIeFyTtS+/usBajOk5ZjU+ZN5s+ZvZzVnRl9MQkBW0CEK Zkwj02XtcxkXTi41TCK9tC1i3aWuHiECw2cEFPq203Ni3WpAxEPmHu/nTjK2yh1fZAdO ePQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:mime-version:date :dkim-signature:message-id; bh=foiCuM1H7ljhyJH1H/r+XAx2HhX//BkMMbSuBQo9fHc=; fh=aR1uRqAI70xcfi7+nURJejEFC0pj4BlqCVpCn26YjGU=; b=n4YzMG93ROCS/UmjwsyiMQEcHwSSgyt6b4umQyah18Wn2QU0ORnh0ADz392oOLjLhC eZKmlcZ0ly3Cp02c8X0FHV8qFn6t0g6+8M4Z/i1xAZqtV//TKZr9/9IIOIz0f/ENnpBi whr+TVUj87CGzHcfjYpVOjo8SfOD7zgUHf0Eq4do0gvfM47ZvpScZXZe92kRwFxgTiLV HgxJacoH9HjTcs46g7Mm75PskVa7E3Wy/n1VWV31i56ux237R0pHXNlgiIN81q7fKRzU 5+SiNOeqGuEF+Tf/pZo9xl9nNQefpCmTrcFR1ZPwIUsBDcmjGaFdoAxpgVYdVHXFuTSP mlMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=GD9g58o9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id s67-20020a635e46000000b005777bea0b6asi1583765pgb.859.2023.10.18.00.37.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 00:37:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=GD9g58o9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id A6DB680C3A30; Wed, 18 Oct 2023 00:37:49 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344500AbjJRHho (ORCPT + 99 others); Wed, 18 Oct 2023 03:37:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229734AbjJRHhm (ORCPT ); Wed, 18 Oct 2023 03:37:42 -0400 Received: from out-198.mta0.migadu.com (out-198.mta0.migadu.com [IPv6:2001:41d0:1004:224b::c6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CE77B6 for ; Wed, 18 Oct 2023 00:37:40 -0700 (PDT) Message-ID: <6fdb2e74-2918-4cd2-bbda-f00745b03b97@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1697614658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=foiCuM1H7ljhyJH1H/r+XAx2HhX//BkMMbSuBQo9fHc=; b=GD9g58o9Ib0PEYOKxZHm/qm0HvTmWCnn2WxHVvnrlecED1sl9Q9Y7vSRp1xOMFPUylP138 Wxgnw7qZh78PzRrVX7deqYD8HOlReBCO0vwZqvoweQBC5muS3aCyrQAH0ia7hLleHlGI8o palR01VPvGo5OxcXcthkMzEtu4d0GAA= Date: Wed, 18 Oct 2023 15:37:09 +0800 MIME-Version: 1.0 Subject: Re: [RFC PATCH 1/5] slub: Introduce on_partial() Content-Language: en-US To: Matthew Wilcox Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chengming Zhou References: <20231017154439.3036608-1-chengming.zhou@linux.dev> <20231017154439.3036608-2-chengming.zhou@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 18 Oct 2023 00:37:49 -0700 (PDT) On 2023/10/17 23:54, Matthew Wilcox wrote: > On Tue, Oct 17, 2023 at 03:44:35PM +0000, chengming.zhou@linux.dev wrote: >> We change slab->__unused to slab->flags to use it as SLUB_FLAGS, which >> now only include SF_NODE_PARTIAL flag. It indicates whether or not the >> slab is on node partial list. > > This is an unnecessarily complex solution. As with the pfmemalloc bit, > we can reuse the folio flags for a few flags. I would recommend the > PG_workingset bit for this purpose. > Yeah, this is better indeed. Thanks for your suggestion!