Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <7ed3e212-caf0-4148-9d5e-27c14facaa05@suse.com>
Date:   Wed, 18 Oct 2023 10:40:10 +0300
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v14 06/23] x86/virt/tdx: Add SEAMCALL error printing for
 module initialization
Content-Language: en-US
To:     Kai Huang <kai.huang@intel.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
Cc:     x86@kernel.org, dave.hansen@intel.com,
        kirill.shutemov@linux.intel.com, peterz@infradead.org,
        tony.luck@intel.com, tglx@linutronix.de, bp@alien8.de,
        mingo@redhat.com, hpa@zytor.com, seanjc@google.com,
        pbonzini@redhat.com, rafael@kernel.org, david@redhat.com,
        dan.j.williams@intel.com, len.brown@intel.com, ak@linux.intel.com,
        isaku.yamahata@intel.com, ying.huang@intel.com, chao.gao@intel.com,
        sathyanarayanan.kuppuswamy@linux.intel.com, bagasdotme@gmail.com,
        sagis@google.com, imammedo@redhat.com
References: <cover.1697532085.git.kai.huang@intel.com>
 <58c44258cb5b1009f0ddfe6b07ac986b9614b8b3.1697532085.git.kai.huang@intel.com>
From:   Nikolay Borisov <nik.borisov@suse.com>
In-Reply-To: <58c44258cb5b1009f0ddfe6b07ac986b9614b8b3.1697532085.git.kai.huang@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDJmNk10M204S3U5R2oxNXBDeWdwSjdjcjUwcXAvUGZpaDBjanBBU1loa01N?=
 =?utf-8?B?QWNtNWVDcEVybEdXekFnT01yc1RQL1FadThLTEFLcllLSWlJeG5IcEpkM0g4?=
 =?utf-8?B?Z1R5VnkrSysyVjBaUEdUQU8yZzZUYi9kMWl4d0N0amNxcG1WSlhBblVCTGow?=
 =?utf-8?B?U2VEdXJVeFFnOUFVVTUrMUN5WWZmZS8zSzRhUTFBRlNOUEs2RDVWRVZ0aVFO?=
 =?utf-8?B?cUhNblkwUEoxNmg4cXBweWlvcFhXaUJZRWFLclhhclYzenQ5Q2N5TG1oSmRH?=
 =?utf-8?B?ZTQzakt4NnE2Qkd0M1lDejdsVVY5K2UxbmxRQ1lsYkhudlJDY04vcWV0aWg4?=
 =?utf-8?B?K09OdFdMU01VdVZkQmR6dklCTWhSSDJYbis4bVFnYXhWL0FUWkVkR2NKNk9k?=
 =?utf-8?B?cXpiUEpiNVpxR3haTDFiVUdlaHIyUG1WaXFCUGhNQkRkbkVubG5TRGVOYXN6?=
 =?utf-8?B?U2ZpWklyakdmZFN6WXR6VjhXelQwUEx6TWRkd3NEK2VaazQ2bnR1dE1sa3Vz?=
 =?utf-8?B?ZEIxZ281OGN6R3IyUWw3MHkxdXZSSU5Fc2ZPZldMaUhpZGxOYmJTTGYrRmVZ?=
 =?utf-8?B?Ukl6cWtMc2p2amQ3QjdZOUZUUWt1Z2FMN0dtTHNDQkVNVXpUcDRZdFcxQ2Fi?=
 =?utf-8?B?L09Ud3lReGxOUjlZLyswNTE2WFlmY2hOT3pDdDAydWNZamovbnNlL3BLUE5Q?=
 =?utf-8?B?YVNoajlqVFhzM1VLZEIxb0tPcTZuWWJwL0Z6bGJ4TGFSWWdtQmc3dyt1YlFo?=
 =?utf-8?B?VkNvMjRWN1VCdm4xck90L3UwQk1SRzlYNm5VcjZ6MFdmYW5xcWhHcStwSGdN?=
 =?utf-8?B?RGxFU2ZWTDhJMzQrOFFpb1U2MXlicEdqUWFDV3BmU3ZURS9IQUc5Y2hBTldz?=
 =?utf-8?B?bFlNL1EyblFDNm1objBHRFJLUHJUMVF1Q09aa2J0MkJVWElEU0RESitibkFi?=
 =?utf-8?B?eWljZkxBODBJMzZQZHA0eFVHR3ZZOWhDa0tEbTkwck8za2hzb0pKYWRVWWU5?=
 =?utf-8?B?SmpIc2JoUGJsN0h0aHc5ak50dDdldDl6eFI0Wi9KNFhNY2k4dU44NUQydm1h?=
 =?utf-8?B?L3EvNzZjUWtVbytJeXdnaEEyR2U3S2Z4U0Fjd1hXOFMvay9Sc2lETDZuSDJa?=
 =?utf-8?B?S2ZpYXZZT1phYVBGY1luMmhja2FTdUd6STA1Z0ZSMWlZN3pjaEtLanpnVmxy?=
 =?utf-8?B?bmtyeFZHaW5JUWFvc2FWNnZuZVloQTNIODFheWR6V21EWk9TQkh2ZEgvalJi?=
 =?utf-8?B?U2JHNk9Denl2N3VIMmptalJ4QWRqUDBIeE85NUR3czdHMFozd1UzTGo4bXJx?=
 =?utf-8?B?WUh5ZVdiSWg1NmU3WG1wcWtUUjBhSmg3dHh2aDJVa2FYQy8wby83OXJ2d1Jr?=
 =?utf-8?B?cFp3QURFTFFHUkc4YThwMWdaZ3R5RDhMSFUxNnBWakUwd0NPcVRva1lWaWRi?=
 =?utf-8?B?ZnpkVEZXVUk0bVpVVEoyRTBiUUNJdEl3RFNVYVVDYzhNVmNxUWNMd2J0bUdO?=
 =?utf-8?B?eHJheG1qUENESEY0VitBN3lEdUtCOGt1VCtnNzlCVWQ5U2xCQlV3Y1VkSk1w?=
 =?utf-8?B?a0pjSjk0Tm10K1dxZGYwbnk0UDA5UWQzQkRmMFlFU2ZZOW94a1grY01kaXc4?=
 =?utf-8?B?ZzRMR2ZONDE4cG95b2w0RGw5M0JQck02SnhHWGxHTjBnYnJVbDNUcHFKUnpl?=
 =?utf-8?B?RnVKOStVUjViei9OVytjREtvRWR2RVFEc2tVOS9kMUVnWlVoMUZ3bmpab2Fy?=
 =?utf-8?B?S1lIa1RFSkoxQTkxL1BDdzkrOFp4bnZrMFEvaFk1YUFRQ1FRcGhFamhIYUVv?=
 =?utf-8?B?SWd1blhtb2FXbnhrUGl2U1NMMFUxblc3eHB1OEpmOHNWSEtEOVlaL3A4YTdK?=
 =?utf-8?B?S0Rpa0xqL1k2TlFxY0lzVkJhcjhwSTc0MzhZcnM5Z1l5bzlvRjNRbEVqblp1?=
 =?utf-8?B?bE9UVkc1QWIyV2R4S3pYdkdLWk96Y285aENwMFVibzh0TXFvSzB4bS9vbk1t?=
 =?utf-8?B?ZEJsLy80L2FhZkMycWVFVGxkSFhiZUs5K2w4dUtEVEs5YmZQbWV1VHZ6UFBJ?=
 =?utf-8?B?UnRWNGFwQ0dKOEZod05IRCtzRmFteFNncHZwaERWQUxYVmdaNmM4UXp5dEVL?=
 =?utf-8?B?ZzJSN2JvZWVPVy9CYWpNVi9XK0pNY0Q1UDJhbkYrWTczTVdaUzdrb3lHbW93?=
 =?utf-8?Q?H5J5hUcXvgu1+E8vzB7B3sXHv9LCmkuruZHWECCYv1vt?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c314209-4fee-4ec4-723c-08dbcfad7836
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB7790.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 07:40:16.0467
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7z3kB0GKkN7NSw+ZiGWWjRGsjV25SrMqLYDnkpsEKDhjirGR38yZ3n24S60cq8Bey8bXa/KkBJGwPm81MNQA4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8573
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 18 Oct 2023 00:40:46 -0700 (PDT)


On 17.10.23 г. 13:14 ч., Kai Huang wrote:
> The SEAMCALLs involved during the TDX module initialization are not
> expected to fail.  In fact, they are not expected to return any non-zero
> code (except the "running out of entropy error", which can be handled
> internally already).
> 
> Add yet another set of SEAMCALL wrappers, which treats all non-zero
> return code as error, to support printing SEAMCALL error upon failure
> for module initialization.  Note the TDX module initialization doesn't
> use the _saved_ret() variant thus no wrapper is added for it.
> 
> SEAMCALL assembly can also return kernel-defined error codes for three
> special cases: 1) TDX isn't enabled by the BIOS; 2) TDX module isn't
> loaded; 3) CPU isn't in VMX operation.  Whether they can legally happen
> depends on the caller, so leave to the caller to print error message
> when desired.
> 
> Also convert the SEAMCALL error codes to the kernel error codes in the
> new wrappers so that each SEAMCALL caller doesn't have to repeat the
> conversion.
> 
> Signed-off-by: Kai Huang <kai.huang@intel.com>
> Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
> 
> v13 -> v14:
>   - Use real functions to replace macros. (Dave)
>   - Moved printing error message for special error code to the caller
>     (internal)
>   - Added Kirill's tag
> 
> v12 -> v13:
>   - New implementation due to TDCALL assembly series.
> 
> ---
>   arch/x86/include/asm/tdx.h  |  1 +
>   arch/x86/virt/vmx/tdx/tdx.c | 52 +++++++++++++++++++++++++++++++++++++
>   2 files changed, 53 insertions(+)
> 
> diff --git a/arch/x86/include/asm/tdx.h b/arch/x86/include/asm/tdx.h
> index d624aa25aab0..984efd3114ed 100644
> --- a/arch/x86/include/asm/tdx.h
> +++ b/arch/x86/include/asm/tdx.h
> @@ -27,6 +27,7 @@
>   /*
>    * TDX module SEAMCALL leaf function error codes
>    */
> +#define TDX_SUCCESS		0ULL
>   #define TDX_RND_NO_ENTROPY	0x8000020300000000ULL
>   
>   #ifndef __ASSEMBLY__
> diff --git a/arch/x86/virt/vmx/tdx/tdx.c b/arch/x86/virt/vmx/tdx/tdx.c
> index 13d22ea2e2d9..52fb14e0195f 100644
> --- a/arch/x86/virt/vmx/tdx/tdx.c
> +++ b/arch/x86/virt/vmx/tdx/tdx.c
> @@ -20,6 +20,58 @@ static u32 tdx_global_keyid __ro_after_init;
>   static u32 tdx_guest_keyid_start __ro_after_init;
>   static u32 tdx_nr_guest_keyids __ro_after_init;
>   
> +typedef void (*sc_err_func_t)(u64 fn, u64 err, struct tdx_module_args *args);
> +
> +static inline void seamcall_err(u64 fn, u64 err, struct tdx_module_args *args)
> +{
> +	pr_err("SEAMCALL (0x%llx) failed: 0x%llx\n", fn, err);
> +}
> +
> +static inline void seamcall_err_ret(u64 fn, u64 err,
> +				    struct tdx_module_args *args)
> +{
> +	seamcall_err(fn, err, args);
> +	pr_err("RCX 0x%llx RDX 0x%llx R8 0x%llx R9 0x%llx R10 0x%llx R11 0x%llx\n",
> +			args->rcx, args->rdx, args->r8, args->r9,
> +			args->r10, args->r11);
> +}
> +
> +static inline void seamcall_err_saved_ret(u64 fn, u64 err,
> +					  struct tdx_module_args *args)

This function remains unused throughout the whole series, remove it and 
add it later when it's actually going to be useful.

<snip>