Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3628810rdg; Wed, 18 Oct 2023 00:40:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF3bA/ZVCBc1dNnjOv1wsQpZREBjPsmq61uj9D0JH7ZdT1+cXOx10mEXHT4Y7vViE4sYBms X-Received: by 2002:a17:90b:30c7:b0:27d:89d:2bc3 with SMTP id hi7-20020a17090b30c700b0027d089d2bc3mr4103528pjb.3.1697614853739; Wed, 18 Oct 2023 00:40:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697614853; cv=none; d=google.com; s=arc-20160816; b=oXsNDyZsaYEV7u3FJ/cJI4QT5894s7UoSTR2RjWqp/fxeKycTeuSJxLTTwgoiHNvoo wm3bQu2xAoQC3TOP2mIWDwQ07EMZ11tzWXo1hIL5aoJ4b193krCKSLVylYxbFUe2d9I4 4CYgPmvrxYFD8hk99ALf590UzIERC7qJQ4LJ1Zg3hQ13KlsgjhuSgsliRwsaDH83BTwZ mrcnq3IJ7Uw7NMui+ere7YGUPOdqhA2XF+KBuxy5asjYxyMOXcroHkC5yAqOfJ8+bu4i A8mQYcqqHJhmf6/RatfmtwFMZqFeCWwRm4wVrxDmpuID7wEBtzd22jVn7Hju1vbMtMnH 6lPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=OdVOgMp5thI0gzNIVMPG3UiTd3PU3NzNnXq/aUKTS9k=; fh=qd51tipRMowFsCwhBeBs7oW7FNH0n5ggIn2gCF8gYrI=; b=WpeXQE8rqJNaaxAzwAAHKGCfc+vCvq+nSrA1N8dVxS87AK63PzgpjfHmeoysEI30Gg Zmb7rn+HT38Lfh9qRKpErnxIxjDflP/xjEtxPOEr6XM9gkWEIX4Vpf9zLmcXQe64rfZa LOtqXmzN0GgazlQYEzEnwIhRt0xC4bGM9AQx20TGNuw8GrG8y1aJPMU1hNtx/swU4S0D Wgu4PvLpFfBOgizI2KH+n8r4+9JiEdROANcXi0noEiVRfNlm0xroJVVoo/a+8dwWhK4C ZHSX5tHqYDycnTRDSqlzWRM/H/clsB7l64pBr89bS9sQORJ3kvF4Vkc5G7WHSif7ajR2 l4RQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=V88jOWnN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id g5-20020a17090a9b8500b0027d20cab1d3si943465pjp.42.2023.10.18.00.40.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 00:40:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=V88jOWnN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 4CA1B8076160; Wed, 18 Oct 2023 00:40:25 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229880AbjJRHkL (ORCPT + 99 others); Wed, 18 Oct 2023 03:40:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjJRHkJ (ORCPT ); Wed, 18 Oct 2023 03:40:09 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12DC2B6 for ; Wed, 18 Oct 2023 00:40:08 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29228C433C7; Wed, 18 Oct 2023 07:40:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1697614807; bh=52gu4uhHVMhD/2inO2iHCSdv7ffG5JVaRL7n7IKgzIM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V88jOWnNtotfbOOgqvqTCotxydelHAlUUl284iLp88/HB+ldzp/8igPk2zTn2uCJ6 pEtR5S9WXCHXFS7kwze77ZrIdqmOkTdhgR3n1Sx5gO5BWdUwsw+frIuKCkyAwjofml ihWQZxpS4J0heyaFv8GnMSjccVa8mQFvZWNiYwMY= Date: Wed, 18 Oct 2023 09:40:04 +0200 From: Greg Kroah-Hartman To: Calvince Otieno Cc: gustavo@embeddedor.com, outreachy@lists.linux.dev, Julia Lawall , Martyn Welch , Manohar Vanga , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH] staging: vme_user: fix coding style - remove CamelCasing Message-ID: <2023101841-unglazed-hydration-d6b8@gregkh> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 18 Oct 2023 00:40:25 -0700 (PDT) On Wed, Oct 18, 2023 at 10:22:50AM +0300, Calvince Otieno wrote: > This patch addresses coding style errors identified by checkpatch. The > changes include converting camel case names in constant variables to > UPPERCASE. These changes align with the coding style guidelines. > > > Signed-off-by: Calvince Otieno > --- > drivers/staging/vme_user/vme.h | 12 ++-- > drivers/staging/vme_user/vme_fake.c | 8 +-- > drivers/staging/vme_user/vme_tsi148.c | 88 +++++++++++++-------------- > 3 files changed, 54 insertions(+), 54 deletions(-) > > diff --git a/drivers/staging/vme_user/vme.h b/drivers/staging/vme_user/vme.h > index fbcbd0204453..0b40859fee23 100644 > --- a/drivers/staging/vme_user/vme.h > +++ b/drivers/staging/vme_user/vme.h > @@ -33,13 +33,13 @@ enum vme_resource_type { > #define VME_SCT 0x1 > #define VME_BLT 0x2 > #define VME_MBLT 0x4 > -#define VME_2eVME 0x8 > -#define VME_2eSST 0x10 > -#define VME_2eSSTB 0x20 > +#define VME_2EVME 0x8 > +#define VME_2ESST 0x10 > +#define VME_2ESSTB 0x20 Checkpatch is wrong here, this should stay as-is. thanks, greg k-h