Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Wed, 18 Oct 2023 11:10:10 +0300 (EEST)
From:   =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
To:     Reinette Chatre <reinette.chatre@intel.com>,
        Shuah Khan <shuah@kernel.org>
cc:     Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-kselftest@vger.kernel.org, Fenghua Yu <fenghua.yu@intel.com>
Subject: Re: [PATCH v2 1/1] selftests/resctrl: Fix MBM test failure when MBA
 unavailable
In-Reply-To: <20231018075526.2251-1-ilpo.jarvinen@linux.intel.com>
Message-ID: <9965dc22-16fb-cadc-2b5f-ff7c2c91a173@linux.intel.com>
References: <20231018075526.2251-1-ilpo.jarvinen@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-507791766-1697616245=:2178"
Content-ID: <5e4e6ac6-c2de-5f27-ba81-3db64b19e1aa@linux.intel.com>
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-507791766-1697616245=:2178
Content-Type: text/plain; CHARSET=ISO-8859-15
Content-Transfer-Encoding: 8BIT
Content-ID: <185dd7a9-fe4a-b473-2e4a-41be8a2027e8@linux.intel.com>

On Wed, 18 Oct 2023, Ilpo J?rvinen wrote:

> Commit 20d96b25cc4c ("selftests/resctrl: Fix schemata write error
> check") exposed a problem in feature detection logic in MBM selftest.
> If schemata does not support MB:x=x entries, the schemata write to
> initialize 100% memory bandwidth allocation in mbm_setup() will now
> fail with -EINVAL due to the error handling corrected by the commit
> 20d96b25cc4c ("selftests/resctrl: Fix schemata write error check").
> That commit just uncovers the failed write, it is not wrong itself.
> 
> If MB:x=x is not supported by schemata, it is safe to assume 100%
> memory bandwidth is always set. Therefore, the previously ignored error
> does not make the MBM test itself wrong.
> 
> Restore the previous behavior of MBM test by checking MB support before
> attempting to write it into schemata which results in behavior
> equivalent to ignoring the write error.
> 
> Fixes: 20d96b25cc4c ("selftests/resctrl: Fix schemata write error check")
> Signed-off-by: Ilpo J?rvinen <ilpo.jarvinen@linux.intel.com>
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
> ---

It seems it's too early morning for me so I entirely forgot to describe 
the changes I made... doh. So here it is (nothing earth-shattering here 
really):

v2:
- Make checkpatch --strict happy.
  - Remove () that --strict called "extra".
  - Duplicate the referenced commit description in the changelog
    to follow the commit formatting guidelines.
  - Alter the wording at one of the references into the commit 
    20d96b25cc4c in order to avoid having to copy the description
    there too.
- Added Reinette's rev-by.

-- 
 i.


>  tools/testing/selftests/resctrl/mbm_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/resctrl/mbm_test.c b/tools/testing/selftests/resctrl/mbm_test.c
> index d3c0d30c676a..741533f2b075 100644
> --- a/tools/testing/selftests/resctrl/mbm_test.c
> +++ b/tools/testing/selftests/resctrl/mbm_test.c
> @@ -95,7 +95,7 @@ static int mbm_setup(struct resctrl_val_param *p)
>  		return END_OF_TESTS;
>  
>  	/* Set up shemata with 100% allocation on the first run. */
> -	if (p->num_of_runs == 0)
> +	if (p->num_of_runs == 0 && validate_resctrl_feature_request("MB", NULL))
>  		ret = write_schemata(p->ctrlgrp, "100", p->cpu_no,
>  				     p->resctrl_val);
>  
> 
--8323329-507791766-1697616245=:2178--