Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <870b9b74-75bc-2a0d-7138-ae8df237f980@intel.com>
Date:   Wed, 18 Oct 2023 10:12:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v2] Staging: sm750fb: Rename
 display_control_adjust_sm750LE
Content-Language: en-US
To:     Dorcas AnonoLitunya <anonolitunya@gmail.com>
CC:     <outreachy@lists.linux.dev>, <julia.lawall@inria.fr>,
        <dan.carpenter@linaro.org>, <andi.shyti@linux.intel.com>,
        Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        Teddy Wang <teddy.wang@siliconmotion.com>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        <linux-fbdev@vger.kernel.org>, <linux-staging@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>
References: <20231018080416.25931-2-anonolitunya@gmail.com>
From:   Karolina Stolarek <karolina.stolarek@intel.com>
Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298
 Gdansk - KRS 101882 - NIP 957-07-52-316
In-Reply-To: <20231018080416.25931-2-anonolitunya@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SzI4MmYxdm93bWhJcitFaUhmUi9iMmdlSll1VzVZUlhlQ3ZnYXVjTGhJN3Z0?=
 =?utf-8?B?NHI4WmNMTnd1UHdZZDNOZVoxZWpzTk90Qlo4SXI5dkZMdU1jRlhuVkYzUGk4?=
 =?utf-8?B?dXl4Z3lHUkN5UUZFdFFvVlBvSFVnTE5ZNityMVN3Z3prTHU5cjVQbHNhMXRj?=
 =?utf-8?B?Y05OMnJEem9pbmd3aU1pQ2g2a29HbG1lVnpKbmJSVDN5QkVjUXdZVmZDK2lx?=
 =?utf-8?B?QnRzbndRcisyTXdSMnRZMy9tS2dvcndMQUdkZ0Z6NGl5V3dnL2JYSENyM29M?=
 =?utf-8?B?djdLaGtPRUFIN2FiT3UvbVNET24xdnhkRVdIMU9RQzZnQ1VLYTFRaGdGUkF5?=
 =?utf-8?B?UlZ3YitlZ1o4V1RKWldjYXNGUXJOUDM1dGtlK1hMRE93Q0w1QkE2MzhwL2xi?=
 =?utf-8?B?ZWE4UHQvZ01ubFVlVEJtSkVkS0Q2OGFkMk1TMEI0emhmNUNFeVRkT0paNEZO?=
 =?utf-8?B?SkZyMUNSQkloVHZiM2p4ZmUydCszZkEyZUtIMTUxWmNrRk1iRmphSnZqbXZy?=
 =?utf-8?B?UUdxOTJuR3hPdnFmdGVQWlRpZURLUGswMUlCVlFZcVV6dWtxSWZDYmMwMzBy?=
 =?utf-8?B?Z1RtK1BBbmJkTzRwdEloMU55Y1BBWlQ5UUJzVUs2OTI5MlpORmdLU2VHRk5D?=
 =?utf-8?B?UW1rT3d4dE4rV2w3emdVY2tvS3l6cGw1RnVCQkZHMEZEWFZQWDN6S3B3WkhH?=
 =?utf-8?B?cFcydFBsZCtNTXY3MWFKd1FuS3dCb3JlMWFFajFGeGNpUmRRN1Nic2tGZktL?=
 =?utf-8?B?NFV6QWR1T2wxcnRGY01LekwvVSsyYWxrVWR2SDI2TUIvNmRQTEJlNWhDOE1a?=
 =?utf-8?B?cUs0ZXlsb2dTdE5wem5QMmdKZmM3RUF2aGZHMHpDd3NqT0oybkxmdnhMZFR3?=
 =?utf-8?B?SEplL0g0VjllVUE2WmFwdEUvazMyU1Z0RDM1eGhldlc1U0hJY21JSnZNYS9t?=
 =?utf-8?B?Sm9NVExTYWFqTjA1QzhLcjBnem9aOXZsazZVaC94bkZ0ZkQzaEJuaEQ5MWpr?=
 =?utf-8?B?NWVjYXErSlpmbGhQYk10OXlvTS9JVTN3TnBuaUVwMjJkaWJOME1zeG5YcjJz?=
 =?utf-8?B?cTd5Vnh2Y0JJNGRkaWZWTWp2SVlrVU5tbzAwRzVCVWY5N05wMnRlMWk4QU5v?=
 =?utf-8?B?aEQ5WW5kT2FheWtpcnBuTzJzZG5zWUZvdjV6L0d3TkQ2MkoxK2NjNmt3dmF0?=
 =?utf-8?B?Qi9TV2tmQ29oU3prT09zZFBWSnk5TVFKUXNaSVl4eHpLbDEvM2hPaE5ocUE4?=
 =?utf-8?B?dkE1cnRqa0FnQk13b3p1NlR3K1dZOUw2dW13c1dhQzRjQm5DbEFIU0lHaHI5?=
 =?utf-8?B?dWk0QkRyaXdTUFVnQkZqM0RLS0VnYmcwNnkyZFhSdGlxUS9ZZ2dhVWhFQ1Ni?=
 =?utf-8?B?VTVNNm5aM3RqN3pQY3YzWExhUEVIZllZQWt5emxUenpaV0lNUmRMTTNsZnR1?=
 =?utf-8?B?dklHWUd1Y1BFQW4vU1RUT3dyS0N5eHhKcWJBeEM1UWFVQUJyRU1oWUlHREhz?=
 =?utf-8?B?aW96SG1TcnpJZm5KVEFzSjFtWFpiQTJzZjhhcE43b1dCWlhCRjlNckkveE01?=
 =?utf-8?B?WndHaXM3OXYwZ0trRjVkSktQSXBhRFdac3BzUjRTMlVCaUhFc1YxYm1UdzhM?=
 =?utf-8?B?WFhlVmlsOXM4QWVjTzhnS3RZOVJjdnJCeE5yeDh1T1ppNDNnTWtHaHpMd3N2?=
 =?utf-8?B?MkVnVnA0c0lja0p3dDdwM3JUTEdCeWg3OFZjV1dDTEh1a2NkdS9FcW5aVjlQ?=
 =?utf-8?B?L01iZmsxNFlUeFBhc3hhT2YxTVVteEtxREplRzBHV0R0Ukh3QUlSc25aV1Aw?=
 =?utf-8?B?NldqbXlONXdyOEdJcmlkbW4vWHVXbkVyNi9mdVMzekRoY2s3N3dqR1I5NVNk?=
 =?utf-8?B?NDNYeFgzaWt4MnJCTmNMTE4yOWxOem1LWmpkbWREN00yb1BTRjRwTlp1TFVw?=
 =?utf-8?B?aFdvZzlrNlhFVm9Zci8zaGROVFJhZVNnYkg2dzdQaVZWUGNPSXhUSDVvQWR5?=
 =?utf-8?B?M1pOUks3eFN1d3JBcWlUdFR3bUpyMkVkWEROYm9OdHJDSnN2Nm1WbG9BSTh2?=
 =?utf-8?B?U09zbGZEWFFjcWU2dE4xMUtidElzSkIwTURjZWtCVnFabXczeTg5N2UyOXN6?=
 =?utf-8?B?VldWc25kYUp0Y2l5R3FaUTVjSkRBeWVPYnd4VStRUUhqQmtjcXhBWjNSNWtM?=
 =?utf-8?B?cEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 72c13550-d433-4fb0-a862-08dbcfb1efcc
X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4243.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 08:12:14.3360
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: luyU7jF6dl14tydI2TMAoJm3Mu8mrAKyRbPoK8H9eptD4gpfHkIz26glZbxSznDyyRzaZlVKc2QtRzoEEv9d4IhgQS47GtsqrOSwcOjJ+ag=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB8398
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 18 Oct 2023 01:12:46 -0700 (PDT)

On 18.10.2023 10:04, Dorcas AnonoLitunya wrote:
> Rename function display_control_adjust_sm750LE to
> display_control_adjust_sm750le. This further enforces snakecase naming
> convention for consistent naming style throughout entire file.
> 
> This change was suggested by Andi Shyti <andi.shyti@linux.intel.com>

You can use Suggested-by tag here, if you wish (as per [1]) before 
Signed-off-by line.

In the first line of the commit, "Staging" should be lowercase.

All the best,
Karolina

-----
[1] - Documentation/process/submitting-patches.rst

> 
> Signed-off-by: Dorcas AnonoLitunya <anonolitunya@gmail.com>
> ---
> 
> v2: Correctly spells Andi Shyti's name
> 
>   drivers/staging/sm750fb/ddk750_mode.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
> index f3f354831617..bcdd291d25c9 100644
> --- a/drivers/staging/sm750fb/ddk750_mode.c
> +++ b/drivers/staging/sm750fb/ddk750_mode.c
> @@ -14,7 +14,7 @@
>    * in bit 29:27 of Display Control register.
>    */
>   static unsigned long
> -display_control_adjust_SM750LE(struct mode_parameter *mode_param,
> +display_control_adjust_sm750le(struct mode_parameter *mode_param,
>   			       unsigned long disp_control)
>   {
>   	unsigned long x, y;
> @@ -125,7 +125,7 @@ static int program_mode_registers(struct mode_parameter *mode_param,
>   			tmp |= DISPLAY_CTRL_HSYNC_PHASE;
>   
>   		if (sm750_get_chip_type() == SM750LE) {
> -			display_control_adjust_SM750LE(mode_param, tmp);
> +			display_control_adjust_sm750le(mode_param, tmp);
>   		} else {
>   			reg = peek32(CRT_DISPLAY_CTRL) &
>   				~(DISPLAY_CTRL_VSYNC_PHASE |