Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3640549rdg; Wed, 18 Oct 2023 01:13:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFpXA63rGIc42ImLqDqK3V9VKKzSzo8DmZ1/oxXpXy1emx/b7DpPQp1aak4k2S3HrCrr+7W X-Received: by 2002:a05:6a20:a109:b0:13d:df16:cf29 with SMTP id q9-20020a056a20a10900b0013ddf16cf29mr4589643pzk.15.1697616827393; Wed, 18 Oct 2023 01:13:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697616827; cv=none; d=google.com; s=arc-20160816; b=JRppjO3pwxikq5kaCTtLCHMqSnTm+T8ZfgzC060C0X+Vsb9rL5WHFtvvcBHG9v8FB5 zPzeORJQy8VjiTq4NKUo5vpGnPhNzG+O0qdWoVvGzlA6JA48eOhf18ESeYdks1LXqnSv +9eEkvg6X6DeRpnqhjgKxXhIO8Xi9F8e+JFt7yuBj52TSf70thm0ZQYckUzda9Hbfvb3 Um3BddPKR85DK1gtJD835RByEAyEY1bGkWQbXyuC7pjd297w82hVde/DMIHuHZAGvIKj ihMv0euGRjgDI3Ef8P+KkZbZgcRPhMWB2JdKD/REdM9RAcdrsmZ91ZuMTatNVIYJdbmF ELvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:message-id:in-reply-to :subject:cc:to:from:date:dkim-signature; bh=GpetY+lN0kNSU4kScIjhhgCa5RGP7XMD9CtalAfPG4Q=; fh=V1snAB/QnncDjX59yqwvPNWOpNNZcwWoirXryiRzHI0=; b=IwI2fZo0yhDqRLdQqIqoUcTbOeBvDAInGGj//TzGb5Clwh3f2HuK37Z/fSyhHKCAW1 QfW7Qxt/GpYcElCFZkKJprhkl6R+RKZ/OF8Z49YLzmnKFZYE6pYIfN0m0wanOXn1y5BE 95jLuQ4nOhBOtx9IMyOGrlhoeeiBY4mNmQhiPFAxANwxA2s0tkvGYVzDfO5jb/C1UCc6 DhieOft+I+bJ4x0yxbrebiuV1TRCgo+nffvmYeaZ2YkVIre63fnvHtRcoeqHt8sjAzay px3tlYxPWa2oDvZDsrDrVCGzDwu+E41EpG1TaSQAfhHl2JMDY7XjssXpcLiBAf1yMURK fPSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@inria.fr header.s=dc header.b=ocVAA5tU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=inria.fr Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id t6-20020a17090abc4600b002776e57a5d5si1006018pjv.94.2023.10.18.01.13.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 01:13:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@inria.fr header.s=dc header.b=ocVAA5tU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=inria.fr Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 74F038028130; Wed, 18 Oct 2023 01:13:44 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235050AbjJRINf (ORCPT + 99 others); Wed, 18 Oct 2023 04:13:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229919AbjJRINe (ORCPT ); Wed, 18 Oct 2023 04:13:34 -0400 Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34E9BB6 for ; Wed, 18 Oct 2023 01:13:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=GpetY+lN0kNSU4kScIjhhgCa5RGP7XMD9CtalAfPG4Q=; b=ocVAA5tUSH9a/yZ5RdQNI6jlCZofdNcSgxu2dgyGH6cWFWdfNoM24QdC o8p2RnuOK3AJRzsqhh9Efd5ehBMqHulh/z/OXt3I8qcNG3gR/5cg4MCSU K8h2C2pBFa5C8l+jsqFym/Sj+XuBSV3AX3XPbs/mbkQXJlXgowLSIN45o 4=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.03,234,1694728800"; d="scan'208";a="131832249" Received: from dhcp-138-246-3-50.dynamic.eduroam.mwn.de (HELO hadrien) ([138.246.3.50]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2023 10:13:28 +0200 Date: Wed, 18 Oct 2023 10:13:28 +0200 (CEST) From: Julia Lawall To: Calvince Otieno cc: gustavo@embeddedor.com, outreachy@lists.linux.dev, Greg Kroah-Hartman , Martyn Welch , Manohar Vanga , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH] staging: vme_user: fix coding style - remove CamelCasing In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 18 Oct 2023 01:13:44 -0700 (PDT) > As description states, checkpatch recommendation This comment should be just under my text, that you are responding to, not at the end of the patch. CamelCase is not just the mixture of uppercase and lowercase letters. It means that the things with upper and lowercase letters are real words, LikeThis. In the case of this driver, the lowercase letter was not part of an English word, so one can be suspicious that it has some other meaning. Checkpatch doesn't know what are real English words, so it makes the suggestions whenever there is a mixture of uppercase and lowercase letters. julia