Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
From:   Huan Yang <link@vivo.com>
To:     Yu Zhao <yuzhao@google.com>, Steven Rostedt <rostedt@goodmis.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Huan Yang <link@vivo.com>,
        Suren Baghdasaryan <surenb@google.com>,
        Vlastimil Babka <vbabka@suse.cz>, linux-kernel@vger.kernel.org,
        linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org,
        bpf@vger.kernel.org
Cc:     opensource.kernel@vivo.com
Subject: [PATCH 0/2] some fix of multi-gen lru
Date:   Wed, 18 Oct 2023 16:20:58 +0800
Message-Id: <20231018082104.3918770-1-link@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NCBQP4wIDalMkTCDGm+gYZd0U4nf1rn+BgosYAWrxUH763DkVWYR/qfOte2n?=
 =?us-ascii?Q?bmXhYbZayx/ONwKn4r6TCgIZf5JUPRNY1OOGKkKaRiy+cQlCQGQ0oXMxP+ld?=
 =?us-ascii?Q?F9/UY4UT7foV2pYcCFdfWnUuDZ6p4zsXtARYGOnILeWEEIAy0QRubu76R4Y3?=
 =?us-ascii?Q?shzkKoZ0Qat4PjhfErq0MnjwrFiJVUbQpmoY+sq8j4/WSw1bgte7R3ZtiVAu?=
 =?us-ascii?Q?TEtTL603COkb4Eau2X41abiuW7tuyIIgXYM5/njymMHTgqLyk8HHYAwDUuPj?=
 =?us-ascii?Q?0vJTB8m89RuR86oMGNU+M9YvyIg+ihGEmaB/ClBdGBdmt73PUG2IdsM9E71Z?=
 =?us-ascii?Q?1m3cCz0aasF6M8CGGPt3MF8gLGn/Hfmdf7ff3/7ELsYP695NcKcXLXWHOasv?=
 =?us-ascii?Q?hNpzfAnoBCsAlEJ1YUfQEKSIRzgFIchRsJt4z+390W52K5u59OpUKjmo6Mih?=
 =?us-ascii?Q?isyIWeF/5JhQHXqlS9wQTSSt3Oewl1bjL9n+AF4AM1CYRgH3brQPoL/LPxZ3?=
 =?us-ascii?Q?aDc5vUHzF6dXBjHjsbW317i+dwy1IJHO8nJia2h0f/oy1OVMWUxAZA1JbF6n?=
 =?us-ascii?Q?k5hsvRpQ9uBlxt/5J8GhDAxvRrGZGi8/wNfhsj3zTDb0lwkckNRU7rZkvXuL?=
 =?us-ascii?Q?lGhLQGHZwBsfiq6rnCU6QDXYBBzint82jjIoF2X2T+rTkwQNuzHUE4S7HdlH?=
 =?us-ascii?Q?2feiQIVRyKRJH5zBEECjnVddVb+0LeijQFl36BsDVBqz6GOI0ttGTuqY5VLg?=
 =?us-ascii?Q?0h+rrqJ3GEeRbNB/L5OX4b6uJbQczYuQDBBBLdNXf1eS9QOywYQrBzLU1C1f?=
 =?us-ascii?Q?IAGlDDB0bMZNyn9AV6t6xUR/v8jpjCAs36Gi/j8dXt38CGzww3fPwFkieGCk?=
 =?us-ascii?Q?ENkKn+IfdgQSbuVwv34XKHnrnS1rED6MhM6SznLn4Hneew4Ezp9V0euXQ7mC?=
 =?us-ascii?Q?3TuCaie7FMO1hhc2bb6nlhfxWpJvb3o/92l3CLrzN2vqOs/n5ZGKwWIZIURE?=
 =?us-ascii?Q?hGfu26et6muiFXsLgNc64VCsF0a2PepOq56/jFbzxpi7F2XJXcIUKj9gR6aL?=
 =?us-ascii?Q?ga+HiVlmdGVSJg18XBVu1zPlR5oIDocUxVbOGoAtBXDz7vDFrgexFvYirTfs?=
 =?us-ascii?Q?ln/IYdnbVeRHv4xKZD8Dsxb9ssiJH0LdLjYwQwXF6wGRMIntxXY/a73pLKm6?=
 =?us-ascii?Q?MeMWwB1yroRLEJAOK+gISrHgU7UBYMH4kejuMEaRM/4n0jJEJ30iy+ChLQ4W?=
 =?us-ascii?Q?s2TWFpsVnJAI0Ptv+KL8D/HA6z8uDOeqd0HynK787QHbIAkbNPhI8GqwW0oj?=
 =?us-ascii?Q?5qx07Yq5aBPd605zPbqh9iv7VWyPsNPaLkA47nwgy6UfyUDMH2PZgfhOQixW?=
 =?us-ascii?Q?4cyuG3gN3obucJJdLIV+CAvRe++tXxaSQkJtKYl3+TNziXTxOTyOOtFdhGS1?=
 =?us-ascii?Q?UNHwvtqteQe83/P38usv+Wv0EXZea5ASTLcptzSXfrjjvpIdb7Qii/Or5TY/?=
 =?us-ascii?Q?W5sQSPcbFaKrVakF5gYiqOjTa9E7pNKBpmlg3TiU34lAualG/icOXIKQIC/e?=
 =?us-ascii?Q?aEyB7XvXBqsF2a8fNVcufNlh/Xq/Xu9wVEnVCOx9?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a5946e0-1209-4f03-5fed-08dbcfb34af8
X-MS-Exchange-CrossTenant-AuthSource: PUZPR06MB5676.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 08:21:56.9551
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fZ5dkRou410tGNW2aZw4ozjrirJFFNjzAAhzvNodF/p9CyENts1+OYWIYWNJn+MBUh51uckWOQZ6pedKB4Yv5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR06MB4391
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 18 Oct 2023 01:22:20 -0700 (PDT)

For multi-gen lru shrink_inactive trace, here are
some mistake:

First, nr_scanned in evict_folios means all folios
which it touched in `get_nr_to_scan`(so not means nr_taken).
So, we may get some info from trace like this:

```
kswapd0-89    [000]    64.887613: mm_vmscan_lru_shrink_inactive:
nid=0 nr_scanned=64 nr_reclaimed=0 nr_dirty=0 nr_writeback=0
nr_congested=0 nr_immediate=0 nr_activate_anon=0 nr_activate_file=0
nr_ref_keep=0 nr_unmap_fail=0 priority=4
flags=RECLAIM_WB_FILE|RECLAIM_WB_ASYNC
```

Actually, we don't taken too much folios in shrink. This patch
use difference between before sc->nr_scanned and after shrink to
replace nr_taken and pass this to shrink_inactive tracing.

Second, also like above info, we can't get nr_folios going to where,
actually in multi-gen lru shrink, many keep by folio_update_gen when
look around or other promote this folio.


Third, evict_folios don't gather reclaim_stat info after shrink list,
so, dirty\writeback\congested stat will miss, and we can't control
LRUVEC_CONGESTED or reclaim_throttle.

Patch 1 aim to resolve first and second, patch 2 resolve third.

Huan Yang (2):
  tracing: mm: multigen-lru: fix mglru trace
  mm: multi-gen lru: fix stat count

 include/linux/vmstat.h        |  2 ++
 include/trace/events/vmscan.h |  8 ++++-
 mm/vmscan.c                   | 61 ++++++++++++++++++++++++++++++++---
 3 files changed, 65 insertions(+), 6 deletions(-)

-- 
2.34.1