Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3661190rdg; Wed, 18 Oct 2023 02:07:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHGf8IJmaPoHmG2mchj8MsRyZJeHG7NXMohvkrk+cRW5/L286bvpjdO19VY5sj5HASa5ylW X-Received: by 2002:a81:4f48:0:b0:5a7:d937:6f27 with SMTP id d69-20020a814f48000000b005a7d9376f27mr5171681ywb.19.1697620070103; Wed, 18 Oct 2023 02:07:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697620070; cv=none; d=google.com; s=arc-20160816; b=JZC91+At0FzIZdGLxwpcIrZkYo7nPHQWhHmIXqbjIfPFgAozYyvO196Sy2bsFRkBZW 2la0hENSgk+fV5KmTfAW2CiRQ198bXn/exzAW1rdyqwN2vInVCbSBtOiFnjQtscS/iRh 90ir0SHRYpdjhZJrGva7zYiu1rrTngLFTstuAt6MIXXkmsYAiPRGGOm7eRLAsgOpRLsN 3Sk45J1InREt52GYWbOETD91oN1s75sjIuYbxPIAqeFJxRwVYWoY9lo7EBeSCc9GuCB0 ynxpX730xVxKdffMAQlL8JVSw9W3fd8QA2DkhIgpTOnpj5SdzNN2ExgCGuF//ftnO7g/ OxEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/c03+KdpEpWmg35HZQWHtMrhSTkDXgsYhEeqNUIod60=; fh=Xkpd4rDA3fgvQh8LmYAxcjZ+LZfLQ1oWtkvv2jbb8Rk=; b=E8Fo0fM5RpWOaoeYuT2Lr/RBGQ4F0p9t38MYEn7/+OBKrS66NAqBqQL2llZuj/G4je MOEvccqKRc4fseJnP0cF4bp4Rq09hGF3XX0nV96sSE0j0a7nTqW9uUfisWtqZxyfOd7o oNAnUh+C6xDfEQ+f/YFEcJK6qbtyftStpCqGK6Tr7pAFxXyYvY5TpGqwNS0uQqaVr3sS EYDpgO4sjVaVdb5p1qU42GfUJ1sqzLSWg0omvnp6Play3GG4r7Dyby3Ypk0bwzGK7Euo zoSFIuD8hWyMW+Tdd9lxtIqhFJkcMjUgNikPdQXW/1yNcQBdRYx/dfoBulJE0mO/+iaF nsDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Es+vckhM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id t16-20020a639550000000b005b0545c6384si1760775pgn.77.2023.10.18.02.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 02:07:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Es+vckhM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id CA8218023185; Wed, 18 Oct 2023 02:07:47 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229572AbjJRJHm (ORCPT + 99 others); Wed, 18 Oct 2023 05:07:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbjJRJHl (ORCPT ); Wed, 18 Oct 2023 05:07:41 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C26AF9; Wed, 18 Oct 2023 02:07:36 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8165EC433C8; Wed, 18 Oct 2023 09:07:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697620055; bh=l4Oi5jf7qwP7CNkVZZNY8DYKTprQka+ShuoW7/Do0XQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Es+vckhML6CwqSwgV65RXAlRZMWLbJFu15MMUKk8v2FW7P8yVmNtSfevXtU6CZVpi 1aXIT0xlmZQxoHDSB41Hd0M6Yl5gvFB9ndB/3MMRYkyK0SVbwmycZILJ34ScJgsEI1 MZkiuI/7TrNP63l93BvLPwohbV30RvwSgY0KJADjWYGGcJ4x2qNuqCiAWWW1CQej3z +CgXIt6LkEbIqhSbQyziW92oHc+fMua0o8X8/UXdgEeNT6MJ66KP0XhIvN7LfbQTlu zwj2I0fNQaXGsNv7zZnI7XS/xDrYK4X5emfstphKe1WOs4AyPbL86nShPFJAslBb0b kaYvjnNnjiEUA== From: Christian Brauner To: Jingbo Xu Cc: Christian Brauner , lizefan.x@bytedance.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, willy@infradead.org, joseph.qi@linux.alibaba.com, tj@kernel.org, jack@suse.cz, Roman Gushchin Subject: Re: [PATCH v3] writeback, cgroup: switch inodes with dirty timestamps to release dying cgwbs Date: Wed, 18 Oct 2023 11:07:20 +0200 Message-Id: <20231018-dinkelbrot-botanik-b119bb8f4989@brauner> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231014125511.102978-1-jefflexu@linux.alibaba.com> References: <20231014125511.102978-1-jefflexu@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1313; i=brauner@kernel.org; h=from:subject:message-id; bh=l4Oi5jf7qwP7CNkVZZNY8DYKTprQka+ShuoW7/Do0XQ=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaTqL9D597YqabVumacg890tWi7FOTdf1KYeag5488dwi5LI iveXOkpZGMS4GGTFFFkc2k3C5ZbzVGw2ytSAmcPKBDKEgYtTACYSm8vI0GzdrhQdq1mSnma6TOJwtz XT0uMtbxSiu66+2fQ6IyFgKiPDR7GfSf1cU1mbQo5t+FomoMy+3rL19dQL72xfbnh0TDCOCwA= X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 18 Oct 2023 02:07:47 -0700 (PDT) On Sat, 14 Oct 2023 20:55:11 +0800, Jingbo Xu wrote: > The cgwb cleanup routine will try to release the dying cgwb by switching > the attached inodes. It fetches the attached inodes from wb->b_attached > list, omitting the fact that inodes only with dirty timestamps reside in > wb->b_dirty_time list, which is the case when lazytime is enabled. This > causes enormous zombie memory cgroup when lazytime is enabled, as inodes > with dirty timestamps can not be switched to a live cgwb for a long time. > > [...] Applied to the vfs.misc branch of the vfs/vfs.git tree. Patches in the vfs.misc branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.misc [1/1] writeback, cgroup: switch inodes with dirty timestamps to release dying cgwbs https://git.kernel.org/vfs/vfs/c/27890db5162c