Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <d2ac3963-9c91-4256-a1e3-ea5990848c1e@arm.com>
Date:   Wed, 18 Oct 2023 10:16:21 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 5/6] energy_model: use a fixed reference frequency
To:     Vincent Guittot <vincent.guittot@linaro.org>
Cc:     dietmar.eggemann@arm.com, bristot@redhat.com,
        aou@eecs.berkeley.edu, palmer@dabbelt.com,
        paul.walmsley@sifive.com, conor.dooley@microchip.com,
        rostedt@goodmis.org, juri.lelli@redhat.com,
        viresh.kumar@linaro.org, suagrfillet@gmail.com,
        linux-pm@vger.kernel.org, ionela.voinescu@arm.com,
        vschneid@redhat.com, ajones@ventanamicro.com,
        catalin.marinas@arm.com, linux@armlinux.org.uk,
        linux-riscv@lists.infradead.org, pierre.gondois@arm.com,
        lftan@kernel.org, linux-kernel@vger.kernel.org, bsegall@google.com,
        mingo@redhat.com, rafael@kernel.org,
        linux-arm-kernel@lists.infradead.org, peterz@infradead.org,
        gregkh@linuxfoundation.org, mgorman@suse.de, will@kernel.org,
        sudeep.holla@arm.com
References: <20231009103621.374412-1-vincent.guittot@linaro.org>
 <20231009103621.374412-6-vincent.guittot@linaro.org>
Content-Language: en-US
From:   Lukasz Luba <lukasz.luba@arm.com>
In-Reply-To: <20231009103621.374412-6-vincent.guittot@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Vincent,


On 10/9/23 11:36, Vincent Guittot wrote:
> The last item of a performance domain is not always the performance point
> that has been used to compute CPU's capacity. This can lead to different
> target frequency compared with other part of the system like schedutil and
> would result in wrong energy estimation.
> 
> A new arch_scale_freq_ref() is available to return a fixed and coherent
> frequency reference that can be used when computing the CPU's frequency
> for an level of utilization. Use this function to get this reference
> frequency.
> 
> Energy model is never used without defining arch_scale_freq_ref() but
> can be compiled. Define a default arch_scale_freq_ref() returning 0
> in such case.
> 
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> ---
>   include/linux/energy_model.h | 14 +++++++++++---
>   1 file changed, 11 insertions(+), 3 deletions(-)
> 

LGTM, taking into account the patch 2/6 that we don't include any
boost freq (so no changes w.r.t. current EAS situation)

Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>