Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3689632rdg; Wed, 18 Oct 2023 03:16:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFiaLB78Nrj57ZVBc9losH+TZgE5htIs/+mkuBSO7sAdqtGTmdEcBnVOHTCbdK+B8oxu1xG X-Received: by 2002:a05:6870:b18:b0:1e9:b2e2:8754 with SMTP id lh24-20020a0568700b1800b001e9b2e28754mr4941741oab.2.1697624175643; Wed, 18 Oct 2023 03:16:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697624175; cv=none; d=google.com; s=arc-20160816; b=VrFIZPxm7ilgenJGX3sXoni3s0kFUGNRGzr5NuFunBBdZ/w0dhQ1Z9vS0H8ckyHTQl QpNlNAih/cDq82LFJZQw8QAjfGswBoB0vcjZRCf9yfoEv4qMvtjDvBRhTpsrLotngKI2 Adubm1BR9GxeweNtMoU/gecPmxzZ/zudyPpNf4Xe6XIwEaNTXvk47YrHxyQBzHFPNCS1 WqQehSGQcx+srwpGrIfCCRg8Fs+85mH3DgAbzGMNJ/7lQUQE26zuSG6ZqvIbBqQ+WbC0 nS50qdQ3F5uY2o9PIly9WoCAZvcqmjEh9xA9kVnTLzDmiKIVBshgFxtIlP3p9H7NQ1H7 iqLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=zrZeZUHSoL1y7Zn1OYAHHQ3FlMNWUG/86ZBm6S4qRb4=; fh=rRKRTKdDEQivjKV1/lwS85fAxDjUKsFomBhgFoMlGTc=; b=ahkhyjRSXgyZrjVoGJKPHC9WVd67lNtK61exibDCWZdZmweSe1l6okE4j7xtp5RxH3 CxJnlCyaSP7+r2vNNaei3oPSrMyOpMC59nSGEaZXg7n5DBWfWdHMnoWVAiW54je+hMVz aA8ugM1QMk0IakFVvCwsWVd6ABhviKBxM+/Prxb3pq70acgpbrCwfb2NHqAKsV5IYtVD DHe2KO/8iHXVS0K7aPIn+DbrcfjmSYEYS23OAARBnJ+GHNUc6ZOXpw8KHQPnGualVNQF Svk92cAinhnzszZCFtj08Icr6NS5zI1lVcQEeWcSzrelBF26iFnR/VRuB9qZV4kze4qj 2Zqg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id b6-20020a633406000000b00578b9fb24f6si1762057pga.616.2023.10.18.03.16.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 03:16:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 0E5CE80B1204; Wed, 18 Oct 2023 03:16:13 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229920AbjJRKQG (ORCPT + 99 others); Wed, 18 Oct 2023 06:16:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229570AbjJRKQE (ORCPT ); Wed, 18 Oct 2023 06:16:04 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 713D695 for ; Wed, 18 Oct 2023 03:16:03 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 912F9C433C8; Wed, 18 Oct 2023 10:16:01 +0000 (UTC) From: Catalin Marinas To: Will Deacon , Steven Price , Peter Collingbourne , Ryan Roberts Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64/mm: Hoist synchronization out of set_ptes() loop Date: Wed, 18 Oct 2023 11:15:59 +0100 Message-Id: <169762410085.3624197.15162390059059851386.b4-ty@arm.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231005140730.2191134-1-ryan.roberts@arm.com> References: <20231005140730.2191134-1-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 18 Oct 2023 03:16:13 -0700 (PDT) On Thu, 05 Oct 2023 15:07:30 +0100, Ryan Roberts wrote: > set_ptes() sets a physically contiguous block of memory (which all > belongs to the same folio) to a contiguous block of ptes. The arm64 > implementation of this previously just looped, operating on each > individual pte. But the __sync_icache_dcache() and mte_sync_tags() > operations can both be hoisted out of the loop so that they are > performed once for the contiguous set of pages (which may be less than > the whole folio). This should result in minor performance gains. > > [...] Applied to arm64 (for-next/misc), thanks! [1/1] arm64/mm: Hoist synchronization out of set_ptes() loop https://git.kernel.org/arm64/c/3425cec42c3c Also pushed the fix to mark 'addr' __always_unused. -- Catalin