Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3701424rdg; Wed, 18 Oct 2023 03:40:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH7tRGc1qSKOgbCYHSNxo9LzOIHLUzVerUcuSyePfjUi/cGa3IJ4r/goJBCkNbj6Q7xssHj X-Received: by 2002:a05:6359:6604:b0:166:a6e3:cba5 with SMTP id sm4-20020a056359660400b00166a6e3cba5mr4335194rwb.2.1697625616155; Wed, 18 Oct 2023 03:40:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697625616; cv=none; d=google.com; s=arc-20160816; b=jC9y/P8bLS3nmOCwqXqKUQl086ADzML2UgkYbs75iK+ieyXutQEdNoxp9GyXyK0RGI gR8/vONOEBciESN97q97cbohllWoAGkrX+YxICkpUrWIFoEMvZsKCYm4MOvN4Chs03Wd kX1CFD0tMB9p4qEsG2mdGjMar4Qpl84dZB+0i+LHuLbnN3Oo2y/Hk2i+5GLfUPHYfFKQ o34d3aVHq6JDcaFvsQeybEyR4aAOJfFSk3YYz5VLv3R8C7flImFaZe3wv+FzBLDmgj7t 1+bQ2ahs2JmMW3lKuXdtVsMLw3dzzdyhNJjUTea4K8MAPVTjOJHDBDT0lcDqSZfIP3Hp HnEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version; bh=uyfTe1QTN+dLogRbkGyOPIF+J67bas3fpPCDK+iSwIs=; fh=T7SwjnuyxtxSxZkrAEZ4rNFkZbrNiQY27IhM1/+GMbc=; b=SmISdz+JnzyvOTyErA9ueFWME+SUM2+gYGGq7pswFKEoHr2zpKjS2p15Gqu9A3yBwd dXlawRXxmFCT4JE5VOg9lky+5px1b26/ly2cTUCShHtSHd2AZjwn7YmDWb5FqIyKpUy9 P0zy9KI7RLhkQZkbtTXQq/G1WyrHh/fqrwqfuR13X/qUsrfohuKZkjyxGbb3CTniHMuD hDuQHtrKB6vCg24sehak1MD5v4IKsEIsTIBah6IFnsUCDTWWO2gr608xvRVcjAfpkjVA mnWhxlWuOaA7ALctUxNjlXPolG4RfVhY7VW+jf8Z1owPWNMxPdAsr7qMAkQF0W8OO6cD b1XQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id by19-20020a056a02059300b005b18b5da51asi2160086pgb.346.2023.10.18.03.40.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 03:40:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id C6E6B816EBE0; Wed, 18 Oct 2023 03:40:13 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234992AbjJRKkB convert rfc822-to-8bit (ORCPT + 99 others); Wed, 18 Oct 2023 06:40:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231730AbjJRKj7 (ORCPT ); Wed, 18 Oct 2023 06:39:59 -0400 Received: from mail-oo1-f43.google.com (mail-oo1-f43.google.com [209.85.161.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED8CDB0; Wed, 18 Oct 2023 03:39:57 -0700 (PDT) Received: by mail-oo1-f43.google.com with SMTP id 006d021491bc7-57de3096e25so1371002eaf.1; Wed, 18 Oct 2023 03:39:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697625597; x=1698230397; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wtmjII0ee1f21HN24SIPEYP9xZN9qMse1/pApzruflA=; b=PBNdeV+68fXXHjm1LL8loE6LLA0ek8xGQQaF+B0Hk51y83nm7lsIfsr3MOeBo2QOsQ wO35nMfKal3ekCiaDfSUqGnDx9enbWReIIwOX7Mus9zPDfnG2H+lj7kGsU3AjOtRuHEE 6lgMsKkX/vkXVFh6eR6cIxZjc/EHSmgbNXp9EfdhgvBvTzckHbaMpGbjQHCiP8MintRr yqizyy9okeyCi4wUgV+3nk8W6YwXBqCECgj4lu/px6IjjiP9KMFS+3C1C4MDYs/JvwJE YdX1NrZfG/DocQucLxCrlUuQDpw8/rCO2s4C4MK8qJQZ5DXU6X2XsSM21QwZ2v5O+eAM F+1Q== X-Gm-Message-State: AOJu0YzBZrT2JX+QuCUfoxpy/T8i6kuZFtDhzZrdvm+Ev+bvEs8WYosZ BuykQLpxTnr/5bJbywIHJTl2ZuHox4uBX7q2jRU= X-Received: by 2002:a4a:4f15:0:b0:581:e7b8:dd77 with SMTP id c21-20020a4a4f15000000b00581e7b8dd77mr3387616oob.1.1697625597298; Wed, 18 Oct 2023 03:39:57 -0700 (PDT) MIME-Version: 1.0 References: <20231017082905.1673316-1-michal.wilczynski@intel.com> <652f5eddba760_5c0d29449@dwillia2-mobl3.amr.corp.intel.com.notmuch> In-Reply-To: <652f5eddba760_5c0d29449@dwillia2-mobl3.amr.corp.intel.com.notmuch> From: "Rafael J. Wysocki" Date: Wed, 18 Oct 2023 12:39:46 +0200 Message-ID: Subject: Re: [PATCH v3] ACPI: NFIT: Use cleanup.h helpers instead of devm_*() To: Dan Williams Cc: Michal Wilczynski , nvdimm@lists.linux.dev, linux-acpi@vger.kernel.org, rafael@kernel.org, vishal.l.verma@intel.com, lenb@kernel.org, dave.jiang@intel.com, ira.weiny@intel.com, linux-kernel@vger.kernel.org, Andy Shevchenko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 18 Oct 2023 03:40:14 -0700 (PDT) On Wed, Oct 18, 2023 at 6:28 AM Dan Williams wrote: > > Michal Wilczynski wrote: > > The new cleanup.h facilities that arrived in v6.5-rc1 can replace the > > the usage of devm semantics in acpi_nfit_init_interleave_set(). That > > routine appears to only be using devm to avoid goto statements. The > > new __free() annotation at variable declaration time can achieve the same > > effect more efficiently. > > > > There is no end user visible side effects of this patch, I was > > motivated to send this cleanup to practice using the new helpers. > > > > Suggested-by: Dave Jiang > > Suggested-by: Andy Shevchenko > > Reviewed-by: Dave Jiang > > Reviewed-by: Andy Shevchenko > > Signed-off-by: Michal Wilczynski > > --- > > > > Dan, would you like me to give you credit for the changelog changes > > with Co-developed-by tag ? > > Nope, this looks good to me, thanks for fixing it up. > > Reviewed-by: Dan Williams Are you going to apply it too, or should I take it?