Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <cf483cb5-7d94-9514-2213-46778b5ac9f4@intel.com>
Date:   Wed, 18 Oct 2023 12:40:33 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] staging: rts5208: Replace delay function.
Content-Language: en-US
To:     Julia Lawall <julia.lawall@inria.fr>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        kenechukwu maduechesi <maduechesik@gmail.com>,
        <outreachy@lists.linux.dev>, <shreeya.patel23498@gmail.com>,
        <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
References: <20231018004300.GA3189@ubuntu>
 <7bc719c4-459f-3d8-7ed-b1e1adf158@inria.fr>
 <1118ec6d-e1e7-79f3-08e4-9a79c996eed1@intel.com>
 <2023101853-axis-stylist-f1b9@gregkh>
 <7dde176b-1059-e9a4-a023-0243cce61d01@intel.com>
 <12b375b1-acd3-476e-17bc-b4db22efba69@inria.fr>
From:   Karolina Stolarek <karolina.stolarek@intel.com>
Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298
 Gdansk - KRS 101882 - NIP 957-07-52-316
In-Reply-To: <12b375b1-acd3-476e-17bc-b4db22efba69@inria.fr>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cEd6U3NpMjl3emtjZXB2K0JuZ29WS1kyY1ZvQjRvZG1ZUGMxWTdnNGpXYjFV?=
 =?utf-8?B?NnpvazZqa2xaSUkyTm81cVZOWXB1ZFRiSW9lZG8xc1NDekk1TElaNzFkSC9V?=
 =?utf-8?B?emdDQ29GQTg5cE5nVkgwQksyMlVvVllrSW90Q3RZSjZYSGxLVXUyRENERVRk?=
 =?utf-8?B?dXVhS2Yzemgxc3dwZVRQWDN2SDJpRTdYellOS0FCL1pyNm5tSm1XTGR4c3ZU?=
 =?utf-8?B?aEpMd0liZVNPbDR2ZEd6bDJFd2VLOTI1NE4yRWNzd255MENjYVUybVkwS255?=
 =?utf-8?B?WEMvMmdDVU83V003Y1IrM2FUQ3IrZnR6Q010S0VrUHdyU25DQklWQzVhWXdl?=
 =?utf-8?B?RjEwMUNDeVcxQ2tKeU1xVkNKRUVoQ3Y0cDlOdmszNDZTbTc4NC9BR09xQkdw?=
 =?utf-8?B?dTBxazZzRUNReVNaTGlXSWRZL1o0YlRjbi9ZVnlMOTM4OG0rVDYrRlZVenFL?=
 =?utf-8?B?cFc4NE9uQk9XQjkxcEhodmdiaHRXeTdaakJvdWM2Q0p1WnUzYXBYUnVDM3V2?=
 =?utf-8?B?VER3NVNBLzQxb1pRUzdDNnBkdlluQlBuVWRPbktEeldydUJGcnVrN2tNM25N?=
 =?utf-8?B?d2k2YkZMN3RPckpFWlEyTUtiS0g4ZTlRVjNGcDU5ZE00am5iU3kxeTYveDZO?=
 =?utf-8?B?UldGSW1WMTdFR1hyVG1VbHVXWHh3VDdzUnRrazgzVXk4OUJ1RzUzSUtnRTVK?=
 =?utf-8?B?WU9STC9VeW10RDc5eWlSUUx1enFGbVhYbVpDeW9Wajk0UUNITHZnazVmQm5s?=
 =?utf-8?B?aUNtN1F1VG42SVdqK3ovbjMwajUvVlltWmZjaXpaM1dYV2RuZUNoS05TK1By?=
 =?utf-8?B?K2hBbWVtM2lmK3czV0Rsb3E5YjNNMUVJeHZtYURibElzNUNET3lUK295K08y?=
 =?utf-8?B?OWozZFdrRVpqcGl0Z0ZOZ0RCdk9KREl6VnRDbC9iQWFrY0ZaWG82NVJ5ZHQ3?=
 =?utf-8?B?WVBGTm9wNzlRMkFYWUFxWVhpWFZqaC8vRFk3UElNc0FtblAwWHRRZGhWd3hB?=
 =?utf-8?B?WEduV3h4U3pZV3d0SkZsaVhJdjJZa2x5TXZoVm9NUm5EUFZrQ3ZMNTRaTVBX?=
 =?utf-8?B?QkxVWkd2emlYWE1LVVFsUFY0TDJDaVV5ckpmWDZPM2lLQ21TS3RBbEE1RVU4?=
 =?utf-8?B?em11RDhUZG14S2JQbEs1WFdxMW9TN0VBZEdYYVpOYy9GWHFQaElPdXlhSERv?=
 =?utf-8?B?S0J1VWJLSm0yT0ovNzk4ckVELzJnTXAzblQzNG9uQWRkMHBhNkpzdEtJUGlG?=
 =?utf-8?B?RVYyWDJqeHcxRStDOFY4TWNYOWFYRDJ2dXpYMDNhT1I3K0RiTnQ3aXl6UWhp?=
 =?utf-8?B?Zjh5blZ2UVE0YXRjL01pYzNPaWVWNldkMGR1eGlLMlE3c01Ub0krcTZxd3No?=
 =?utf-8?B?WG9ERWZJcFNYbVZhZHA4VkdBYUdZME5zdWtCajRtVmxhSmd4K3BIOXlxOVgx?=
 =?utf-8?B?Y0dzMFpzZ2pLMzAxUUY2NEFKTTNacU9UcjZIY0NSVUtLdndZRW1KZHFOWUg0?=
 =?utf-8?B?K2tWS0dnek9GN0Z6RCtpeHZTZlN1RjVqN1phQzhXTnFURDJtdkR2U2ZQaGFy?=
 =?utf-8?B?djhRZkdJZnhicW54R2ZZYWNYNzJWRFB4ZHhqckFkYkFDZjRvaThqWHlHUFFY?=
 =?utf-8?B?NXVMbEI3cy93UlQ0RGROaTJOZ0drZEFDUkV5QkZQR05SU3A5S2dmN2VYVnB5?=
 =?utf-8?B?MU9DUkdjY2dPdENKZGk0UUJPNExQb1pvOWl4SzBkb1pTZUNITjc3aC84UGUv?=
 =?utf-8?B?MEk2WkJMcXBndXZtYVpRMURDaWNqUjNJOTB1VlhrRHc5ZVlRUWVPbzRSSTh5?=
 =?utf-8?B?UzJnOU4xa21GZDM5ZGswaVRQM0pvaXZnNEVhSmtyRFpKcG0rYWQwN0FlMnJT?=
 =?utf-8?B?c1U3YVBxOEdYdmtRTWhRcmRUT0VuZm5CcTM2eENBaStudHVhb3hZY01JZFlJ?=
 =?utf-8?B?b1VLWGx0MTV0VnJnclEwSmkramI2UTdWd0VHR3VLNXJCSGRoMnB0K0tWWWE3?=
 =?utf-8?B?K3Foak1LeWhvVkwvSUl4SnJTUFg4S3hReHQ5Vnh6Z0RTUjJvNjZ6djI4UWtB?=
 =?utf-8?B?VWRmNXdYd09hcTNUOW5GWEh0Q0pMUnNPdWRqRC92V1QwN1NCdWxsdi9ZKzZV?=
 =?utf-8?B?YVJvdFFsTHh0ai9wWGlOYnZPTWdCbUpJV0tQVzNWSHpXcTYxQU5aL2hDUGlo?=
 =?utf-8?B?NWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ae44ebe0-c787-4779-500e-08dbcfc6a3f7
X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4243.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 10:40:26.5595
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3nEEYoxoqQTe4lMEgm3pZDFZ8d5o/BiDikJAPRb/oKxlixdcqkc1YZyyo4xqVfj1y+wUJNvRL5ULnb9ECgq/j77TMoLlUOi2cER/buTMU0U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5582
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 18 Oct 2023 03:40:42 -0700 (PDT)

On 18.10.2023 12:28, Julia Lawall wrote:
> 
> 
> On Wed, 18 Oct 2023, Karolina Stolarek wrote:
> 
>> On 18.10.2023 09:45, Greg Kroah-Hartman wrote:
>>> On Wed, Oct 18, 2023 at 09:32:46AM +0200, Karolina Stolarek wrote:
>>>> On 18.10.2023 09:03, Julia Lawall wrote:
>>>>>
>>>>>
>>>>> On Tue, 17 Oct 2023, kenechukwu maduechesi wrote:
>>>>>
>>>>>> Replace udelay() with usleep_range() for more precise delay handling.
>>>>>>
>>>>>> Reported by checkpatch:
>>>>>>
>>>>>> CHECK: usleep_range is preferred over udelay
>>>>>
>>>>> This message is typically not a good candidate for outreachy patches,
>>>>> because you need access to the device to be sure that any change is
>>>>> correct.
>>>>
>>>> Could we add a paragraph on how to pick good checkpatch.pl error to fix to
>>>> the Outreachyfirstpatch docs? This could go to "Find a driver to clean up"
>>>> section, for example.
>>>
>>> The ability to find a "good" error changes over time, so this might be
>>> hard to do.
>>
>> I agree, but we can all agree that experimenting with udelay during Outreachy
>> is not a good idea, and people should know about it
> 
> In general, I think that it is better in the contribution period to do the
> wrong thing and then learn about why it is wrong, but this case comes up
> over and over, and it is always not the right thing to do, so I added an
> appropriate explanation.  Thanks for the suggestion.

Absolutely. Thanks for the docs update. Still, one thing -- is empty 
section after "Some drivers that are on their way out of the kernel 
are:" intentional?

All the best,
Karolina

> 
> julia
> 
>>
>> All the best,
>> Karolina
>>
>>>
>>> good luck!
>>>
>>> greg k-h
>>