Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 18 Oct 2023 12:56:38 +0200
From:   Florian Eckert <fe@dev.tdt.de>
To:     Jiri Slaby <jirislaby@kernel.org>
Cc:     Eckert.Florian@googlemail.com, gregkh@linuxfoundation.org,
        pavel@ucw.cz, lee@kernel.org, kabel@kernel.org,
        u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org,
        linux-serial@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v3 1/4] tty: whitespaces in descriptions corrected by
 replacing tabs with spaces.
In-Reply-To: <31ec59fb-4bcf-4c70-996a-ea67b4bfcd2b@kernel.org>
References: <20231016071332.597654-1-fe@dev.tdt.de>
 <20231016071332.597654-2-fe@dev.tdt.de>
 <31ec59fb-4bcf-4c70-996a-ea67b4bfcd2b@kernel.org>
Message-ID: <fb73fa183cf6619e042273db091056bd@dev.tdt.de>
User-Agent: Roundcube Webmail/1.3.17
Precedence: bulk


On 2023-10-16 14:32, Jiri Slaby wrote:
> On 16. 10. 23, 9:13, Florian Eckert wrote:
>> Tabs were used in the function description, to make this look more
>> uniform, the tabs were replaced by spaces where necessary.
>> 
>> Signed-off-by: Florian Eckert <fe@dev.tdt.de>
> 
> Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

Thanks for the review and adding your 'Reviewed-by:'.
Will add this to the v4 if I get feedback form the led
subsystem maintainers, if my change to ledtrig-tty are
correct. So this could get into for-led-next [1]
maintained by Lee Jones <lee@kernel.org>


> LGTM (spihnx prefers spaces), except:
> 
>> @@ -3470,7 +3470,7 @@ int tty_register_driver(struct tty_driver 
>> *driver)
>>   EXPORT_SYMBOL(tty_register_driver);
>>     /**
>> - * tty_unregister_driver -- unregister a tty driver
>> + * tty_unregister_driver - unregister a tty driver
> 
> you should have noted you changed ndashes to dashes too. (As only the
> latter is supported by sphinx.)

That was intentional.
However, I did not mention it in the commit message.
My mistake. Sorry.
Will add this to the information to an v4.

--
Florian

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git/log/?h=for-leds-next