Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <97067546-784c-bb42-fe1c-14348b70e65f@quicinc.com>
Date:   Wed, 18 Oct 2023 16:27:46 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.14.0
Subject: Re: [PATCH V2 3/4] clk: qcom: Add ECPRICC driver support for QDU1000
 and QRU1000
Content-Language: en-US
To:     Stephen Boyd <sboyd@kernel.org>, Andy Gross <agross@kernel.org>,
        "Bjorn Andersson" <andersson@kernel.org>,
        Conor Dooley <conor+dt@kernel.org>,
        "Konrad Dybcio" <konrad.dybcio@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>
CC:     Taniya Das <quic_tdas@quicinc.com>,
        <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Ajit Pandey <quic_ajipan@quicinc.com>,
        Jagadeesh Kona <quic_jkona@quicinc.com>
References: <20231011090028.1706653-1-quic_imrashai@quicinc.com>
 <20231011090028.1706653-4-quic_imrashai@quicinc.com>
 <c656a6b8ac2feefda16e6d1d548a9f80.sboyd@kernel.org>
From:   Imran Shaik <quic_imrashai@quicinc.com>
In-Reply-To: <c656a6b8ac2feefda16e6d1d548a9f80.sboyd@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/13/2023 1:49 AM, Stephen Boyd wrote:
> Quoting Imran Shaik (2023-10-11 02:00:27)
>> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
>> index 3194c8beb06d..60a981ff2bac 100644
>> --- a/drivers/clk/qcom/Kconfig
>> +++ b/drivers/clk/qcom/Kconfig
>> @@ -667,6 +667,14 @@ config QDU_GCC_1000
>>            QRU1000 devices. Say Y if you want to use peripheral
>>            devices such as UART, SPI, I2C, USB, SD, PCIe, etc.
>>   
>> +config QDU_ECPRICC_1000
>> +       tristate "QDU1000/QRU1000 ECPRI Clock Controller"
> 
> This needs a 'depends on ARM64 || COMPILE_TEST' type of line here.
> 

Sure, will add this in the next series.

>> +       select QDU_GCC_1000
>> +       help
>> +         Support for the ECPRI clock controller on QDU1000 and
>> +         QRU1000 devices. Say Y if you want to support the ECPRI
>> +         clock controller functionality such as Ethernet.
>> +
>>   config SDM_GCC_845
>>          tristate "SDM845/SDM670 Global Clock Controller"
>>          depends on ARM64 || COMPILE_TEST
>> diff --git a/drivers/clk/qcom/ecpricc-qdu1000.c b/drivers/clk/qcom/ecpricc-qdu1000.c
>> new file mode 100644
>> index 000000000000..e26912f3dd39
>> --- /dev/null
>> +++ b/drivers/clk/qcom/ecpricc-qdu1000.c
>> @@ -0,0 +1,2466 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +/*
>> + * Copyright (c) 2022-2023, Qualcomm Innovation Center, Inc. All rights reserved.
>> + */
>> +
>> +#include <linux/clk-provider.h>
>> +#include <linux/module.h>
>> +#include <linux/of.h>
> 
> What is the of.h include for? Did you mean mod_devicetable.h instead of
> of_device_id?
> 

Yes, will remove of.h and use mod_devicetable.h in the next series.

Thanks,
Imran

>> +#include <linux/platform_device.h>
>> +#include <linux/regmap.h>
>> +