Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3719082rdg; Wed, 18 Oct 2023 04:14:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGVDwMsf0z4GCWWXyR33KmLEoIamMZPchyeHJRpvRDAK80DKjSc+6JFB6NOs1rCxCWktm6H X-Received: by 2002:a17:903:2443:b0:1c9:dece:4c4c with SMTP id l3-20020a170903244300b001c9dece4c4cmr7849572pls.15.1697627664446; Wed, 18 Oct 2023 04:14:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697627664; cv=none; d=google.com; s=arc-20160816; b=S+3GT2JYZbE5kYgcBdfrpvBcWRHmBKC2aa8nmA5M554B/BpG2JfLCtyJs4Dv7yw3S1 F6wzuYVnLgRzYpilHzETwZUMVKT5J6ph+rZ2daKCUNu3HGdA6xykLhRstOVnXaTR+bMI 1srJzZu0nmIsqalTt6w7NOV2qV7v/J5R016ww3cgKWHuWq6HZTmuB3jcfFLu0/i814Co 0FU8xSkvUSTQLLyHfml3HHtRY3jBcLAa2YNwh/LKVS55tVrNG1OJs9lIA5PirJbsHcA1 4XVJjG81EeDYBvhPTKQ83piDNczY9eT42tMSaBKrVuEzpX8+J5dKLOht4jsAJZZU1Gst CotA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version; bh=uVtDHBeQFjKKuch5ozEF4yLTYmbGMDBHTQWE1kA9c7s=; fh=qFWrjaJTwB270f7BUrGvMxXJkDZklnuiUbZdTqCBDTI=; b=F22D1zKXqQ9KuHbZr8gNIlGrWCr3sU5p0gjZlsCPiIrCipr8QSgBjluKJTZezMim+V Yim5tr7lAoOlj2WnL+gYkAnl1hAzWgSwJgdZ7sAF2ZyeQ+EhCLfuhiEdM2pwFNCqH6+f +BHk5JWBnDBFbvQ8aziWgM8hmxLuF6VSuUo+ShkUrSkp1//Pd6Z3XWoq97iP+BoADWht Bp4kEWNNZV0kTvJY+8Jd++nAPHN2T2fP3qTuIzG2gt8dyOVrjNJUul3PWfqQo9ALAKjR F8T6Y1WXvzyV0Ud323rhNLnmDMIWNwFvwWhMfuoFxWZ1XPP0O6KZuZmrBJUqb2eXxsus +SHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id kg14-20020a170903060e00b001b89551a392si3731857plb.113.2023.10.18.04.14.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 04:14:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 20E5A8114EF0; Wed, 18 Oct 2023 04:14:21 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230255AbjJRLNp convert rfc822-to-8bit (ORCPT + 99 others); Wed, 18 Oct 2023 07:13:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230242AbjJRLNg (ORCPT ); Wed, 18 Oct 2023 07:13:36 -0400 Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5C4F10F; Wed, 18 Oct 2023 04:13:34 -0700 (PDT) Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-57bf04841ccso1376125eaf.0; Wed, 18 Oct 2023 04:13:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697627614; x=1698232414; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o9BSIDSxSdsjvE34XyGwJrHtCdQ+4sCjaON3ksE44JE=; b=gjVpQ+HIJnhRDsX72ZR37HfJEQL5hJA+Z5Mvokf0tKUd4rICNfVwQpmWfwnLVCVgkw zBj93RL/++M6DObn524bYhvwypzyobqO1fy2zWhAJWR9dOyIz3kdmPDNDSds6Z/Hzihp TyV4mY8RPpnpVz6LTw2mHVnSYJ5/rIiBokI3bx0z3JJomTjxHrj2uMWT0OKbyteQN9aF OQT/EoFLXP7YxInFJRcLBM1ImzpN71m/Y+lgDqVU71rYcdiiGPv86eKLMla9Q7vBfHp4 IuPRy+Q1YWFQ8XjQFwB5JJ1aIj6s4pcVMbwxIG4BPxDyGdDa9InoLGl34822ncmALLpb JaQw== X-Gm-Message-State: AOJu0YyClGiG22Qic8vxorc4ZZv8vFqpTSlKDy/j80oviyf/Jz2SWwxz Nbz5m5tABA5cGQTmyXeMgm3tpqQGOeEu/lqcx6Q= X-Received: by 2002:a4a:ee94:0:b0:581:5990:dbb8 with SMTP id dk20-20020a4aee94000000b005815990dbb8mr4901446oob.0.1697627614027; Wed, 18 Oct 2023 04:13:34 -0700 (PDT) MIME-Version: 1.0 References: <20231016170939.1192260-1-sunilvl@ventanamicro.com> In-Reply-To: <20231016170939.1192260-1-sunilvl@ventanamicro.com> From: "Rafael J. Wysocki" Date: Wed, 18 Oct 2023 13:13:23 +0200 Message-ID: Subject: Re: [PATCH] ACPI: irq: Fix the incorrect return value in acpi_register_gsi() To: Sunil V L Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J . Wysocki" , Len Brown , Lorenzo Pieralisi , Agustin Vega-Frias , Hanjun Guo , Marc Zyngier , Anup Patel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 18 Oct 2023 04:14:21 -0700 (PDT) On Mon, Oct 16, 2023 at 7:09 PM Sunil V L wrote: > > acpi_register_gsi() should return negative value in case of failure. > Currently, it returns the return value from irq_create_fwspec_mapping(). > However, irq_create_fwspec_mapping() returns 0 for failure. Fix the issue > by returning -EINVAL if irq_create_fwspec_mapping() returns zero. > > Fixes: d44fa3d46079 ("ACPI: Add support for ResourceSource/IRQ domain mapping") > Signed-off-by: Sunil V L > --- > drivers/acpi/irq.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/irq.c b/drivers/acpi/irq.c > index c2c786eb95ab..403f33df66af 100644 > --- a/drivers/acpi/irq.c > +++ b/drivers/acpi/irq.c > @@ -57,6 +57,7 @@ int acpi_register_gsi(struct device *dev, u32 gsi, int trigger, > int polarity) > { > struct irq_fwspec fwspec; > + unsigned int rc; > > fwspec.fwnode = acpi_get_gsi_domain_id(gsi); > if (WARN_ON(!fwspec.fwnode)) { > @@ -68,7 +69,11 @@ int acpi_register_gsi(struct device *dev, u32 gsi, int trigger, > fwspec.param[1] = acpi_dev_get_irq_type(trigger, polarity); > fwspec.param_count = 2; > > - return irq_create_fwspec_mapping(&fwspec); > + rc = irq_create_fwspec_mapping(&fwspec); > + if (!rc) > + return -EINVAL; > + > + return rc; > } > EXPORT_SYMBOL_GPL(acpi_register_gsi); > > -- Good catch! Applied as 6.7 material, but I renamed the new rc local variable to irq. Thanks!