Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Wed, 18 Oct 2023 12:35:55 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Charlie Jenkins <charlie@rivosinc.com>
Cc:     linux-riscv@lists.infradead.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Eric Biederman <ebiederm@xmission.com>,
        Kees Cook <keescook@chromium.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>
Subject: Re: [PATCH v4 0/2] riscv: Add remaining module relocations and tests
Message-ID: <20231018-smite-bungee-f46b15b4ce6f@spud>
References: <20231017-module_relocations-v4-0-937f5ef316f0@rivosinc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="1okcQQvN+RgqgcjX"
Content-Disposition: inline
In-Reply-To: <20231017-module_relocations-v4-0-937f5ef316f0@rivosinc.com>
Precedence: bulk


--1okcQQvN+RgqgcjX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey Charlie,

On Tue, Oct 17, 2023 at 10:34:15PM -0700, Charlie Jenkins wrote:
> A handful of module relocations were missing, this patch includes the
> remaining ones. I also wrote some test cases to ensure that module
> loading works properly. Some relocations cannot be supported in the
> kernel, these include the ones that rely on thread local storage and
> dynamic linking.
>=20
> ULEB128 handling is a bit special because SET and SUB relocations must
> happen together, and SET must happen before SUB. A psABI proposal [1]
> mandates that the first SET_ULEB128 that appears before a SUB_ULEB128
> is the associated SET_ULEB128.
>=20
> This can be tested by enabling KUNIT, RUNTIME_KERNEL_TESTING_MENU, and
> RISCV_MODULE_LINKING_KUNIT.
>=20
> [1] https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/403
>=20
> Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> ---
> Changes in v4:
> - Complete removal of R_RISCV_RVC_LUI
> - Fix bug in R_RISCV_SUB6 linking
> - Only build ULEB128 tests if supported by toolchain
> - Link to v3: https://lore.kernel.org/r/20231016-module_relocations-v3-0-=
a667fd6071e9@rivosinc.com

On patch 2/2:

=2E./arch/riscv/kernel/tests/module_test/test_uleb128.S:18:17: error: unkno=
wn relocation name
=2E./arch/riscv/kernel/tests/module_test/test_uleb128.S:19:17: error: unkno=
wn relocation name

Same toolchain configuration in the patchwork automation as before.

Cheers,
Conor.

>=20
> Changes in v3:
> - Add prototypes to test_module_linking_main as recommended by intel
>   zero day bot
> - Improve efficiency of ULEB128 pair matching
> - Link to v2: https://lore.kernel.org/r/20231006-module_relocations-v2-0-=
47566453fedc@rivosinc.com
>=20
> Changes in v2:
> - Added ULEB128 relocations
> - Link to v1: https://lore.kernel.org/r/20230913-module_relocations-v1-0-=
bb3d8467e793@rivosinc.com
>=20
> ---
> Charlie Jenkins (2):
>       riscv: Add remaining module relocations
>       riscv: Add tests for riscv module loading
>=20
>  arch/riscv/Kconfig.debug                           |   1 +
>  arch/riscv/include/uapi/asm/elf.h                  |   5 +-
>  arch/riscv/kernel/Makefile                         |   1 +
>  arch/riscv/kernel/module.c                         | 207 +++++++++++++++=
+++---
>  arch/riscv/kernel/tests/Kconfig.debug              |  35 ++++
>  arch/riscv/kernel/tests/Makefile                   |   1 +
>  arch/riscv/kernel/tests/module_test/Makefile       |  15 ++
>  .../tests/module_test/test_module_linking_main.c   |  85 +++++++++
>  arch/riscv/kernel/tests/module_test/test_set16.S   |  23 +++
>  arch/riscv/kernel/tests/module_test/test_set32.S   |  20 ++
>  arch/riscv/kernel/tests/module_test/test_set6.S    |  23 +++
>  arch/riscv/kernel/tests/module_test/test_set8.S    |  23 +++
>  arch/riscv/kernel/tests/module_test/test_sub16.S   |  22 +++
>  arch/riscv/kernel/tests/module_test/test_sub32.S   |  22 +++
>  arch/riscv/kernel/tests/module_test/test_sub6.S    |  22 +++
>  arch/riscv/kernel/tests/module_test/test_sub64.S   |  27 +++
>  arch/riscv/kernel/tests/module_test/test_sub8.S    |  22 +++
>  arch/riscv/kernel/tests/module_test/test_uleb128.S |  20 ++
>  18 files changed, 548 insertions(+), 26 deletions(-)
> ---
> base-commit: 4d320c2d9a2b22f53523a1b012cda17a50220965
> change-id: 20230908-module_relocations-f63ced651bd7
> --=20
> - Charlie
>=20

--1okcQQvN+RgqgcjX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZS/DGwAKCRB4tDGHoIJi
0gMDAP0WbgwU87WIuhP0GqZRc4filSavgJ3pf5gzvnAAYbBAPAEAuuKUU48p/pb4
cjTzJOq1xJ30NhLxK8Npc0BLQvqxpwU=
=tuJ6
-----END PGP SIGNATURE-----

--1okcQQvN+RgqgcjX--