Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Subject: Re: [PATCH v2 8/8] LoongArch: Add ORC unwinder support
To:     kernel test robot <lkp@intel.com>,
        Josh Poimboeuf <jpoimboe@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Huacai Chen <chenhuacai@kernel.org>
References: <1696856590-30298-9-git-send-email-yangtiezhu@loongson.cn>
 <202310102113.bw7w3ZVv-lkp@intel.com>
Cc:     oe-kbuild-all@lists.linux.dev, loongarch@lists.linux.dev,
        linux-kernel@vger.kernel.org, loongson-kernel@lists.loongnix.cn
From:   Tiezhu Yang <yangtiezhu@loongson.cn>
Message-ID: <b30b034d-46ee-618b-5f92-b0f7dde1219a@loongson.cn>
Date:   Wed, 18 Oct 2023 19:44:54 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <202310102113.bw7w3ZVv-lkp@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/10/2023 09:46 PM, kernel test robot wrote:
> Hi Tiezhu,
>
> kernel test robot noticed the following build errors:

...

>    In file included from scripts/sorttable.c:201:
>>> scripts/sorttable.h:96:10: fatal error: 'asm/orc_types.h' file not found
>    #include <asm/orc_types.h>
>             ^~~~~~~~~~~~~~~~~
>    1 error generated.

Thanks for your report, I can reproduce the error on x86:

   make ARCH=x86_64 olddefconfig
   make ARCH=x86_64 prepare

The build error is related with "ARCH=x86_64", there is no error
without "ARCH=x86_64" when build locally on x86.

As described in Documentation/kbuild/makefiles.rst:

   For example, you can pass in ARCH=i386, ARCH=x86_64, or ARCH=x86.
   For all of them, SRCARCH=x86 because arch/x86/ supports both i386 and
   x86_64.

we should use SRCARCH instead of ARCH to specify the directory,
like this:

diff --git a/scripts/Makefile b/scripts/Makefile
index 576cf64..e4cca53 100644
--- a/scripts/Makefile
+++ b/scripts/Makefile
@@ -31,9 +31,12 @@ HOSTLDLIBS_sign-file = $(shell $(HOSTPKG_CONFIG) 
--libs libcrypto 2> /dev/null |

  ifdef CONFIG_UNWINDER_ORC
  ifeq ($(ARCH),x86_64)
-ARCH := x86
+SRCARCH := x86
  endif
-HOSTCFLAGS_sorttable.o += -I$(srctree)/tools/arch/x86/include
+ifeq ($(ARCH),loongarch)
+SRCARCH := loongarch
+endif
+HOSTCFLAGS_sorttable.o += -I$(srctree)/tools/arch/$(SRCARCH)/include
  HOSTCFLAGS_sorttable.o += -DUNWINDER_ORC_ENABLED
  endif

I will update the related code of this patch in the next version.

Thanks,
Tiezhu