Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3736926rdg; Wed, 18 Oct 2023 04:52:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHpPYOqva1s8o6uPuIOkj9TI39PmTJIYIDoxnEEtbIg2ZNazXfMuVraQGRxZ/BQwk5s3tLy X-Received: by 2002:a05:6a20:2454:b0:171:8e16:ea83 with SMTP id t20-20020a056a20245400b001718e16ea83mr4790031pzc.29.1697629938881; Wed, 18 Oct 2023 04:52:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697629938; cv=none; d=google.com; s=arc-20160816; b=BzTubkuZHzU0UqSWBtRDc+0o6ddcgD8gm2if8H6uH8OGTch+3/GbFYE1YZWDmalOXc fB3G4yl5R6IsErhg2+bxcR8IWQEpJjUHLXVwsrzihtOCixGdn2inxDlzYzhyAI9LHhGt 0exZjjZMvAdu1+obnmPgZHGGrqF5MVbqLkUrvjpS+l76oEcCn80i7d81AR8D91MGCaKC 8Q3m8BhV2C9qCw0S4k8tEMGBVfHHBcYGLfmXcmVDkwDnHPjXh6n6AD0MCKE021+pyNJR QPKLF6OybsQFR8xaqCAni/fut6eZ4n1CN857mhFVekIW4ROFTZZLo1gu7xkPW9VWe5wn BITA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zcX7ZL1gOPlfHqAjKVrqBYRvNVx1XuuYhppto2PqEpc=; fh=VTfF2Iqn5Ate7kkTb8XYGKs7n6Wqvc2VvxBRt9YGjHY=; b=OVyrN4yFjscnfKFtrsujSk5SJ0c7CaoxOKpcPcjnwvOKBDma3lyJmT24R1Ek690YzI Sz5S3thoLmfMCRgI9tp8b2MTljqjrKnQ1I7NCIZWo7QvN55I81GXNEaT/75qnh48Tv9q 7O3v5RP0FqN/RXsxVE+zpb97eVPHzeoDna4x2lOgdly9v1I4/JuyXG5kTh7VCDw2XwmA hASUSABzFLV7MOYH1dxqFLhBhTMu6KVlgexhYfdcD4ix3uG2OqOINk3qqb0uPuw7FPpe jJa5XQRBfNyuR/lByYTQg8lFK+rEwSjuSWhvgSt0eAHvAve4GvOiDx/sAx2pXE27Dx9/ MqlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=oO0lksra; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id u185-20020a6385c2000000b00584e65212d4si1930214pgd.609.2023.10.18.04.52.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 04:52:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=oO0lksra; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id E8470812D231; Wed, 18 Oct 2023 04:52:17 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230158AbjJRLwN (ORCPT + 99 others); Wed, 18 Oct 2023 07:52:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229884AbjJRLwL (ORCPT ); Wed, 18 Oct 2023 07:52:11 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43077F7 for ; Wed, 18 Oct 2023 04:52:10 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55728C4339A; Wed, 18 Oct 2023 11:52:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1697629929; bh=UopBtqacF4WHZUsTSn8SmKKNmQaJnPvKcVtqWzXGU40=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oO0lksrazyiuypVV8kmPpxXFR/lvNdkR5cPzDqdH9RQamRkz94DUdlrkMxnqSuRNp lBL2HLYnQkzRKfi0wBlkKsouhMqaq/bti8FxQj8UISaa+5EtazaptJYdYDsO5ssZSh T8pePuXDW6PkKlCcWE4qL+USBfIiomnuc8xYzjOA= Date: Wed, 18 Oct 2023 13:52:07 +0200 From: Greg Kroah-Hartman To: Leon Romanovsky Cc: Saeed Mahameed , Arnd Bergmann , linux-kernel@vger.kernel.org, Jason Gunthorpe , Jiri Pirko , Saeed Mahameed Subject: Re: [PATCH 2/5] misc: mlx5ctl: Add mlx5ctl misc driver Message-ID: <2023101821-impotence-confirm-d096@gregkh> References: <20231018081941.475277-1-saeed@kernel.org> <20231018081941.475277-3-saeed@kernel.org> <2023101835-trapdoor-unicycle-788a@gregkh> <20231018084908.GF5392@unreal> <2023101814-thirsting-culture-1a4c@gregkh> <20231018100014.GG5392@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231018100014.GG5392@unreal> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 18 Oct 2023 04:52:18 -0700 (PDT) On Wed, Oct 18, 2023 at 01:00:14PM +0300, Leon Romanovsky wrote: > On Wed, Oct 18, 2023 at 10:55:35AM +0200, Greg Kroah-Hartman wrote: > > On Wed, Oct 18, 2023 at 11:49:08AM +0300, Leon Romanovsky wrote: > > > On Wed, Oct 18, 2023 at 10:30:00AM +0200, Greg Kroah-Hartman wrote: > > > > On Wed, Oct 18, 2023 at 01:19:38AM -0700, Saeed Mahameed wrote: > > > > > +// SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB > > > > > > > > For dual-licensed code, I need a LOT of documentation as to why this > > > > must be dual-licensed, AND a signed-off-by from your corporate lawyer > > > > agreeing to it so they convey an understanding of just how complex and > > > > messy this will get over time and what you are agreeing to do here. > > > > > > This is how we (NBU, Networking Business Unit in Nvidia, former Mellanox) > > > are instructed to submit all our code by default. This license is aligned > > > with our networking, vdpa and RDMA code. > > > > Please don't do this without a really really good reason. Especially > > for a "misc" driver that is so linux-dependant here. > > Like I said, it is our default license. Saeed will change this code to be GPL-only. > > > The "Linux-OpenIB" license is old, obsolete, and problematic and should not be added to any > > new files in the kernel tree, outside of the island of > > drivers/infiniband/ as you all insist on that crazyness there. > > > > Heck, it's even documented that you shouldn't be adding that license to > > any new files, why ignore that? > > I don't remember being asked about it, not in this patch > https://lore.kernel.org/all/20180425203703.568152337@linutronix.de/ > and not in this later patch which changed LICENSES/other/ to be > LICENSES/deprecated/ > https://lore.kernel.org/all/20190430105130.24500-4-hch@lst.de/ > > So it is nice that someone decided to deprecate it without notifying users > about such change. It will be better to put Linux-OpenIB to LICENSES/dual/ > folder instead. > > Our lawyers are perfectly fine with Linux-OpenIB license. Almost all others are not, sorry, you will have to convince them otherwise, so for now, let's keep this in "deprecated" as this license is known to have issues and should not get applied to any new code without EXPLICIT justification why it must be so. thanks, greg k-h