Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Wed, 18 Oct 2023 08:51:51 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Saeed Mahameed <saeed@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, Leon Romanovsky <leonro@nvidia.com>,
        Jiri Pirko <jiri@nvidia.com>,
        Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [PATCH 5/5] misc: mlx5ctl: Add umem reg/unreg ioctl
Message-ID: <20231018115151.GP3952@nvidia.com>
References: <20231018081941.475277-1-saeed@kernel.org>
 <20231018081941.475277-6-saeed@kernel.org>
 <bfdc04b3-d776-4cb9-a95a-eec317e792e1@app.fastmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bfdc04b3-d776-4cb9-a95a-eec317e792e1@app.fastmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TGHMkXyV4YMF7fGlSjegfsDQtbkB2Nln0qLqNzQYW/wvavvU/p38zUqLk7/u?=
 =?us-ascii?Q?XVO2219ug6kFxgfobqd1TH7gtaTK9GMqJyLa7pQbkPBJvbzjfeNFjB9xzHDW?=
 =?us-ascii?Q?iCW5FSllGDl39MEo8C/VVJVVTvVthESrgogA3hYmH8AYo7ztlAjvMrV6jGOM?=
 =?us-ascii?Q?3ADCTMgk0yngTIwPzF1gDe0CQLsD1l3532cRHSoObfUZTxjBzSWW148TRIlV?=
 =?us-ascii?Q?ILscotKhM39ewLNfCbE4oIPL0i/tPKgfnnOJ9V3W0N1Sj0APhtagbJ+0u5Fj?=
 =?us-ascii?Q?oKY1Up3UWOu57BnpjVZxbIzRBpikaLEaZlw9NaCSzTb9zrF7ompONGHpTb45?=
 =?us-ascii?Q?F4cFpLgd44xqe0dkE9elu9OrmfWF11+cb44ptoHm0Q4g5BQbe2cuE7SamROK?=
 =?us-ascii?Q?KRUzSrCRo7VvutuhBBbX1U+O0nIgUijkPQnxu7Wj4PuEcArzD4whzGju0B5E?=
 =?us-ascii?Q?gYpcMbjc9kq7BO3w0asvkBkWa4qztb3TsxrH0DS76fUd3s1PIXFktRcyQzQU?=
 =?us-ascii?Q?wfwXAuJkFPeV9w8JhxfM7CDOO2nyynAvDMaddyDHBGSoIFCWC15GoKYOseYx?=
 =?us-ascii?Q?zEEjePJDgH7g5XXdk0u/mvAuDr9B8W51Ec2rp5BkUG1u+DN6JKFTEuk0oAzZ?=
 =?us-ascii?Q?xk3tY0psAlQrkXwQF5t5r1rQtGiiraClSjK7T6H9piaFlK5ZqPC+YwFBz3DL?=
 =?us-ascii?Q?G/PPvRd9Z+rcYJLusp49gHjEVmsK3h0T+4dF2bfx+KWP145GDWOPmHwA4nJq?=
 =?us-ascii?Q?Vvn1skffINyggtOQE+pZyzB4gLlmUqTnhw9SVD88nXrpzopD1og+JHg5R85Y?=
 =?us-ascii?Q?pvB07WBjiJorHQxdDEIvFLbosu255h/7PZbE6tNe2gh9VtV2CxLHJ89B4+Kj?=
 =?us-ascii?Q?iqzlxVWJFbZ5EnlwkcDlmD/PbREzgA3EsyGTk2kWIyo+TOTUgD3fEvLlJ8Og?=
 =?us-ascii?Q?9IFLY+pPvshVFYiy9WMzKPhFiyce/JxLiDOVWQPHeUVdY5Ume8Ro8ze1xh59?=
 =?us-ascii?Q?R0W8LOR5RjZivjBOU5WKIEfiEwZu94unDKX9Q/n1L7DCejRRdjOs4LT5WhdG?=
 =?us-ascii?Q?4mkOHuBy8BP4deseUc52BgG4Yk7wPI3VGZGesWOnxFaaV9dFRBBedYt9MEVd?=
 =?us-ascii?Q?Kd/MjjuicGmJANOaqp7Lb394elAtjUX9c/d4Gi+hm0LnqSjGf7Vwhm8xguO/?=
 =?us-ascii?Q?+ZwecMQwJAkWnwedBXT0O7+b5kr77OB4U/C9t32wTGHO/Wr9kmlDGl2G1ACy?=
 =?us-ascii?Q?WwV25PO+LRG/tynLqq95kEMvEavRhtW9jtpe7Edbw5ch9ImiivfA3FkcOuSS?=
 =?us-ascii?Q?kxVM+rmXOFBkGVMplNFO1GFgHKlXaicSV2F3xvV8Fpvkic6dFkaEVcjrzevX?=
 =?us-ascii?Q?ZxZAO2A55RV+461+m/dnPdWJjAve55Ypu1VCK8fuqKci8t68d0nPqxSKy3UR?=
 =?us-ascii?Q?WwdUY4D+MvWdrRsareBge/gBVtib7vkSBwoIROUuBJtDvjsinnvXjQnXtlvd?=
 =?us-ascii?Q?wCD9xEFNwKzzGjFMurR0mnga76848uVGOhoUfZ/JYud9H/4tK/pVSbbBJh41?=
 =?us-ascii?Q?o8liXjYuxCWotM94ZNP7zlQelWpd7X6H7hyL0OY6?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef2a56e0-0abe-4b7f-7c12-08dbcfd09f5d
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 11:51:53.8159
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0NnNhEoYbw1dl43lnfBsHAx6FbqnEwtEN4rzDjWy5q1+xYuh+ecAyA8FRUcC0dLF
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6776
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 18 Oct 2023 04:52:15 -0700 (PDT)

On Wed, Oct 18, 2023 at 11:30:24AM +0200, Arnd Bergmann wrote:

> > +struct mlx5ctl_umem_reg {
> > +	__aligned_u64 addr; /* user address */
> > +	__aligned_u64 len; /* user buffer length */
> > +	__aligned_u64 flags;
> > +	__u32 umem_id; /* returned device's umem ID */
> > +	__u32 reserved[7];
> > +};
> > +
>
> You have a 'flags' argument that is never accessed and can
> probably be removed. If the intention was to make the ioctl
> extensible for the future, this doesn't work unless you
> ensure that only known flags (i.e. none at this point)
> are set,

Yes, all the reserved fields and flags should be checked for 0 in the
ioctl paths to allow them to be used for something else someday.

> and it's probably a bad idea anyway, compared
> to creating a new ioctl command with new semantics.

This has been done successfully quite often in the kernel.

Thanks,
Jason