Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <4293617a-f6a7-444f-b6f8-ac7297d9e9b1@quicinc.com>
Date:   Wed, 18 Oct 2023 17:27:21 +0530
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v13 08/10] arm64: dts: qcom: sc8280xp: Add multiport
 controller node for SC8280
From:   Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
To:     Konrad Dybcio <konrad.dybcio@linaro.org>
CC:     <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <quic_pkondeti@quicinc.com>, <quic_ppratap@quicinc.com>,
        <quic_jackp@quicinc.com>, <ahalaney@redhat.com>,
        <quic_shazhuss@quicinc.com>,
        Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        "Andy Gross" <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        "Rob Herring" <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Felipe Balbi <balbi@kernel.org>,
        "Wesley Cheng" <quic_wcheng@quicinc.com>,
        Johan Hovold <johan@kernel.org>
References: <20231007154806.605-1-quic_kriskura@quicinc.com>
 <20231007154806.605-9-quic_kriskura@quicinc.com>
 <467dd1cc-64af-43d7-93ca-be28043e2765@linaro.org>
 <cceab5a9-ac0f-4ecd-9aa5-0ede5615a13d@quicinc.com>
Content-Language: en-US
In-Reply-To: <cceab5a9-ac0f-4ecd-9aa5-0ede5615a13d@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 10/12/2023 10:32 PM, Krishna Kurapati PSSNV wrote:
> 
> 
> On 10/12/2023 10:10 PM, Konrad Dybcio wrote:
>>
>>
>> On 10/7/23 17:48, Krishna Kurapati wrote:
>>> Add USB and DWC3 node for tertiary port of SC8280 along with multiport
>>> IRQ's and phy's. This will be used as a base for SA8295P and SA8295-Ride
>>> platforms.
>>>
>>> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
>>> ---
>> [...]
>>
>>> +
>>> +            interconnects = <&aggre1_noc MASTER_USB3_MP 0 &mc_virt 
>>> SLAVE_EBI1 0>,
>>> +                    <&gem_noc MASTER_APPSS_PROC 0 &config_noc 
>>> SLAVE_USB3_MP 0>;
>> Please use QCOM_ICC_TAG_ALWAYS from 
>> include/dt-bindings/interconnect/qcom,icc.h (like in sa8775p)
>>
>> With that I think it's good to go :)
>>
> Hi Konrad. Thanks for the review.
> 
> I see that the tags are used fr spi/i2c but not usb. So to maintain 
> uniformity, wanted to keep the same here.
> 

Hi Konrad,

  Even in sa8775p.dtsi, the interconnect nodes have 0 & 1 instead of 
macros. So wouldn't it be disturbing the uniformity if we use ICC_TAG's 
here. Let me know your thoughts on this.

Regards,
Krishna,